From: Jeffrey Hugo <jhugo@codeaurora.org>
To: bbhatt@codeaurora.org
Cc: manivannan.sadhasivam@linaro.org, hemantk@codeaurora.org,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kernel-owner@vger.kernel.org
Subject: Re: [PATCH] bus: mhi: core: Use current ee in intvec handler
Date: Sun, 17 May 2020 13:38:30 -0600 [thread overview]
Message-ID: <713dc189-561d-3c4a-f856-26d006524485@codeaurora.org> (raw)
In-Reply-To: <aab020af0372b11ff63ba4526aab0fdc@codeaurora.org>
On 5/15/2020 8:58 PM, bbhatt@codeaurora.org wrote:
> On 2020-05-14 19:17, Jeffrey Hugo wrote:
>> The intvec handler stores the caches ee in a local variable for use in
>> processing the intvec. It should instead use the current ee which is
>> read at the beginning of the intvec incase that the intvec is related to
>> an ee change. Otherwise, the handler might make the wrong decision
>> based on an incorrect ee.
>>
>> Fixes: 3000f85b8f47 (bus: mhi: core: Add support for basic PM operations)
>> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
>> ---
>> drivers/bus/mhi/core/main.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/bus/mhi/core/main.c b/drivers/bus/mhi/core/main.c
>> index 7272a5a..0a41fe5 100644
>> --- a/drivers/bus/mhi/core/main.c
>> +++ b/drivers/bus/mhi/core/main.c
>> @@ -386,8 +386,8 @@ irqreturn_t mhi_intvec_threaded_handler(int
>> irq_number, void *dev)
>> write_lock_irq(&mhi_cntrl->pm_lock);
>> if (MHI_REG_ACCESS_VALID(mhi_cntrl->pm_state)) {
>> state = mhi_get_mhi_state(mhi_cntrl);
>> - ee = mhi_cntrl->ee;
>> mhi_cntrl->ee = mhi_get_exec_env(mhi_cntrl);
>> + ee = mhi_cntrl->ee;
>> }
>>
>> if (state == MHI_STATE_SYS_ERR) {
> Hi Jeff,
>
> Let's hold off on this change for now please as we have some good set of
> bug fixes and improvements coming in very soon. They're only pending post
> to LKML.
Does that series of changes address the same issue this patch does, and
are they going to be posted soon (ie this week)?
--
Jeffrey Hugo
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply other threads:[~2020-05-17 19:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 2:17 [PATCH] bus: mhi: core: Use current ee in intvec handler Jeffrey Hugo
2020-05-16 2:58 ` bbhatt
2020-05-17 19:38 ` Jeffrey Hugo [this message]
2020-05-18 17:31 ` bbhatt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=713dc189-561d-3c4a-f856-26d006524485@codeaurora.org \
--to=jhugo@codeaurora.org \
--cc=bbhatt@codeaurora.org \
--cc=hemantk@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel-owner@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).