linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Kaitao Cheng <pilgrimtao@gmail.com>, axboe@kernel.dk
Cc: damien.lemoal@wdc.com, ming.lei@redhat.com,
	martin.petersen@oracle.com, satyat@google.com,
	chaitanya.kulkarni@wdc.com, houtao1@huawei.com,
	asml.silence@gmail.com, ajay.joshi@wdc.com,
	linux-kernel@vger.kernel.org, songmuchun@bytedance.com
Subject: Re: [PATCH] linux/blkdev.h: Use ilog2() directly in blksize_bits()
Date: Sat, 23 May 2020 11:33:14 -0700	[thread overview]
Message-ID: <714861ac-50aa-465c-c28f-dce7e16d0313@acm.org> (raw)
In-Reply-To: <20200523155048.29369-1-pilgrimtao@gmail.com>

On 2020-05-23 08:50, Kaitao Cheng wrote:
> blksize_bits() can be achieved through ilog2(), and ilog2() is
> more efficient.

If Jens agrees, how about removing the blksize_bits() function entirely
and to make all callers use ilog2() instead of blksize_bits()?

Thanks,

Bart.

  parent reply	other threads:[~2020-05-23 18:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-23 15:50 [PATCH] linux/blkdev.h: Use ilog2() directly in blksize_bits() Kaitao Cheng
2020-05-23 17:07 ` Jens Axboe
2020-05-23 18:33 ` Bart Van Assche [this message]
2020-05-23 18:50   ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=714861ac-50aa-465c-c28f-dce7e16d0313@acm.org \
    --to=bvanassche@acm.org \
    --cc=ajay.joshi@wdc.com \
    --cc=asml.silence@gmail.com \
    --cc=axboe@kernel.dk \
    --cc=chaitanya.kulkarni@wdc.com \
    --cc=damien.lemoal@wdc.com \
    --cc=houtao1@huawei.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=ming.lei@redhat.com \
    --cc=pilgrimtao@gmail.com \
    --cc=satyat@google.com \
    --cc=songmuchun@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).