Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU

From: "pankaj.dubey" <pankaj.dubey@samsung.com>
To: Jisheng Zhang <jszhang@marvell.com>
Cc: linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, rmk+kernel@armlinux.org.uk,
	arnd@arndb.de, horms@verge.net.au, magnus.damm@gmail.com,
	geert+renesas@glider.be, vireshk@kernel.org,
	shiraz.linux.kernel@gmail.com, krzk@kernel.org,
	thomas.ab@samsung.com, Russell King <linux@armlinux.org.uk>,
	Dinh Nguyen <dinguyen@opensource.altera.com>,
	Patrice Chotard <patrice.chotard@st.com>,
	Linus Walleij <linus.walleij@linaro.org>,
	Liviu Dudau <liviu.dudau@arm.com>, Ray Jui <rjui@broadcom.com>,
	Stephen Warren <swarren@wwwdotorg.org>,
	Heiko Stuebner <heiko@sntech.de>, Shawn Guo <shawnguo@kernel.org>,
	Michal Simek <michal.simek@xilinx.com>,
	Wei Xu <xuwei5@hisilicon.com>, Andrew Lunn <andrew@lunn.ch>,
	Jun Nie <jun.nie@linaro.org>, "cpgs ." <cpgs@samsung.com>
Subject: Re: [PATCH 01/16] ARM: scu: Provide support for parsing SCU device node to enable SCU
Date: Mon, 14 Nov 2016 14:10:16 +0530	[thread overview]
Message-ID: <71596b86-7653-5c02-fc46-59409a91243f@samsung.com> (raw)
In-Reply-To: <20161114141251.7ea86e7a@xhacker>

Hi Jisheng,

On Monday 14 November 2016 11:42 AM, Jisheng Zhang wrote:
> Hi Pankaj,
> 
> On Mon, 14 Nov 2016 10:31:56 +0530 Pankaj Dubey wrote:

<snip>

>> +
>> +	np = of_find_matching_node(NULL, scu_match);
> 
> could we check np before calling of_iomap()?
> 

of_iomap takes care of that, and will return NULL if np is NULL.

So additional check of np is not required here.

>> +	scu_base = of_iomap(np, 0);
>> +	of_node_put(np);
>> +	if (!scu_base) {
>> +		pr_err("%s failed to map scu_base via DT\n", __func__);
> 
> For non-ca5, non-ca9 based SoCs, we'll see this error msg. We understand
> what does it mean, but it may confuse normal users. In current version,
> berlin doesn't complain like this for non-ca9 SoCs
> 

OK, let me see other reviewer's comment on this. Then we will decide if
this error message is required or can be omitted.

Thanks,
Pankaj Dubey