From mboxrd@z Thu Jan 1 00:00:00 1970 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755180AbeAIKtX (ORCPT + 1 other); Tue, 9 Jan 2018 05:49:23 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:9135 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750788AbeAIKtU (ORCPT ); Tue, 9 Jan 2018 05:49:20 -0500 From: Philippe CORNU To: Brian Norris , Archit Taneja , Andrzej Hajda , "Laurent Pinchart" CC: David Airlie , Yannick FERTRE , Vincent ABRIOU , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" , Sean Paul , "Nickey Yang" , "hl@rock-chips.com" , "linux-rockchip@lists.infradead.org" , "mka@chromium.org" , "hoegsberg@gmail.com" , "zyw@rock-chips.com" , "xbl@rock-chips.com" Subject: Re: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet() Thread-Topic: [PATCH] drm/bridge/synopsys: dsi: use common mipi_dsi_create_packet() Thread-Index: AQHThoap1QCkJ49j+0ukvgxd0HhaQKNrUQSA Date: Tue, 9 Jan 2018 10:48:43 +0000 Message-ID: <715bb58c-efa6-7944-f186-c186d7fae569@st.com> References: <20180106003813.4816-1-briannorris@chromium.org> In-Reply-To: <20180106003813.4816-1-briannorris@chromium.org> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.45] Content-Type: text/plain; charset="utf-8" Content-ID: <8B6207ECDEC32444856925812D0FC96B@st.com> Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-01-09_06:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: SGkgQnJpYW4sDQoNCkFuZCBtYW55IHRoYW5rcyBmb3IgaW1wbGVtZW50aW5nIHRoZXNlIFRPRE9z Lg0KDQpPbiAwMS8wNi8yMDE4IDAxOjM4IEFNLCBCcmlhbiBOb3JyaXMgd3JvdGU6DQo+IFRoaXMg dGFrZXMgY2FyZSBvZiAyIFRPRE9zIGluIHRoaXMgZHJpdmVyLCBieSB1c2luZyB0aGUgY29tbW9u IERTSQ0KPiBwYWNrZXQtbWFyc2hhbGxpbmcgY29kZSBpbnN0ZWFkIG9mIG91ciBjdXN0b20gc2hv cnQvbG9uZyB3cml0ZSBjb2RlLg0KPiBUaGlzIGJvdGggc2F2ZXMgdXMgc29tZSBkdXBsaWNhdGVk IGNvZGUgYW5kIGdldHMgdXMgZnJlZSBzdXBwb3J0IGZvcg0KPiBjb21tYW5kIHR5cGVzIHRoYXQg d2VyZW4ndCBhbHJlYWR5IHBhcnQgb2Ygb3VyIHN3aXRjaCBibG9jayAoZS5nLiwNCj4gTUlQSV9E U0lfR0VORVJJQ19MT05HX1dSSVRFKS4NCj4gDQo+IFRoZSBjb2RlIGxvZ2ljIHN0YXlzIG1vc3Rs eSBpbnRhY3QsIGV4Y2VwdCB0aGF0IGl0IGJlY29tZXMgdW5uZWNlc3NhcnkNCj4gdG8gc3BsaXQg dGhlIHNob3J0L2xvbmcgd3JpdGUgZnVuY3Rpb25zLCBhbmQgd2UgaGF2ZSB0byBjb3B5IGRhdGEg YSBiaXQNCj4gbW9yZS4NCj4gDQo+IEFsb25nIHRoZSB3YXksIEkgbm90aWNlZCB0aGF0IGxvb3Ag Ym91bmRzIHdlcmUgYSBsaXR0bGUgb2RkOg0KPiANCj4gCXdoaWxlIChESVZfUk9VTkRfVVAobGVu LCBwbGRfZGF0YV9ieXRlcykpDQo+IA0KPiBUaGlzIHJlYWxseSB3YXMganVzdCBzdXBwb3NlZCB0 byBiZSAnbGVuICE9IDAnLCBzbyBJIG1hZGUgdGhhdCBtb3JlDQo+IGNsZWFyLg0KPiANCj4gVGVz dGVkIG9uIFJLMzM5OSB3aXRoIHNvbWUgcGVuZGluZyByZWZhY3RvcmluZyBwYXRjaGVzIGJ5IE5p Y2tleSBZYW5nLA0KPiB0byBtYWtlIHRoZSBSb2NrY2hpcCBEU0kgZHJpdmVyIHdyYXAgdGhpcyBj b21tb24gZHJpdmVyLg0KPiANCj4gU2lnbmVkLW9mZi1ieTogQnJpYW4gTm9ycmlzIDxicmlhbm5v cnJpc0BjaHJvbWl1bS5vcmc+DQo+IC0tLQ0KPiBDb3VsZCB1c2UgYW4gZXh0cmEgbG9vayBmcm9t IGZvbGtzLiBUaGlzIGxvb2tzIGxpa2UgdGhlIGNvcnJlY3QgdHJpdmlhbA0KPiB0cmFuc2Zvcm1h dGlvbiwgYnV0IEknbSBub3QgdGhhdCBmYW1pbGlhciB3aXRoIERTSS4NCj4gDQo+ICAgZHJpdmVy cy9ncHUvZHJtL2JyaWRnZS9zeW5vcHN5cy9kdy1taXBpLWRzaS5jIHwgNzggKysrKysrLS0tLS0t LS0tLS0tLS0tLS0tLS0tDQo+ICAgMSBmaWxlIGNoYW5nZWQsIDE2IGluc2VydGlvbnMoKyksIDYy IGRlbGV0aW9ucygtKQ0KPiANCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uv c3lub3BzeXMvZHctbWlwaS1kc2kuYyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lub3BzeXMv ZHctbWlwaS1kc2kuYw0KPiBpbmRleCBkOWNjYTRmZDY2ZWMuLjJmZWQyMGU0NGRmZSAxMDA2NDQN Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2JyaWRnZS9zeW5vcHN5cy9kdy1taXBpLWRzaS5jDQo+ ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9icmlkZ2Uvc3lub3BzeXMvZHctbWlwaS1kc2kuYw0KPiBA QCAtMTM2LDEwICsxMzYsNiBAQA0KPiAgIAkJCQkJIEdFTl9TV18wUF9UWF9MUCkNCj4gICANCj4g ICAjZGVmaW5lIERTSV9HRU5fSERSCQkJMHg2Yw0KPiAtLyogVE9ETyBUaGVzZSAyIGRlZmluZXMg d2lsbCBiZSByZXdvcmtlZCB0aGFua3MgdG8gbWlwaV9kc2lfY3JlYXRlX3BhY2tldCgpICovDQo+ IC0jZGVmaW5lIEdFTl9IREFUQShkYXRhKQkJCSgoKGRhdGEpICYgMHhmZmZmKSA8PCA4KQ0KPiAt I2RlZmluZSBHRU5fSFRZUEUodHlwZSkJCQkoKCh0eXBlKSAmIDB4ZmYpIDw8IDApDQo+IC0NCj4g ICAjZGVmaW5lIERTSV9HRU5fUExEX0RBVEEJCTB4NzANCj4gICANCj4gICAjZGVmaW5lIERTSV9D TURfUEtUX1NUQVRVUwkJMHg3NA0KPiBAQCAtMzU5LDQ0ICszNTUsMTUgQEAgc3RhdGljIGludCBk d19taXBpX2RzaV9nZW5fcGt0X2hkcl93cml0ZShzdHJ1Y3QgZHdfbWlwaV9kc2kgKmRzaSwgdTMy IGhkcl92YWwpDQo+ICAgCXJldHVybiAwOw0KPiAgIH0NCj4gICANCj4gLXN0YXRpYyBpbnQgZHdf bWlwaV9kc2lfZGNzX3Nob3J0X3dyaXRlKHN0cnVjdCBkd19taXBpX2RzaSAqZHNpLA0KPiAtCQkJ CSAgICAgICBjb25zdCBzdHJ1Y3QgbWlwaV9kc2lfbXNnICptc2cpDQo+IC17DQo+IC0JY29uc3Qg dTggKnR4X2J1ZiA9IG1zZy0+dHhfYnVmOw0KPiAtCXUxNiBkYXRhID0gMDsNCj4gLQl1MzIgdmFs Ow0KPiAtDQo+IC0JaWYgKG1zZy0+dHhfbGVuID4gMCkNCj4gLQkJZGF0YSB8PSB0eF9idWZbMF07 DQo+IC0JaWYgKG1zZy0+dHhfbGVuID4gMSkNCj4gLQkJZGF0YSB8PSB0eF9idWZbMV0gPDwgODsN Cj4gLQ0KPiAtCWlmIChtc2ctPnR4X2xlbiA+IDIpIHsNCj4gLQkJZGV2X2Vycihkc2ktPmRldiwg InRvbyBsb25nIHR4IGJ1ZiBsZW5ndGggJXp1IGZvciBzaG9ydCB3cml0ZVxuIiwNCj4gLQkJCW1z Zy0+dHhfbGVuKTsNCj4gLQkJcmV0dXJuIC1FSU5WQUw7DQo+IC0JfQ0KPiAtDQo+IC0JdmFsID0g R0VOX0hEQVRBKGRhdGEpIHwgR0VOX0hUWVBFKG1zZy0+dHlwZSk7DQo+IC0JcmV0dXJuIGR3X21p cGlfZHNpX2dlbl9wa3RfaGRyX3dyaXRlKGRzaSwgdmFsKTsNCj4gLX0NCj4gLQ0KPiAtc3RhdGlj IGludCBkd19taXBpX2RzaV9kY3NfbG9uZ193cml0ZShzdHJ1Y3QgZHdfbWlwaV9kc2kgKmRzaSwN Cj4gLQkJCQkgICAgICBjb25zdCBzdHJ1Y3QgbWlwaV9kc2lfbXNnICptc2cpDQo+ICtzdGF0aWMg aW50IGR3X21pcGlfZHNpX2Rjc193cml0ZShzdHJ1Y3QgZHdfbWlwaV9kc2kgKmRzaSwNCj4gKwkJ CQkgY29uc3Qgc3RydWN0IG1pcGlfZHNpX3BhY2tldCAqcGFja2V0KQ0KDQpCb3RoIERDUyBhbmQg R2VuZXJpYyBkc2kgdHJhbnNmZXJzIGFyZSBtYW5hZ2VkIGJ5IGRybV9taXBpX2RzaS5jIA0KaGVs cGVycy4gU28gbWF5YmUgZHdfbWlwaV9kc2lfZGNzX3dyaXRlKCkgc2hvdWxkIGJlIHJlbmFtZWQg DQpkd19taXBpX2RzaV93cml0ZSgpLi4uDQoNCg0KPiAgIHsNCj4gLQljb25zdCB1OCAqdHhfYnVm ID0gbXNnLT50eF9idWY7DQo+IC0JaW50IGxlbiA9IG1zZy0+dHhfbGVuLCBwbGRfZGF0YV9ieXRl cyA9IHNpemVvZih1MzIpLCByZXQ7DQo+IC0JdTMyIGhkcl92YWwgPSBHRU5fSERBVEEobXNnLT50 eF9sZW4pIHwgR0VOX0hUWVBFKG1zZy0+dHlwZSk7DQo+ICsJY29uc3QgdTggKnR4X2J1ZiA9IHBh Y2tldC0+cGF5bG9hZDsNCj4gKwlpbnQgbGVuID0gcGFja2V0LT5wYXlsb2FkX2xlbmd0aCwgcGxk X2RhdGFfYnl0ZXMgPSBzaXplb2YodTMyKSwgcmV0Ow0KPiAgIAl1MzIgcmVtYWluZGVyOw0KPiAg IAl1MzIgdmFsOw0KPiAgIA0KPiAtCWlmIChtc2ctPnR4X2xlbiA8IDMpIHsNCj4gLQkJZGV2X2Vy cihkc2ktPmRldiwgIndyb25nIHR4IGJ1ZiBsZW5ndGggJXp1IGZvciBsb25nIHdyaXRlXG4iLA0K PiAtCQkJbXNnLT50eF9sZW4pOw0KPiAtCQlyZXR1cm4gLUVJTlZBTDsNCj4gLQl9DQo+IC0NCj4g LQl3aGlsZSAoRElWX1JPVU5EX1VQKGxlbiwgcGxkX2RhdGFfYnl0ZXMpKSB7DQo+ICsJd2hpbGUg KGxlbikgew0KPiAgIAkJaWYgKGxlbiA8IHBsZF9kYXRhX2J5dGVzKSB7DQo+ICAgCQkJcmVtYWlu ZGVyID0gMDsNCj4gICAJCQltZW1jcHkoJnJlbWFpbmRlciwgdHhfYnVmLCBsZW4pOw0KPiBAQCAt NDE5LDQwICszODYsMjcgQEAgc3RhdGljIGludCBkd19taXBpX2RzaV9kY3NfbG9uZ193cml0ZShz dHJ1Y3QgZHdfbWlwaV9kc2kgKmRzaSwNCj4gICAJCX0NCj4gICAJfQ0KPiAgIA0KPiAtCXJldHVy biBkd19taXBpX2RzaV9nZW5fcGt0X2hkcl93cml0ZShkc2ksIGhkcl92YWwpOw0KPiArCXJlbWFp bmRlciA9IDA7DQo+ICsJbWVtY3B5KCZyZW1haW5kZXIsIHBhY2tldC0+aGVhZGVyLCBzaXplb2Yo cGFja2V0LT5oZWFkZXIpKTsNCj4gKwlyZXR1cm4gZHdfbWlwaV9kc2lfZ2VuX3BrdF9oZHJfd3Jp dGUoZHNpLCByZW1haW5kZXIpOw0KPiAgIH0NCj4gICANCj4gICBzdGF0aWMgc3NpemVfdCBkd19t aXBpX2RzaV9ob3N0X3RyYW5zZmVyKHN0cnVjdCBtaXBpX2RzaV9ob3N0ICpob3N0LA0KPiAgIAkJ CQkJIGNvbnN0IHN0cnVjdCBtaXBpX2RzaV9tc2cgKm1zZykNCj4gICB7DQo+ICAgCXN0cnVjdCBk d19taXBpX2RzaSAqZHNpID0gaG9zdF90b19kc2koaG9zdCk7DQo+ICsJc3RydWN0IG1pcGlfZHNp X3BhY2tldCBwYWNrZXQ7DQo+ICAgCWludCByZXQ7DQo+ICAgDQo+IC0JLyoNCj4gLQkgKiBUT0RP IGR3IGRydiBpbXByb3ZlbWVudHMNCj4gLQkgKiB1c2UgbWlwaV9kc2lfY3JlYXRlX3BhY2tldCgp IGluc3RlYWQgb2YgYWxsIGZvbGxvd2luZw0KPiAtCSAqIGZ1bmN0aW9ucyBhbmQgY29kZSAobm8g c3dpdGNoIGNhc2VzLCBubw0KPiAtCSAqIGR3X21pcGlfZHNpX2Rjc19zaG9ydF93cml0ZSgpLCBv bmx5IHRoZSBsb29wIGluIGxvbmdfd3JpdGUuLi4pDQo+IC0JICogYW5kIHVzZSBwYWNrZXQuaGVh ZGVyLi4uDQo+IC0JICovDQo+IC0JZHdfbWlwaV9tZXNzYWdlX2NvbmZpZyhkc2ksIG1zZyk7DQo+ IC0NCj4gLQlzd2l0Y2ggKG1zZy0+dHlwZSkgew0KPiAtCWNhc2UgTUlQSV9EU0lfRENTX1NIT1JU X1dSSVRFOg0KPiAtCWNhc2UgTUlQSV9EU0lfRENTX1NIT1JUX1dSSVRFX1BBUkFNOg0KPiAtCWNh c2UgTUlQSV9EU0lfU0VUX01BWElNVU1fUkVUVVJOX1BBQ0tFVF9TSVpFOg0KPiAtCQlyZXQgPSBk d19taXBpX2RzaV9kY3Nfc2hvcnRfd3JpdGUoZHNpLCBtc2cpOw0KPiAtCQlicmVhazsNCj4gLQlj YXNlIE1JUElfRFNJX0RDU19MT05HX1dSSVRFOg0KPiAtCQlyZXQgPSBkd19taXBpX2RzaV9kY3Nf bG9uZ193cml0ZShkc2ksIG1zZyk7DQo+IC0JCWJyZWFrOw0KPiAtCWRlZmF1bHQ6DQo+IC0JCWRl dl9lcnIoZHNpLT5kZXYsICJ1bnN1cHBvcnRlZCBtZXNzYWdlIHR5cGUgMHglMDJ4XG4iLA0KPiAt CQkJbXNnLT50eXBlKTsNCj4gLQkJcmV0ID0gLUVJTlZBTDsNCj4gKwlyZXQgPSBtaXBpX2RzaV9j cmVhdGVfcGFja2V0KCZwYWNrZXQsIG1zZyk7DQo+ICsJaWYgKHJldCkgew0KPiArCQlkZXZfZXJy KGRzaS0+ZGV2LCAiZmFpbGVkIHRvIGNyZWF0ZSBwYWNrZXQ6ICVkXG4iLCByZXQpOw0KPiArCQly ZXR1cm4gcmV0Ow0KPiAgIAl9DQo+ICAgDQo+IC0JcmV0dXJuIHJldDsNCj4gKwlkd19taXBpX21l c3NhZ2VfY29uZmlnKGRzaSwgbXNnKTsNCj4gKw0KPiArCXJldHVybiBkd19taXBpX2RzaV9kY3Nf d3JpdGUoZHNpLCAmcGFja2V0KTsNCj4gICB9DQo+ICAgDQo+ICAgc3RhdGljIGNvbnN0IHN0cnVj dCBtaXBpX2RzaV9ob3N0X29wcyBkd19taXBpX2RzaV9ob3N0X29wcyA9IHsNCj4gDQoNCkkgcGVy Zm9ybWVkIHNvbWUgdGVzdHMgdHJhY2luZyBhbGwgRFNJX0dFTl9IRFIgJiBEU0lfR0VOX1BMRF9E QVRBIHJlZyANCndyaXRlcyB3aXRoIHBhbmVsL3BhbmVsLW9yaXNldGVjaC1vdG04MDA5YS5jICh1 c2luZyBsb25nIGRjcyBjb21tYW5kcykgDQpiZWZvcmUgYW5kIGFmdGVyIHlvdXIgcGF0Y2ggYW5k IHRoaXMgaXMgIjEwMCUgcGVyZmVjdCIhDQoNClNvLCBhcGFydCB0aGUgdW4taW1wb3J0YW50ICJk Y3MiIGluIGR3X21pcGlfZHNpX2Rjc193cml0ZSgpIGZ1bmN0aW9uIG5hbWU6DQoNClJldmlld2Vk LWJ5OiBQaGlsaXBwZSBDb3JudSA8cGhpbGlwcGUuY29ybnVAc3QuY29tPg0KVGVzdGVkLWJ5OiBQ aGlsaXBwZSBDb3JudSA8cGhpbGlwcGUuY29ybnVAc3QuY29tPg0KDQpUaGlzIGNsZWFuLXVwIHdp bGwgaGVscCBhIGxvdCB0byBhZGQgdGhlIGRzaSByZWFkIGZlYXR1cmUgaW4gdGhlIGZ1dHVyZS4N Cg0KVmVyeSBnb29kIHBhdGNoIEJyaWFuIGFuZCBiaWcgInRoYW5rIHlvdSIgIQ0KDQpQaGlsaXBw ZSA6LSk=