From: Dmitry Osipenko <digetx@gmail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Linux PM <linux-pm@vger.kernel.org>,
Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Jonathan Hunter <jonathanh@nvidia.com>,
Thierry Reding <thierry.reding@gmail.com>,
Rajendra Nayak <rnayak@codeaurora.org>,
Stephan Gerhold <stephan@gerhold.net>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] PM: domains: Drop the performance state vote for a device at detach
Date: Thu, 9 Sep 2021 16:48:49 +0300 [thread overview]
Message-ID: <71618f83-de5b-1180-60f4-8561c4f655a9@gmail.com> (raw)
In-Reply-To: <CAPDyKFoFPpPPd0cUDRhqzXzXaQyNAv7UZToTaHnGXY30QXNB9g@mail.gmail.com>
07.09.2021 13:16, Ulf Hansson пишет:
...
>>> Also note that a very similar problem exists, *before* the device gets
>>> attached in the first place. More precisely, nothing prevents the
>>> performance state from being set to a non-compatible value for an
>>> always-on HW/device that hasn't been attached yet. So maybe you need
>>> to set the maximum performance state at genpd initializations, then
>>> use the ->sync_state() callback to very that all consumers have been
>>> attached to the genpd provider, before allowing the state to be
>>> changed/lowered?
>>
>> That is already done by the PD driver.
>>
>> https://elixir.bootlin.com/linux/latest/source/drivers/soc/tegra/pmc.c#L3790
>
> Yes, I already knew that, but forgot it. :-) Thanks for the pointer.
> Let me rethink the approach.
>
> In a way, it kind of sounds like this is a generic problem - so
> perhaps we should think of adding a ->withdraw_sync_state() callback
> that can be assigned by provider drivers, to get informed when a
> consumer driver is getting unbinded.
Not sure, doesn't feel to me that this is necessary for today. A bit too
cumbersome for a simple sanity-check, IMO.
next prev parent reply other threads:[~2021-09-09 14:36 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-02 10:16 [PATCH 0/3] PM: domains: Improvements for performance states in genpd Ulf Hansson
2021-09-02 10:16 ` [PATCH 1/3] PM: domains: Drop the performance state vote for a device at detach Ulf Hansson
2021-09-03 6:01 ` Dmitry Osipenko
2021-09-03 8:22 ` Ulf Hansson
2021-09-03 9:58 ` Dmitry Osipenko
2021-09-03 14:03 ` Ulf Hansson
2021-09-05 8:26 ` Dmitry Osipenko
2021-09-06 10:24 ` Ulf Hansson
2021-09-06 14:11 ` Dmitry Osipenko
2021-09-06 17:34 ` Ulf Hansson
2021-09-06 19:33 ` Dmitry Osipenko
2021-09-07 10:16 ` Ulf Hansson
2021-09-09 13:48 ` Dmitry Osipenko [this message]
2021-09-09 14:45 ` Ulf Hansson
2021-09-02 10:16 ` [PATCH 2/3] PM: domains: Restructure some code in __genpd_dev_pm_attach() Ulf Hansson
2021-09-02 10:16 ` [PATCH 3/3] PM: domains: Add a ->dev_get_performance_state() callback to genpd Ulf Hansson
2021-09-03 6:00 ` Dmitry Osipenko
2021-09-03 8:55 ` Ulf Hansson
2021-09-03 10:06 ` Dmitry Osipenko
2021-09-03 14:09 ` Ulf Hansson
2021-09-05 9:11 ` Dmitry Osipenko
2021-09-06 10:53 ` Ulf Hansson
2021-09-06 14:35 ` Dmitry Osipenko
2021-09-07 3:40 ` Viresh Kumar
2021-09-07 8:10 ` Dmitry Osipenko
2021-09-07 9:57 ` Ulf Hansson
2021-09-09 13:48 ` Dmitry Osipenko
2021-09-09 14:39 ` Ulf Hansson
2021-09-10 11:24 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71618f83-de5b-1180-60f4-8561c4f655a9@gmail.com \
--to=digetx@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jonathanh@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rnayak@codeaurora.org \
--cc=stephan@gerhold.net \
--cc=thierry.reding@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).