linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: postix@posteo.eu
To: rostedt@goodmis.org
Cc: linux-kernel@vger.kernel.org, regressions@lists.linux.dev, tiwai@suse.de
Subject: Fwd: [REGRESSION 6.0.x / 6.1.x] NULL dereferencing at tracing
Date: Mon, 31 Oct 2022 20:47:01 +0000	[thread overview]
Message-ID: <71829e56-a13f-0462-37a7-a4d64c16f561@posteo.de> (raw)
In-Reply-To: <e693eb6b-28d0-d091-3df3-60f2b591c0e7@posteo.de>

> Can you apply this to see if it fixes it?
>
> I'm guessing there's a path to the release of the file descriptor where
> the ring buffer isn't allocated (and this expected it to be).
>
> I'll investigate further to see if I can find that path.
>
> -- Steve
>
> diff --git a/kernel/trace/ring_buffer.c b/kernel/trace/ring_buffer.c 
> index 199759c73519..c1c7ce4c6ddb 100644 --- 
> a/kernel/trace/ring_buffer.c +++ b/kernel/trace/ring_buffer.c @@ 
> -937,6 +937,9 @@ void ring_buffer_wake_waiters(struct trace_buffer 
> *buffer, int cpu)   	struct ring_buffer_per_cpu *cpu_buffer;
>   	struct rb_irq_work *rbwork;
>   
> + if (!buffer) + return; +   	if (cpu == RING_BUFFER_ALL_CPUS) {
>   
>   		/* Wake up individual ones too. One level recursion */

Dear Steve,


I have tested your suggested patch using kernel 6.1.0-rc2, but 
unfortunately it didn't fix the issue for me.

Thank you for looking into it though!


Best Regards

--AD





       reply	other threads:[~2022-10-31 20:47 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <e693eb6b-28d0-d091-3df3-60f2b591c0e7@posteo.de>
2022-10-31 20:47 ` postix [this message]
2022-11-02 15:57   ` Fwd: [REGRESSION 6.0.x / 6.1.x] NULL dereferencing at tracing postix
2022-11-02 16:03     ` Steven Rostedt
2022-11-02 16:36       ` postix
2022-11-02 16:39         ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=71829e56-a13f-0462-37a7-a4d64c16f561@posteo.de \
    --to=postix@posteo.eu \
    --cc=20221031144850.5522b036@rorschach.local.home \
    --cc=linux-kernel@vger.kernel.org \
    --cc=regressions@lists.linux.dev \
    --cc=rostedt@goodmis.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).