From: Sibi Sankar <sibis@codeaurora.org> To: Vinod Koul <vkoul@kernel.org> Cc: Andy Gross <andy.gross@linaro.org>, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Bjorn Andersson <bjorn.andersson@linaro.org> Subject: Re: [PATCH v5 14/18] arm64: dts: qcom: qcs404: Add remoteproc nodes Date: Mon, 19 Nov 2018 11:01:41 +0530 Message-ID: <718e105af9caeba834281dcab4aed499@codeaurora.org> (raw) In-Reply-To: <20181109094417.12109-15-vkoul@kernel.org> Hi Bjorn/Vinod, On 2018-11-09 15:14, Vinod Koul wrote: > From: Bjorn Andersson <bjorn.andersson@linaro.org> > > Add the TrustZone based remoteproc nodes and their glink edges for > adsp, cdsp and wcss. Enable them for EVB common DTS. > > Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org> > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- > arch/arm64/boot/dts/qcom/qcs404-evb.dtsi | 12 +++++ > arch/arm64/boot/dts/qcom/qcs404.dtsi | 93 > ++++++++++++++++++++++++++++++++ > 2 files changed, 105 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi > b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi > index db035fef67d9..a39924efebe4 100644 > --- a/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi > +++ b/arch/arm64/boot/dts/qcom/qcs404-evb.dtsi > @@ -21,6 +21,18 @@ > }; > }; > > +&remoteproc_adsp { > + status = "ok"; > +}; > + > +&remoteproc_cdsp { > + status = "ok"; > +}; > + > +&remoteproc_wcss { > + status = "ok"; > +}; > + > &rpm_requests { > pms405-regulators { > compatible = "qcom,rpm-pms405-regulators"; > diff --git a/arch/arm64/boot/dts/qcom/qcs404.dtsi > b/arch/arm64/boot/dts/qcom/qcs404.dtsi > index 46fce264c8fe..06607419c9d6 100644 > --- a/arch/arm64/boot/dts/qcom/qcs404.dtsi > +++ b/arch/arm64/boot/dts/qcom/qcs404.dtsi > @@ -80,6 +80,99 @@ > method = "smc"; > }; > > + remoteproc_adsp: remoteproc-adsp { > + compatible = "qcom,qcs404-adsp-pas"; > + > + interrupts-extended = <&intc GIC_SPI 293 IRQ_TYPE_EDGE_RISING>, > + <&adsp_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, > + <&adsp_smp2p_in 1 IRQ_TYPE_EDGE_RISING>, > + <&adsp_smp2p_in 2 IRQ_TYPE_EDGE_RISING>, > + <&adsp_smp2p_in 3 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "wdog", "fatal", "ready", > + "handover", "stop-ack"; > + > + clocks = <&xo_board>; > + clock-names = "xo"; > + > + memory-region = <&adsp_fw_mem>; > + > + qcom,smem-states = <&adsp_smp2p_out 0>; > + qcom,smem-state-names = "stop"; > + > + status = "disabled"; > + > + glink-edge { > + interrupts = <GIC_SPI 289 IRQ_TYPE_EDGE_RISING>; > + > + qcom,remote-pid = <2>; > + mboxes = <&apcs_glb 8>; > + > + label = "adsp"; > + }; > + }; > + > + remoteproc_cdsp: remoteproc-cdsp { > + compatible = "qcom,qcs404-cdsp-pas"; > + > + interrupts-extended = <&intc GIC_SPI 229 IRQ_TYPE_EDGE_RISING>, > + <&cdsp_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, > + <&cdsp_smp2p_in 1 IRQ_TYPE_EDGE_RISING>, > + <&cdsp_smp2p_in 2 IRQ_TYPE_EDGE_RISING>, > + <&cdsp_smp2p_in 3 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "wdog", "fatal", "ready", > + "handover", "stop-ack"; > + > + clocks = <&xo_board>; > + clock-names = "xo"; > + > + memory-region = <&cdsp_fw_mem>; > + > + qcom,smem-states = <&cdsp_smp2p_out 0>; > + qcom,smem-state-names = "stop"; > + > + status = "disabled"; > + > + glink-edge { > + interrupts = <GIC_SPI 141 IRQ_TYPE_EDGE_RISING>; > + > + qcom,remote-pid = <5>; > + mboxes = <&apcs_glb 12>; > + > + label = "cdsp"; > + }; > + }; > + > + remoteproc_wcss: remoteproc-wcss { > + compatible = "qcom,qcs404-wcss-pas"; > + > + interrupts-extended = <&intc GIC_SPI 153 IRQ_TYPE_EDGE_RISING>, > + <&wcss_smp2p_in 0 IRQ_TYPE_EDGE_RISING>, > + <&wcss_smp2p_in 1 IRQ_TYPE_EDGE_RISING>, > + <&wcss_smp2p_in 2 IRQ_TYPE_EDGE_RISING>, > + <&wcss_smp2p_in 3 IRQ_TYPE_EDGE_RISING>; > + interrupt-names = "wdog", "fatal", "ready", > + "handover", "stop-ack"; I can see that wcss remoteproc uses an additional smp2p interrupt called shutdown-ack downstream you may want to skip wcss entry for now till the shutdown-ack gets posted, reviewed and merged. > + > + clocks = <&xo_board>; > + clock-names = "xo"; > + > + memory-region = <&wlan_fw_mem>; > + > + qcom,smem-states = <&wcss_smp2p_out 0>; > + qcom,smem-state-names = "stop"; > + > + status = "disabled"; > + > + glink-edge { > + interrupts = <GIC_SPI 156 IRQ_TYPE_EDGE_RISING>; > + > + qcom,remote-pid = <1>; > + mboxes = <&apcs_glb 16>; > + > + label = "wcss"; > + }; > + }; > + > reserved-memory { > #address-cells = <2>; > #size-cells = <2>; -- -- Sibi Sankar -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project.
next prev parent reply index Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-11-09 9:43 [PATCH v5 00/18] arm64: dts: qcom: qcs404: Add Device tree nodes Vinod Koul 2018-11-09 9:44 ` [PATCH v5 01/18] arm64: dts: qcom: qcs404: add base dts files Vinod Koul 2018-11-17 23:10 ` Bjorn Andersson 2018-11-09 9:44 ` [PATCH v5 02/18] arm64: dts: qcom: qcs404-evb: add dts files for EVBs Vinod Koul 2018-11-17 23:11 ` Bjorn Andersson 2018-11-19 12:01 ` Amit Kucheria 2018-11-09 9:44 ` [PATCH v5 03/18] arm64: dts: qcom: qcs404: Add reserved-memory regions Vinod Koul 2018-11-09 9:44 ` [PATCH v5 04/18] arm64: dts: qcom: qcs404: Add RPM GLINK related nodes Vinod Koul 2018-11-09 9:44 ` [PATCH v5 05/18] arm64: dts: qcom: qcs404: Add PMS405 RPM regulators Vinod Koul 2018-11-09 9:44 ` [PATCH v5 06/18] arm64: dts: qcom: qcs404: add smp2p nodes Vinod Koul 2018-11-09 9:44 ` [PATCH v5 07/18] arm64: dts: qcom: qcs404: Add TLMM pinctrl node Vinod Koul 2018-11-09 9:44 ` [PATCH v5 08/18] arm64: dts: qcom: qcs404: Add sdcc1 node Vinod Koul 2018-11-09 9:44 ` [PATCH v5 09/18] arm64: dts: qcom: pms405: add spmi node Vinod Koul 2018-11-09 9:44 ` [PATCH v5 10/18] arm64: dts: qcom: qcs404: " Vinod Koul 2018-11-09 9:44 ` [PATCH v5 11/18] arm64: dts: qcom: pms405: add rtc node Vinod Koul 2018-11-09 9:44 ` [PATCH v5 12/18] arm64: dts: qcom: pms405: add gpios Vinod Koul 2018-11-17 23:12 ` Bjorn Andersson 2018-11-09 9:44 ` [PATCH v5 13/18] arm64: dts: qcom: qcs404: Add scm firmware node Vinod Koul 2018-11-09 9:44 ` [PATCH v5 14/18] arm64: dts: qcom: qcs404: Add remoteproc nodes Vinod Koul 2018-11-19 5:31 ` Sibi Sankar [this message] 2018-11-09 9:44 ` [PATCH v5 15/18] arm64: dts: qcom: qcs404: add prng-ee node Vinod Koul 2018-11-09 9:44 ` [PATCH v5 16/18] arm64: dts: qcom: qcs404: Add BAM DMA node Vinod Koul 2018-11-09 9:44 ` [PATCH v5 17/18] arm64: dts: qcom: qcs404: Use BAM DMA for serial uart2 Vinod Koul 2018-11-09 9:44 ` [PATCH v5 18/18] arm64: dts: qcom: pms405: Add pon and pwrkey nodes Vinod Koul
Reply instructions: You may reply publically to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=718e105af9caeba834281dcab4aed499@codeaurora.org \ --to=sibis@codeaurora.org \ --cc=andy.gross@linaro.org \ --cc=bjorn.andersson@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org public-inbox-index lkml Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/ public-inbox