From: Shuah Khan <skhan@linuxfoundation.org>
To: "Hongren Zheng (Zenithal)" <i@zenithal.me>,
Valentina Manea <valentina.manea.m@gmail.com>,
Shuah Khan <shuah@kernel.org>,
Antonio Borneo <borneo.antonio@gmail.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
matt mooney <mfm@muteddisk.com>,
linux-usb@vger.kernel.org, Shuah Khan <skhan@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 2/2] usbip: tools: add usage of device mode in usbip_list.c
Date: Wed, 24 Mar 2021 17:50:36 -0600 [thread overview]
Message-ID: <719c16e1-c220-3ff4-9389-bf2ae098e5dc@linuxfoundation.org> (raw)
In-Reply-To: <YFrwq75Uyef3c9gz@Sun>
On 3/24/21 1:56 AM, Hongren Zheng (Zenithal) wrote:
> The option '-d/--device' was implemented in 'usbip list' but not
> shown in usage. Hence this commit adds this option to usage.
>
> Signed-off-by: Hongren Zheng <i@zenithal.me>
> ---
> tools/usb/usbip/src/usbip_list.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> PATCH v2:
> Add signed-off-by line
>
> PATCH v3:
> Move patch changelog after the marker line
> Remove nickname in signed-off-by line
>
> PATCH v4:
> Use commit short hash and message instead of long hash only when
> referring to commit in the kernel
>
> PATCH v5:
> Add documentation of `usbip port` and its usage in examples
> Add flow of detaching in examples
> Rephrase some description and add punctuations
> Fix typo of `usbip attach --ev-id` to `--dev-id`
>
> diff --git a/tools/usb/usbip/src/usbip_list.c b/tools/usb/usbip/src/usbip_list.c
> index 8625b0f514ee..3d810bcca02f 100644
> --- a/tools/usb/usbip/src/usbip_list.c
> +++ b/tools/usb/usbip/src/usbip_list.c
> @@ -33,7 +33,8 @@ static const char usbip_list_usage_string[] =
> "usbip list [-p|--parsable] <args>\n"
> " -p, --parsable Parsable list format\n"
> " -r, --remote=<host> List the exportable USB devices on <host>\n"
> - " -l, --local List the local USB devices\n";
> + " -l, --local List the local USB devices\n"
> + " -d, --device List the local USB gadgets bound to usbip-vudc\n";
>
> void usbip_list_usage(void)
> {
>
Thank you. Looks good.
Acked-by: Shuah Khan <skhan@linuxfoundation.org>
thanks,
-- Shuah
next prev parent reply other threads:[~2021-03-24 23:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 12:55 [PATCH v4 1/2] usbip: tools: add options and examples in man page related to device mode Hongren Zheng (Zenithal)
2021-03-23 13:01 ` [PATCH v4 2/2] usbip: tools: add usage of device mode in usbip_list.c Hongren Zheng (Zenithal)
2021-03-23 15:45 ` Shuah Khan
2021-03-23 23:12 ` [PATCH v4 1/2] usbip: tools: add options and examples in man page related to device mode Shuah Khan
2021-03-24 4:36 ` Hongren Zheng (Zenithal)
2021-03-24 6:35 ` [PATCH v5 " Hongren Zheng (Zenithal)
2021-03-24 7:37 ` Greg Kroah-Hartman
2021-03-24 7:56 ` [PATCH v5 2/2] usbip: tools: add usage of device mode in usbip_list.c Hongren Zheng (Zenithal)
2021-03-24 23:50 ` Shuah Khan [this message]
2021-03-24 23:50 ` [PATCH v5 1/2] usbip: tools: add options and examples in man page related to device mode Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=719c16e1-c220-3ff4-9389-bf2ae098e5dc@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=borneo.antonio@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=i@zenithal.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mfm@muteddisk.com \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).