From: Hannes Reinecke <hare@suse.de>
To: Bart Van Assche <bvanassche@acm.org>,
dgilbert@interlog.com, Marc Gonzalez <marc.w.gonzalez@free.fr>,
James Bottomley <jejb@linux.ibm.com>,
Martin Petersen <martin.petersen@oracle.com>
Cc: SCSI <linux-scsi@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v1] scsi: Don't select SCSI_PROC_FS by default
Date: Fri, 5 Jul 2019 09:18:04 +0200 [thread overview]
Message-ID: <719dd2ea-b5e5-c694-36ef-9513ed0c2d06@suse.de> (raw)
In-Reply-To: <da579578-349e-1320-0867-14fde659733e@acm.org>
On 6/18/19 5:28 AM, Bart Van Assche wrote:
> On 6/17/19 5:35 PM, Douglas Gilbert wrote:
>> For sg3_utils:
>>
>> $ find . -name '*.c' -exec grep "/proc/scsi" {} \; -print
>> static const char * proc_allow_dio = "/proc/scsi/sg/allow_dio";
>> ./src/sg_read.c
>> static const char * proc_allow_dio = "/proc/scsi/sg/allow_dio";
>> ./src/sgp_dd.c
>> static const char * proc_allow_dio = "/proc/scsi/sg/allow_dio";
>> ./src/sgm_dd.c
>> static const char * proc_allow_dio = "/proc/scsi/sg/allow_dio";
>> ./src/sg_dd.c
>> "'echo 1 > /proc/scsi/sg/allow_dio'\n", q_len,
>> dirio_count);
>> ./testing/sg_tst_bidi.c
>> static const char * proc_allow_dio = "/proc/scsi/sg/allow_dio";
>> ./examples/sgq_dd.c
>>
>> That is 6 (not 38) by my count.
>
> Hi Doug,
>
> This is the command I ran:
>
> $ git grep /proc/scsi | wc -l
> 38
>
> I think your query excludes scripts/rescan-scsi-bus.sh.
>
You can ignore rescan-scsi-bus.sh.
It's keeping /proc access as a fallback option only (as it's meant to be
kernel-independent); it will be using /sys per default and will happily
work without /proc/scsi.
Cheers,
Hannes
--
Dr. Hannes Reinecke Teamlead Storage & Networking
hare@suse.de +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
prev parent reply other threads:[~2019-07-05 7:18 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 13:59 [PATCH v1] scsi: Don't select SCSI_PROC_FS by default Marc Gonzalez
2019-06-17 21:11 ` Bart Van Assche
2019-06-18 0:35 ` Douglas Gilbert
2019-06-18 1:08 ` Finn Thain
2019-06-18 7:29 ` Marc Gonzalez
2019-06-18 15:31 ` Douglas Gilbert
2019-06-19 9:42 ` Marc Gonzalez
2019-06-19 14:34 ` Douglas Gilbert
2019-06-20 9:01 ` Marc Gonzalez
2019-06-20 21:47 ` Martin K. Petersen
2019-06-20 23:43 ` Finn Thain
2019-06-21 10:41 ` Marc Gonzalez
2019-06-21 23:50 ` Finn Thain
2019-06-18 3:28 ` Bart Van Assche
2019-06-18 17:43 ` Elliott, Robert (Servers)
2019-07-05 7:22 ` Hannes Reinecke
2019-07-05 17:53 ` Douglas Gilbert
2019-07-08 6:01 ` Hannes Reinecke
2019-07-08 13:02 ` Douglas Gilbert
2019-07-05 7:18 ` Hannes Reinecke [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=719dd2ea-b5e5-c694-36ef-9513ed0c2d06@suse.de \
--to=hare@suse.de \
--cc=bvanassche@acm.org \
--cc=dgilbert@interlog.com \
--cc=hch@lst.de \
--cc=jejb@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=marc.w.gonzalez@free.fr \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).