From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752425AbeBZJsL (ORCPT ); Mon, 26 Feb 2018 04:48:11 -0500 Received: from wp227.webpack.hosteurope.de ([80.237.132.234]:47314 "EHLO wp227.webpack.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751877AbeBZJsE (ORCPT ); Mon, 26 Feb 2018 04:48:04 -0500 Subject: Re: regression v4.16 on Nokia N900:/dev/input/event6 aka AV Jack support disappeared To: Pavel Machek , pali.rohar@gmail.com, sre@kernel.org, kernel list , linux-arm-kernel , linux-omap@vger.kernel.org, tony@atomide.com, khilman@kernel.org, aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com, patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com, clayton@craftyguy.net, martijn@brixit.nl, sakari.ailus@linux.intel.com, =?UTF-8?Q?Filip_Matijevi=c4=87?= , afd@ti.com Cc: broonie@kernel.org, peter.ujfalusi@ti.com, alsa-devel@alsa-project.org References: <20180224214617.GA22619@amd> From: Thorsten Leemhuis Message-ID: <71aa88ec-d4df-b49c-7d73-27197f468491@leemhuis.info> Date: Mon, 26 Feb 2018 10:47:45 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180224214617.GA22619@amd> Content-Type: text/plain; charset=utf-8 Content-Language: en-MW Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de;regressions@leemhuis.info;1519638484;5267e43a; X-HE-SMSGID: 1eqFNq-00070Q-NQ Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org JFYI: This issues is tracked in the regression reports for Linux 4.16 (http://bit.ly/lnxregrep416 ) with this id: Linux-Regression-ID: lr#4b650f Please include this line in the comment section of patches that are supposed to fix the issue. Please also mention the string once in other mailinglist threads or different bug tracking entries if you or someone else start to discuss the issue there. By including that string you make it a whole lot easier to track where an issue gets discussed and how far patches to fix it have made it. For more details on this please see here: http://bit.ly/lnxregtrackid Thx for your help. Ciao, Thorsten On 24.02.2018 22:46, Pavel Machek wrote: > Hi! > > In v4.16, AV jack support disappeared. > > This one is suspect: > > commit 7be4b5dc7ffa9499ac6ef33a5ffa9ff43f9b7057 > Author: Andrew F. Davis > Date: Wed Nov 29 11:13:59 2017 -0600 > > ARM: dts: omap3-n900: Fix the audio CODEC's reset pin > > The correct DT property for specifying a GPIO used for reset > is "reset-gpios", fix this here. > > Fixes: 14e3e295b2b9 ("ARM: dts: omap3-n900: Add TLV320AIC3X > support") > > Signed-off-by: Andrew F. Davis > Signed-off-by: Tony Lindgren > > How was it tested? It reverts polarity of reset pin, but > sound/soc/codecs/tlv320aic3x.c treats those as aliases: > > ret = of_get_named_gpio(np, "reset-gpios", 0); > if (ret >= 0) { > aic3x->gpio_reset = ret; > } else { > ret = of_get_named_gpio(np, "gpio-reset", 0); > if (ret > 0) { > dev_warn(&i2c->dev, "Using deprecated property \"gpio-r\eset\", please update your DT"); > aic3x->gpio_reset = ret; > > > Pavel >