From: Bixuan Cui <cuibixuan@huawei.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: <davem@davemloft.net>, <kuba@kernel.org>,
<linux-next@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<netdev@vger.kernel.org>, <jdmason@kudzu.us>,
<christophe.jaillet@wanadoo.fr>, <john.wanghui@huawei.com>
Subject: Re: [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX
Date: Mon, 20 Jul 2020 09:57:01 +0800 [thread overview]
Message-ID: <71b4229e-f442-9e8c-d8ab-c5610db881b9@huawei.com> (raw)
In-Reply-To: <20200719100522.220a6f5a@hermes.lan>
On 2020/7/20 1:05, Stephen Hemminger wrote:
> On Thu, 16 Jul 2020 17:32:47 +0000
> Bixuan Cui <cuibixuan@huawei.com> wrote:
>
>> Fix the warning: [-Werror=-Wframe-larger-than=]
>>
>> drivers/net/ethernet/neterion/vxge/vxge-main.c:
>> In function'VXGE_COMPLETE_VPATH_TX.isra.37':
>> drivers/net/ethernet/neterion/vxge/vxge-main.c:119:1:
>> warning: the frame size of 1056 bytes is larger than 1024 bytes
>>
>> Signed-off-by: Bixuan Cui <cuibixuan@huawei.com>
> Dropping the NR_SKB_COMPLETED to 16 won't have much impact
> on performance, and shrink the size.
>
> Doing 16 skb's at a time instead of 128 probably costs
> less than one allocation. Especially since it is unlikely
> that the device completed that many transmits at once.
>
>
I will send the v2 patch based on your suggestions.
thanks
next prev parent reply other threads:[~2020-07-20 1:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-16 17:32 [PATCH] net: neterion: vxge: reduce stack usage in VXGE_COMPLETE_VPATH_TX Bixuan Cui
2020-07-16 9:46 ` Joe Perches
2020-07-16 9:59 ` Bixuan Cui
2020-07-16 11:20 ` kernel test robot
2020-07-16 14:11 ` kernel test robot
2020-07-19 17:05 ` Stephen Hemminger
2020-07-20 1:57 ` Bixuan Cui [this message]
2020-07-20 1:58 ` [PATCH v2] " Bixuan Cui
2020-07-21 1:38 ` David Miller
2020-07-21 12:34 ` Bixuan Cui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=71b4229e-f442-9e8c-d8ab-c5610db881b9@huawei.com \
--to=cuibixuan@huawei.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=davem@davemloft.net \
--cc=jdmason@kudzu.us \
--cc=john.wanghui@huawei.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).