From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755224AbeDTOad (ORCPT ); Fri, 20 Apr 2018 10:30:33 -0400 Received: from esa4.dell-outbound.iphmx.com ([68.232.149.214]:44300 "EHLO esa4.dell-outbound.iphmx.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754894AbeDTOab (ORCPT ); Fri, 20 Apr 2018 10:30:31 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A2HFAADY+Nlah2Oa6ERcHAEBAQQBAQoBA?= =?us-ascii?q?YQVgQgoCoNgiAKMdoF0gQ+Ga4wNgXgLhGkCGoIsITQYAQIBAQEBAQECAQECEAE?= =?us-ascii?q?BAQoLCQgoL4I1IoJNAQEBBCMRRQwEAgEIEQQBAQECAiMDAgICHyUBCAgCBAENB?= =?us-ascii?q?QiEbQMVpk+CHIcGDYErgimBCYZ9ghOEGoJPgjuCaYJUApdFLAiLQoJ1jFaJc4Y?= =?us-ascii?q?2gSUcggtwgxOCLo4gbwGOToEYAQE?= X-IPAS-Result: =?us-ascii?q?A2HFAADY+Nlah2Oa6ERcHAEBAQQBAQoBAYQVgQgoCoNgiAK?= =?us-ascii?q?MdoF0gQ+Ga4wNgXgLhGkCGoIsITQYAQIBAQEBAQECAQECEAEBAQoLCQgoL4I1I?= =?us-ascii?q?oJNAQEBBCMRRQwEAgEIEQQBAQECAiMDAgICHyUBCAgCBAENBQiEbQMVpk+CHIc?= =?us-ascii?q?GDYErgimBCYZ9ghOEGoJPgjuCaYJUApdFLAiLQoJ1jFaJc4Y2gSUcggtwgxOCL?= =?us-ascii?q?o4gbwGOToEYAQE?= From: X-LoopCount0: from 10.166.132.187 X-IronPort-AV: E=Sophos;i="5.49,301,1520917200"; d="scan'208";a="1136650540" X-DLP: DLP_GlobalPCIDSS To: , CC: , , , , Subject: RE: [PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events Thread-Topic: [PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and fn-lock events Thread-Index: AQHT2Hj+hRNRbiJ0fECuCEQaHuZrtaQJlVgAgAAh4AA= Date: Fri, 20 Apr 2018 14:30:27 +0000 Message-ID: <71dccbbb971f44ff8ed329c29e611f57@ausx13mpc120.AMER.DELL.COM> References: <20180420072648.5426-1-kai.heng.feng@canonical.com> <20180420072854.bprouoj5poim5rxv@pali> In-Reply-To: <20180420072854.bprouoj5poim5rxv@pali> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.143.18.86] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w3KEUcNN028564 > -----Original Message----- > From: Pali Rohár [mailto:pali.rohar@gmail.com] > Sent: Friday, April 20, 2018 2:29 AM > To: Kai-Heng Feng > Cc: mjg59@srcf.ucam.org; dvhart@infradead.org; andy@infradead.org; > Limonciello, Mario; platform-driver-x86@vger.kernel.org; linux- > kernel@vger.kernel.org > Subject: Re: [PATCH v2] platform/x86: dell-wmi: Ignore new rfkill and fn-lock > events > > On Friday 20 April 2018 15:26:48 Kai-Heng Feng wrote: > > There are two new events generated by dell-wmi, rfkill and fn-lock, from > > Dell Systems. > > > > When Fn-lock hotkey gets pressed to switch to function mode: > > [85951.591542] dell_wmi: Unknown key with type 0x0010 and code 0xe035 > > pressed > > [85951.591546] dell_wmi: Unknown key with type 0x0010 and code 0x0000 > > pressed > > > > When Fn-lock hotkey gets pressed to switch to multimedia mode: > > [85956.667686] dell_wmi: Unknown key with type 0x0010 and code 0xe035 > > pressed > > [85956.667690] dell_wmi: Unknown key with type 0x0010 and code 0x0001 > > pressed > > > > When radio hotkey gets pressed: > > [85974.430220] dell_wmi: Unknown key with type 0x0010 and code 0xe008 > > pressed > > > > These events are for notification purpose, so we can ignore them. > > > > This patch is tested on XPS 9370. > > > > Signed-off-by: Kai-Heng Feng > > Reviewed-by: Pali Rohár Reviewed-by: Mario Limonciello > > > --- > > v2: Reorder alphabetically. > > More detailed changelog. > > > > drivers/platform/x86/dell-wmi.c | 14 ++++++++++++++ > > 1 file changed, 14 insertions(+) > > > > diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/dell-wmi.c > > index 8d102195a392..ba8e6725d7ac 100644 > > --- a/drivers/platform/x86/dell-wmi.c > > +++ b/drivers/platform/x86/dell-wmi.c > > @@ -261,6 +261,12 @@ static const u16 bios_to_linux_keycode[256] = { > > * override them. > > */ > > static const struct key_entry dell_wmi_keymap_type_0010[] = { > > + /* Fn-lock switched to function keys */ > > + { KE_IGNORE, 0x0, { KEY_RESERVED } }, > > + > > + /* Fn-lock switched to multimedia keys */ > > + { KE_IGNORE, 0x1, { KEY_RESERVED } }, > > + > > /* Mic mute */ > > { KE_KEY, 0x150, { KEY_MICMUTE } }, > > > > @@ -296,6 +302,14 @@ static const struct key_entry > dell_wmi_keymap_type_0010[] = { > > { KE_KEY, 0x851, { KEY_PROG2 } }, > > { KE_KEY, 0x852, { KEY_PROG3 } }, > > > > + /* > > + * Radio disable (notify only -- there is no model for which the > > + * WMI event is supposed to trigger an action). > > + */ > > + { KE_IGNORE, 0xe008, { KEY_RFKILL } }, > > + > > + /* Fn-lock */ > > + { KE_IGNORE, 0xe035, { KEY_RESERVED } }, > > }; > > > > /* > > -- > Pali Rohár > pali.rohar@gmail.com