From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751100AbdKKNTl (ORCPT ); Sat, 11 Nov 2017 08:19:41 -0500 Received: from mout.web.de ([212.227.15.4]:64485 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750728AbdKKNTk (ORCPT ); Sat, 11 Nov 2017 08:19:40 -0500 Subject: [PATCH 3/3] ALSA: ml403-ac97cr: Adjust four checks for null pointers From: SF Markus Elfring To: alsa-devel@alsa-project.org, Arvind Yadav , Bhumika Goyal , Jaroslav Kysela , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org References: <4c38a970-2407-3559-060d-501b8259b3fc@users.sourceforge.net> Message-ID: <71f0710a-c884-4b3e-7e8e-6033a9142e3e@users.sourceforge.net> Date: Sat, 11 Nov 2017 14:19:28 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <4c38a970-2407-3559-060d-501b8259b3fc@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:/wskmSNelxjcpSLhkg4QEXd5nqwa3TUygxrVmHGnhHXpwIMiV3J LmvjDNoGSlvo2+/puZReNX1QNOC60r07JLchJovEq/FbZeB4aPUUD0bFqBPfhk7VfD9a/Bn 0aO3TfSFiGshvhkkoM0MN2w2u1AnX4KKaAAP5IT71rnm8UXov/aosojlSC9k13/F7HfCZ5K AsKwy4QArxmK4J9FjL3Wg== X-UI-Out-Filterresults: notjunk:1;V01:K0:DVDkhRW3iSQ=:X0sbxXIstQOsZuxpG4pzbo txkxbszJwC3+hm1RWEo33cFHd56Pf2PXO/1kexs9ZZQXaBdu2Pog5hoJPtGT7eJbpNaJ7Ig9J W3P8zLYmdrhK3f2aIWpYnRwa8/XO3/PZ558hcuTAahNHgGgAkWC6h9xnE66h5y24VgPhWraQc 3+NWbrSElZTOIBFUI7vEXJ8uSuEbnO/AXhk8qwlUS0uQZCol+R4zCfJk2TOmfk3czklA3bdg5 5qXwkJdxt2zvuVwZ1JVcKbVeuuhEfxQe4gb+Qq6o5Ipu+PhSMNBBLp1pAwZY7Sh2BDrN1U7kG WVRb6Nniexy/jEYtdbWEq+GtTJjz0WO3AZYuZrbZGbjiIVXYd5N+wM8z29mSya6RIrIZlyOTR WmNRcE0jD4nGp75ZQojjjZ9oEJ7B0tFN7D3D+sh0XCMvhNVi0CDzko7pZIif8XrHK59NoPTJq Lx1oUqC6Ise5QJab1HsH8KHgrYfeZEqXjw/Vaz9Ug3a3NjAHTA2uPNvhYsKiKD1rPcBZ/qM/L gP/omrLFXZLGGfAWZi3cE51GHIUbQuoCZZIpdV40ggb5/8pZgTOB7xX1hCrtItWPjikerUXLg PmdyyDaRSp78f02I8nL2y9pQPqkF3fHy2GCl81V18EJFFXq2uZBKaagr3jwds2uQgZxKLDx5g S6zq9MhKq8OjjkEEg/91i1KtIPOAbNiGsShoQJzp+Ra2Vtjob55ZmBj7uzQvlYsW1GpbtNXNB 2oTVGFOQZ7qfEqtGi4jsVpnbhcy0iDRkMNgGdmcwZnSOzdPZ0VwDeahJ0QSgR8CHRY95BboO8 G9fxwOYsum3Fg2k5mpVxVbulFIzyXlNiSjCacPa/VAtHvpadWc= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 11 Nov 2017 14:04:04 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written … Thus fix the affected source code places. Signed-off-by: Markus Elfring --- sound/drivers/ml403-ac97cr.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/sound/drivers/ml403-ac97cr.c b/sound/drivers/ml403-ac97cr.c index 4cf964ea2802..d897175a63b2 100644 --- a/sound/drivers/ml403-ac97cr.c +++ b/sound/drivers/ml403-ac97cr.c @@ -533,7 +533,7 @@ snd_ml403_ac97cr_pcm_pointer(struct snd_pcm_substream *substream) if (substream == ml403_ac97cr->capture_substream) ind2_rec = &ml403_ac97cr->capture_ind2_rec; - if (ind2_rec != NULL) + if (ind2_rec) return snd_pcm_indirect2_pointer(substream, ind2_rec); return (snd_pcm_uframes_t) 0; } @@ -788,7 +788,7 @@ static irqreturn_t snd_ml403_ac97cr_irq(int irq, void *dev_id) int cmp_irq; ml403_ac97cr = (struct snd_ml403_ac97cr *)dev_id; - if (ml403_ac97cr == NULL) + if (!ml403_ac97cr) return IRQ_NONE; pfdev = ml403_ac97cr->pfdev; @@ -1120,7 +1120,7 @@ snd_ml403_ac97cr_create(struct snd_card *card, struct platform_device *pfdev, *rml403_ac97cr = NULL; ml403_ac97cr = kzalloc(sizeof(*ml403_ac97cr), GFP_KERNEL); - if (ml403_ac97cr == NULL) + if (!ml403_ac97cr) return -ENOMEM; spin_lock_init(&ml403_ac97cr->reg_lock); mutex_init(&ml403_ac97cr->cdc_mutex); @@ -1139,7 +1139,7 @@ snd_ml403_ac97cr_create(struct snd_card *card, struct platform_device *pfdev, ml403_ac97cr->port = ioremap_nocache(resource->start, (resource->end) - (resource->start) + 1); - if (ml403_ac97cr->port == NULL) { + if (!ml403_ac97cr->port) { snd_printk(KERN_ERR SND_ML403_AC97CR_DRIVER ": " "unable to remap memory region (%pR)\n", resource); -- 2.15.0