From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756591AbbJAQHF (ORCPT ); Thu, 1 Oct 2015 12:07:05 -0400 Received: from nat13.teradata.com ([153.65.16.13]:49623 "EHLO rpc7292.td.teradata.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753658AbbJAQHA convert rfc822-to-8bit (ORCPT ); Thu, 1 Oct 2015 12:07:00 -0400 From: "Meyer, Mike" To: Peter Zijlstra CC: "linux-kernel@vger.kernel.org" , "mingo@redhat.com" Subject: RE: [PATCH] sched: fix task and run queue run_delay inconsistencies Thread-Topic: [PATCH] sched: fix task and run queue run_delay inconsistencies Thread-Index: AQHQ/C2ZtFnjLKWC5EyijCC2kPCcR55WzP+w Date: Thu, 1 Oct 2015 16:06:57 +0000 Message-ID: <72105DE171429F468B83CE64C279BFFA17615B6B@SUSHDC8002.TD.TERADATA.COM> References: <72105DE171429F468B83CE64C279BFFA1760DC12@SUSHDC8002.TD.TERADATA.COM> <20150930154413.GO3604@twins.programming.kicks-ass.net> <72105DE171429F468B83CE64C279BFFA17615A68@SUSHDC8002.TD.TERADATA.COM> <20151001063732.GM2881@worktop.programming.kicks-ass.net> <20151001094313.GA3281@worktop.programming.kicks-ass.net> In-Reply-To: <20151001094313.GA3281@worktop.programming.kicks-ass.net> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [153.64.133.129] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-TM-AS-MML: disable X-TM-AS-Product-Ver: IMSVA-8.5.0.1618-8.0.0.1202-21852.000 X-TM-AS-Result: No--12.585-7.0-31-10 X-imss-scan-details: No--12.585-7.0-31-10 X-TM-AS-User-Approved-Sender: No X-TMASE-Version: IMSVA-8.5.0.1618-8.0.1202-21852.000 X-TMASE-Result: 10--12.584800-5.000000 X-TMASE-MatchedRID: nVQUmLJJeyY4HKI/yaqRm3ZwubmkurW/2MmowBCx0sGKlJ71TX9+g3i2 YXWTaJQz7tt9TxPHVvC1sOUX9xiMLeM2fQ6STlVfQ4r9bxJdsVuAZr6hinmLqvgnJH5vm2+gKhP nM1YfWBUuuEPRTB9msMFtzPa8Vys5iF7t9kYaiv51e7Xbb6Im2p6KYa03LCO2myiLZetSf8l/KM EkOe61SFBIVsvVu9ABIAcCikR3vq9aKxHc6lt48GnuB40AwV1ewpgSWNpBEcESVU1bBjnK8byl0 /7u/IsS Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > On Thu, Oct 01, 2015 at 08:37:32AM +0200, Peter Zijlstra wrote: > > > > On Wed, Sep 30, 2015 at 08:28:41PM +0000, Meyer, Mike wrote: > > It looks like the sites in the wakeup path do indeed not get any additional > conditionals. > > > > My only comment is I am not sure about the naming of the flag > > > ENQUEUE_TEMP which implies (to me) the enqueue is temporary which > > > clearly it isn't. Maybe something like > DEQUEUE_MOVE/ENQUEUE_MOVE > > > would be a bit more descriptive of the use case. > > > > Yes, I ran out of creative juices, let me attempt a better name once > > I've woken up a bit. > > How about DEQUEUE_SAVE, ENQUEUE_RESTORE ? Ideally I'd wrap the whole > pattern into a helper but C isn't really supportive of pre+post patterns like > this. Sounds fine to me! Thanks again.