From: David R <david@unsolicited.net>
To: "Limonciello, Mario" <mario.limonciello@amd.com>,
Borislav Petkov <bp@alien8.de>,
Gabriel David <ultracoolguy@disroot.org>,
eric.devolder@oracle.com
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Kishon Vijay Abraham I <kvijayab@amd.com>
Subject: Re: Panic starting 6.2.x and later 6.1.x kernels
Date: Wed, 29 Mar 2023 20:20:27 +0100 [thread overview]
Message-ID: <7218e006-9f4f-a9bc-cdd2-a595a8e64ede@unsolicited.net> (raw)
In-Reply-To: <e4a6e5bb-d014-aa55-5eee-65f1c5f59875@amd.com>
On 29/03/2023 20:17, Limonciello, Mario wrote:
> On 3/29/2023 14:14, David R wrote:
>> I note that 6.2.8 still has:
>>
>> static bool __init acpi_is_processor_usable(u32 lapic_flags)
>> {
>> if (lapic_flags & ACPI_MADT_ENABLED)
>> return true;
>>
>> if (acpi_support_online_capable && (lapic_flags &
>> ACPI_MADT_ONLINE_CAPABLE))
>> return true;
>>
>> return false;
>> }
>>
>> The flag getting set to false won't help unless the patch I tried
>> previously is applied ?
>>
>> diff
>> <https://lore.kernel.org/all/20230327191026.3454-2-eric.devolder@oracle.com/#iZ31arch:x86:kernel:acpi:boot.c>
>> --git a/arch/x86/kernel/acpi/boot.c b/arch/x86/kernel/acpi/boot.c
>> index 1c38174b5f01..7b5b8ed018b0 100644 ---
>> a/arch/x86/kernel/acpi/boot.c +++ b/arch/x86/kernel/acpi/boot.c @@
>> -193,7 +193,13 @@ static bool __init acpi_is_processor_usable(u32
>> lapic_flags) if (lapic_flags & ACPI_MADT_ENABLED)
>> return true;
>> - if (acpi_support_online_capable && (lapic_flags &
>> ACPI_MADT_ONLINE_CAPABLE)) + /* + * Prior to MADT.revision 5, the
>> presence of the Local x2/APIC + * structure _implicitly_ noted a
>> possible hotpluggable cpu. + * Starting with MADT.revision 5, the
>> Online Capable bit + * _explicitly_ indicates a hotpluggable cpu. +
>> */ + if (!acpi_support_online_capable || (lapic_flags &
>> ACPI_MADT_ONLINE_CAPABLE)) return true;
>> return false;
>> --
>>
>
> You mean specifically this change:
> https://lore.kernel.org/all/20230327191026.3454-2-eric.devolder@oracle.com/
>
>
> Yes; I suppose that still makes sense.
>
Yes, that's the one.
But the fact that that one worked own its own implies that my system
never had the flag set in the first place?
David
next prev parent reply other threads:[~2023-03-29 19:20 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 6:43 Panic starting 6.2.x and later 6.1.x kernels David R
2023-03-27 7:49 ` Borislav Petkov
2023-03-27 8:13 ` David R
2023-03-27 13:49 ` Thomas Gleixner
2023-03-27 13:51 ` David R
2023-03-27 14:23 ` David R
2023-03-27 15:53 ` David R
2023-03-27 16:21 ` David R
2023-03-28 11:02 ` David R
2023-03-28 14:20 ` Borislav Petkov
2023-03-28 15:06 ` David R
2023-03-28 17:10 ` Borislav Petkov
2023-03-28 17:32 ` David R
2023-03-28 17:33 ` Borislav Petkov
[not found] ` <9ed16be4-051d-c20f-0410-b8a973c4c09e@disroot.org>
2023-03-29 10:39 ` Borislav Petkov
2023-03-29 16:14 ` Borislav Petkov
2023-03-29 16:20 ` David R
2023-03-29 17:51 ` Limonciello, Mario
2023-03-29 19:03 ` David R
2023-03-29 19:07 ` Limonciello, Mario
[not found] ` <a0ca1e4e-891c-273d-e2d8-eeb9fc4d0c77@unsolicited.net>
2023-03-29 19:17 ` Limonciello, Mario
2023-03-29 19:20 ` David R [this message]
2023-03-29 19:24 ` Limonciello, Mario
2023-03-29 19:31 ` David R
2023-03-30 9:33 ` [tip: x86/urgent] x86/ACPI/boot: Use FADT version to check support for online capable tip-bot2 for Mario Limonciello
2023-03-30 20:50 Panic starting 6.2.x and later 6.1.x kernels gabipr2023
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7218e006-9f4f-a9bc-cdd2-a595a8e64ede@unsolicited.net \
--to=david@unsolicited.net \
--cc=bp@alien8.de \
--cc=eric.devolder@oracle.com \
--cc=kvijayab@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=tglx@linutronix.de \
--cc=ultracoolguy@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).