From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Yan Yankovskyi <yyankovskyi@gmail.com>, Jan Beulich <jbeulich@suse.com>
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] xen: Use evtchn_type_t as a type for event channels
Date: Fri, 6 Mar 2020 11:08:13 -0500 [thread overview]
Message-ID: <721d9950-eec6-9da4-1bfb-e615629fe66e@oracle.com> (raw)
In-Reply-To: <20200305095739.GA26471@kbp1-lhp-F74019>
On 3/5/20 4:57 AM, Yan Yankovskyi wrote:
> Make event channel functions pass event channel port using
> evtchn_port_t type. It eliminates signed <-> unsigned conversion.
> Also rename 'evtchn' variables to 'port' in case if 'port' is not
> ambiguous.
> @@ -171,10 +171,10 @@ static int xen_irq_info_common_setup(struct irq_info *info,
>
> info->type = type;
> info->irq = irq;
> - info->evtchn = evtchn;
> + info->evtchn = port;
Hmm... I am not sure these kinds of changes make it much better.
-boris
prev parent reply other threads:[~2020-03-06 16:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-05 9:57 [PATCH] xen: Use evtchn_type_t as a type for event channels Yan Yankovskyi
2020-03-06 16:08 ` Boris Ostrovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=721d9950-eec6-9da4-1bfb-e615629fe66e@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=yyankovskyi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).