From: Yasuaki Ishimatsu <yasu.isimatu@gmail.com>
To: akpm@linux-foundation.org
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, x86@kernel.org,
tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
dave.hansen@linux.intel.com, vbabka@suse.cz,
mgorman@techsingularity.net, qiuxishi@huawei.com
Subject: Re: [Resend PATCH 2/2] mm/memory_hotplug: set magic number to page->freelsit instead of page->lru.next
Date: Fri, 3 Feb 2017 15:37:23 -0500 [thread overview]
Message-ID: <722b1cc4-93ac-dd8b-2be2-7a7e313b3b0b@gmail.com> (raw)
In-Reply-To: <2c29bd9f-5b67-02d0-18a3-8828e78bbb6f@gmail.com>
Hi Andrew,
Please apply the following patch into your tree because patch
("mm/memory_hotplug: set magic number to page->freelsit instead of page->lru.next")
is not applied correctly.
---
From: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
Date: Fri, 3 Feb 2017 15:18:03 -0500
Subject: [PATCH] Remove unnecessary code from get_page_bootmem()
The following patch is not applied correctly.
http://lkml.kernel.org/r/2c29bd9f-5b67-02d0-18a3-8828e78bbb6f@gmail.com
So the following unnecessary code still remains.
get_page_bootmem()
{
...
page->lru.next = (struct list_head *)type;
...
The patch removeｓ this code from get_page_bootmem()
Signed-off-by: Yasuaki Ishimatsu <isimatu.yasuaki@jp.fujitsu.com>
---
mm/memory_hotplug.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
index 19b460a..50b586c 100644
--- a/mm/memory_hotplug.c
+++ b/mm/memory_hotplug.c
@@ -179,7 +179,6 @@ static void release_memory_resource(struct resource *res)
void get_page_bootmem(unsigned long info, struct page *page,
unsigned long type)
{
- page->lru.next = (struct list_head *)type;
page->freelist = (void *)type;
SetPagePrivate(page);
set_page_private(page, info);
--
1.8.3.1
next prev parent reply other threads:[~2017-02-03 20:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 15:47 [Resend Patch 0/2] mm/memory_hotplug: fix hot remove bug Yasuaki Ishimatsu
2016-12-21 15:49 ` [Resend PATCH 1/2] mm/sparse: use page_private() to get page->private value Yasuaki Ishimatsu
2016-12-21 15:49 ` [Resend PATCH 2/2] mm/memory_hotplug: set magic number to page->freelsit instead of page->lru.next Yasuaki Ishimatsu
2017-02-03 20:37 ` Yasuaki Ishimatsu [this message]
2017-02-03 21:14 ` Yasuaki Ishimatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=722b1cc4-93ac-dd8b-2be2-7a7e313b3b0b@gmail.com \
--to=yasu.isimatu@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mingo@redhat.com \
--cc=qiuxishi@huawei.com \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).