From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72570C4363D for ; Tue, 22 Sep 2020 18:01:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2118D23787 for ; Tue, 22 Sep 2020 18:01:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="isvyS9vS" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726643AbgIVSBx (ORCPT ); Tue, 22 Sep 2020 14:01:53 -0400 Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]:29078 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726526AbgIVSBx (ORCPT ); Tue, 22 Sep 2020 14:01:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1600797711; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=C2aaSAULK36kdpoACQDdwALZmwQc4G3xRYKl1sR2GSU=; b=isvyS9vSmUmN9kF23zvsaL4DtLBJx3pDCpEAIPQv8pOt3J4y052MeGgN2HnE7j6j5SzhCH bHT2SW27y3xnrCE2W2szPeIV9/FehzrGgdq5Z1ii59W6L9GWXbzm3fCEvSOlUjiefLOFj+ z8qxb6DqqCVcBOtIsqWT2hFImJrMM20= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-188-gn5GxlKmOz25EkMMdzRQrA-1; Tue, 22 Sep 2020 14:01:48 -0400 X-MC-Unique: gn5GxlKmOz25EkMMdzRQrA-1 Received: by mail-qv1-f69.google.com with SMTP id l1so12093744qvr.0 for ; Tue, 22 Sep 2020 11:01:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:organization:user-agent:mime-version :content-transfer-encoding; bh=C2aaSAULK36kdpoACQDdwALZmwQc4G3xRYKl1sR2GSU=; b=jkmIEETlmys/YPGUf1nyrdT1ny9R7N84qAExrqvW1bO4+5zgNbgTAiZ6eQAnp9yGBK VUS1QY3n2PbDGdPQx3IiV32Wzhk0Kltcqds3807D7ta0cpiwaGNgDAW3KhQhG+oxxHKL jBYA+y3WX13kuU/qCFH5HHDyQA+o89gHCuGaS1IMya+CNagbQPh4+13n2iT4OcN9Rg8z vz8LPgXNqYvev40FVvjfpGXoeQ2OX0wTRFew+qk4tFWEHwfWA/GDENWfUfjaWDxgm/Ad UjBGprJP4pUfZfASv0cakAUjV3+4em9NuFbTDABtPqi35vSJ+gYzVUhTjyV2Q4LJKcAy 9uhw== X-Gm-Message-State: AOAM530K2hDRiwaim5H3617Kgqmuie3uCGNTmR5osSAJkWSx02lyU6Fr yXzKa9sM5L2TkAYK/UHFWR7CvArvvf8WZ1ziQ2uK59Rvr89o7bZHhCRQD4UMvcRZnHGehJY9Bfk JxRm/fXyeWjRG5BVIwQ4/64Dk X-Received: by 2002:a37:3c8:: with SMTP id 191mr5909462qkd.393.1600797708430; Tue, 22 Sep 2020 11:01:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy9TQNX37EETLlze/qf7+p/fibX9UNEpK4JViHSjRbPhqkGDdiiKwZ+YCb6FbsuWgwyay63NQ== X-Received: by 2002:a37:3c8:: with SMTP id 191mr5909431qkd.393.1600797708144; Tue, 22 Sep 2020 11:01:48 -0700 (PDT) Received: from Ruby.lyude.net (pool-108-49-102-102.bstnma.fios.verizon.net. [108.49.102.102]) by smtp.gmail.com with ESMTPSA id p68sm12340991qka.78.2020.09.22.11.01.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Sep 2020 11:01:47 -0700 (PDT) Message-ID: <7231e2199a19aa6c8ecbecf5e80725e2a1aded73.camel@redhat.com> Subject: Re: [PATCH V4] drm/dp_mst: Retrieve extended DPCD caps for topology manager From: Lyude Paul To: Koba Ko , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Cc: anthony.wong@canonical.com Date: Tue, 22 Sep 2020 14:01:46 -0400 In-Reply-To: <20200922065313.4794-1-koba.ko@canonical.com> References: <20200922065313.4794-1-koba.ko@canonical.com> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org One last change I realized we should do is print the name of the AUX adapter in question. I don't mind just adding that myself before I push it though so you don't need to send a respin. Going to go push this to drm-misc-next, thanks! On Tue, 2020-09-22 at 14:53 +0800, Koba Ko wrote: > As per DP-1.3, First check DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT. > If DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is 1,read the DP_DP13_DPCD_REV to > get the faster capability. > If DP_EXTENDED_RECEIVER_CAP_FIELD_PRESENT is 0,read DP_DPCD_REV. > > Signed-off-by: Koba Ko > Reviewed-by: Lyude Paul > --- > drivers/gpu/drm/drm_dp_mst_topology.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/drm_dp_mst_topology.c > b/drivers/gpu/drm/drm_dp_mst_topology.c > index e87542533640..63f8809b9aa4 100644 > --- a/drivers/gpu/drm/drm_dp_mst_topology.c > +++ b/drivers/gpu/drm/drm_dp_mst_topology.c > @@ -3686,9 +3686,9 @@ int drm_dp_mst_topology_mgr_set_mst(struct > drm_dp_mst_topology_mgr *mgr, bool ms > WARN_ON(mgr->mst_primary); > > /* get dpcd info */ > - ret = drm_dp_dpcd_read(mgr->aux, DP_DPCD_REV, mgr->dpcd, > DP_RECEIVER_CAP_SIZE); > - if (ret != DP_RECEIVER_CAP_SIZE) { > - DRM_DEBUG_KMS("failed to read DPCD\n"); > + ret = drm_dp_read_dpcd_caps(mgr->aux, mgr->dpcd); > + if (ret < 0) { > + drm_dbg_kms(mgr->dev, "failed to read DPCD, ret %d\n", > ret); > goto out_unlock; > } > -- Cheers, Lyude Paul (she/her) Software Engineer at Red Hat