* [PATCH] firmware: xilinx: Export zynqmp_pm_fpga_{get_status,load}
@ 2020-05-02 2:59 Nathan Chancellor
2020-05-05 7:14 ` Michal Simek
0 siblings, 1 reply; 2+ messages in thread
From: Nathan Chancellor @ 2020-05-02 2:59 UTC (permalink / raw)
To: Michal Simek, Rajan Vaja, Greg Kroah-Hartman
Cc: linux-arm-kernel, linux-kernel, Nathan Chancellor
When building arm64 allmodconfig:
ERROR: modpost: "zynqmp_pm_fpga_load" [drivers/fpga/zynqmp-fpga.ko] undefined!
ERROR: modpost: "zynqmp_pm_fpga_get_status" [drivers/fpga/zynqmp-fpga.ko] undefined!
These functions were added to drivers/fpga/zynqmp-fpga.c but not
exported so the module build breaks. Export them so that they can be
used in modules properly.
Fixes: 4db8180ffe7c ("firmware: xilinx: Remove eemi ops for fpga related APIs")
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
---
drivers/firmware/xilinx/zynqmp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
index bfaf29a58eac..8095fa84d5d7 100644
--- a/drivers/firmware/xilinx/zynqmp.c
+++ b/drivers/firmware/xilinx/zynqmp.c
@@ -755,6 +755,7 @@ int zynqmp_pm_fpga_load(const u64 address, const u32 size, const u32 flags)
return zynqmp_pm_invoke_fn(PM_FPGA_LOAD, lower_32_bits(address),
upper_32_bits(address), size, flags, NULL);
}
+EXPORT_SYMBOL_GPL(zynqmp_pm_fpga_load);
/**
* zynqmp_pm_fpga_get_status - Read value from PCAP status register
@@ -778,6 +779,7 @@ int zynqmp_pm_fpga_get_status(u32 *value)
return ret;
}
+EXPORT_SYMBOL_GPL(zynqmp_pm_fpga_get_status);
/**
* zynqmp_pm_init_finalize() - PM call to inform firmware that the caller
base-commit: fb9d670f57e3f6478602328bbbf71138be06ca4f
--
2.26.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] firmware: xilinx: Export zynqmp_pm_fpga_{get_status,load}
2020-05-02 2:59 [PATCH] firmware: xilinx: Export zynqmp_pm_fpga_{get_status,load} Nathan Chancellor
@ 2020-05-05 7:14 ` Michal Simek
0 siblings, 0 replies; 2+ messages in thread
From: Michal Simek @ 2020-05-05 7:14 UTC (permalink / raw)
To: Nathan Chancellor, Michal Simek, Rajan Vaja, Greg Kroah-Hartman
Cc: linux-arm-kernel, linux-kernel
On 02. 05. 20 4:59, Nathan Chancellor wrote:
> When building arm64 allmodconfig:
>
> ERROR: modpost: "zynqmp_pm_fpga_load" [drivers/fpga/zynqmp-fpga.ko] undefined!
> ERROR: modpost: "zynqmp_pm_fpga_get_status" [drivers/fpga/zynqmp-fpga.ko] undefined!
>
> These functions were added to drivers/fpga/zynqmp-fpga.c but not
> exported so the module build breaks. Export them so that they can be
> used in modules properly.
>
> Fixes: 4db8180ffe7c ("firmware: xilinx: Remove eemi ops for fpga related APIs")
> Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
> ---
> drivers/firmware/xilinx/zynqmp.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/firmware/xilinx/zynqmp.c b/drivers/firmware/xilinx/zynqmp.c
> index bfaf29a58eac..8095fa84d5d7 100644
> --- a/drivers/firmware/xilinx/zynqmp.c
> +++ b/drivers/firmware/xilinx/zynqmp.c
> @@ -755,6 +755,7 @@ int zynqmp_pm_fpga_load(const u64 address, const u32 size, const u32 flags)
> return zynqmp_pm_invoke_fn(PM_FPGA_LOAD, lower_32_bits(address),
> upper_32_bits(address), size, flags, NULL);
> }
> +EXPORT_SYMBOL_GPL(zynqmp_pm_fpga_load);
>
> /**
> * zynqmp_pm_fpga_get_status - Read value from PCAP status register
> @@ -778,6 +779,7 @@ int zynqmp_pm_fpga_get_status(u32 *value)
>
> return ret;
> }
> +EXPORT_SYMBOL_GPL(zynqmp_pm_fpga_get_status);
>
> /**
> * zynqmp_pm_init_finalize() - PM call to inform firmware that the caller
>
> base-commit: fb9d670f57e3f6478602328bbbf71138be06ca4f
>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Thanks,
Michal
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-05 7:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-02 2:59 [PATCH] firmware: xilinx: Export zynqmp_pm_fpga_{get_status,load} Nathan Chancellor
2020-05-05 7:14 ` Michal Simek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).