linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Maxim Levitsky <mlevitsk@redhat.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>,
	Brad Campbell <lists2009@fnarfbargle.com>
Cc: kvm@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: KVM broken after suspend in most recent kernels.
Date: Wed, 27 May 2020 15:28:50 +0300	[thread overview]
Message-ID: <7240b1f9ef497fd040c7315d90711c642f709d16.camel@redhat.com> (raw)
In-Reply-To: <20200527051354.GL31696@linux.intel.com>

On Tue, 2020-05-26 at 22:13 -0700, Sean Christopherson wrote:
> On Mon, May 25, 2020 at 09:15:57PM +0800, Brad Campbell wrote:
> > > When you mean that KVM is broken after suspend, you mean that you
> > > can't
> > > start new VMs after suspend, or do VMs that were running before
> > > suspend
> > > break?  I see the later on my machine. I have AMD system though,
> > > so most
> > > likely this is another bug.
> > > 
> > > Looking at the commit, I suspect that we indeed should set the
> > > IA32_FEAT_CTL
> > > after resume from ram, since suspend to ram might count as a
> > > complete CPU
> > > reset.
> > > 
> > 
> > One of those "I should have clarified that" moments immediately
> > after I
> > pressed send.  I've not tried suspending with a VM running. It's
> > "can't start
> > new VMs after suspend".
> 
> Don't bother testing suspending with a VM, the only thing that will
> be
> different is that your system will hang on resume instead when
> running a
> VM.  If there are active VMs, KVM automatically re-enables VMX via
> VMXON
> after resume, and VMXON is what's faulting.
> 
> Odds are good the firmware simply isn't initializing IA32_FEAT_CTL,
> ever.
> The kernel handles the boot-time case, but I (obviously) didn't
> consider
> the suspend case.  I'll work on a patch.

This is exactly what I was thinking about this as well.

Best regards,
	Maxim Levitsky
> 


      reply	other threads:[~2020-05-27 12:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-24  4:50 KVM broken after suspend in most recent kernels Brad Campbell
2020-05-24 10:43 ` Brad Campbell
2020-05-25 11:46   ` Maxim Levitsky
2020-05-25 13:15     ` Brad Campbell
2020-05-27  5:13       ` Sean Christopherson
2020-05-27 12:28         ` Maxim Levitsky [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7240b1f9ef497fd040c7315d90711c642f709d16.camel@redhat.com \
    --to=mlevitsk@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lists2009@fnarfbargle.com \
    --cc=sean.j.christopherson@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).