From: Lukasz Luba <lukasz.luba@arm.com>
To: gao.yunxiao6@gmail.com, rui.zhang@intel.com,
daniel.lezcano@linaro.org, amitk@kernel.org, robh+dt@kernel.org,
javi.merino@kernel.org
Cc: linux-pm@vger.kernel.org, kernel-team@android.com,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
orsonzhai@gmail.com, zhang.lyra@gmail.com,
"jeson.gao" <jeson.gao@unisoc.com>
Subject: Re: [RFC 1/2] dt-bindings: thermal: sprd: Add virtual thermal documentation
Date: Fri, 27 Nov 2020 09:27:19 +0000 [thread overview]
Message-ID: <724ddf78-483c-2cf3-441c-4885af8425a9@arm.com> (raw)
In-Reply-To: <1606466112-31584-1-git-send-email-gao.yunxiao6@gmail.com>
On 11/27/20 8:35 AM, gao.yunxiao6@gmail.com wrote:
> From: "jeson.gao" <jeson.gao@unisoc.com>
>
> virtual thermal node definition description in dts file
>
> Signed-off-by: jeson.gao <jeson.gao@unisoc.com>
> ---
> .../thermal/sprd-virtual-thermal.yaml | 38 +++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/thermal/sprd-virtual-thermal.yaml
>
> diff --git a/Documentation/devicetree/bindings/thermal/sprd-virtual-thermal.yaml b/Documentation/devicetree/bindings/thermal/sprd-virtual-thermal.yaml
> new file mode 100644
> index 000000000000..3e3d2282e2a4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/thermal/sprd-virtual-thermal.yaml
> @@ -0,0 +1,38 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/thermal/sprd-virtual-thermal.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Spreadtrum virtual thermal driver bindings
> +
> +maintainers:
> + - Yunxiao Gao <gao.yunxiao6@gmail.com>
> +
> +properties:
> + compatible:
> + const: sprd,virtual-thermal
> +
> + reg:
> + description: specify the virtual sensor id.
> + maxItems: 1
> +
> + thmzone-names:
> + description: specify per-core thermal zone name.
> +
> +required:
> + - compatible
> + - reg
> + - thmzone-names
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + virtual_sensor: virtual-sensor@1 {
> + compatible = "sprd,virtual-thermal";
> + reg = <1>;
> + thmzone-names = "ank0-thmzone","ank1-thmzone","ank2-thmzone",
> + "ank3-thmzone","ank4-thmzone","ank5-thmzone","prometheus6-tzone0",
> + "prometheus6-tzone1","prometheus7-thmzone";
> + };
>
It's coming back. There were attempts to solve this problem.
Javi tried to solved this using hierarchical thermal zones [1].
It was even agreed (IIRC during LPC) but couldn't continue. Then Eduardo
was going to continue this (last message at [3]). Unfortunately,
development stopped.
I also have out-of-tree similar implementation for my Odroid-xu4,
which does no have an 'SoC' sensor, but have CPU sensors and needs
some aggregation function to get temperature.
I can pick up Javi's patches and continue 'hierarchical thermal zones'
approach.
Javi, Daniel, Rui what do you think?
Regards,
Lukasz
[1] https://lwn.net/Articles/666015/
[2]
https://patchwork.kernel.org/project/linux-pm/patch/1448464186-26289-2-git-send-email-javi.merino@arm.com/
[3]
https://patchwork.kernel.org/project/linux-pm/patch/1448464186-26289-3-git-send-email-javi.merino@arm.com/
[4]
https://patchwork.kernel.org/project/linux-pm/patch/1448464186-26289-4-git-send-email-javi.merino@arm.com/
[5]
https://patchwork.kernel.org/project/linux-pm/patch/1448464186-26289-5-git-send-email-javi.merino@arm.com/
next prev parent reply other threads:[~2020-11-27 9:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-27 8:35 [RFC 1/2] dt-bindings: thermal: sprd: Add virtual thermal documentation gao.yunxiao6
2020-11-27 9:27 ` Lukasz Luba [this message]
2020-11-27 13:26 ` Daniel Lezcano
2020-11-27 13:58 ` Lukasz Luba
2020-11-30 9:03 ` gao yunxiao
2020-11-30 9:40 ` Daniel Lezcano
2020-11-30 10:57 ` gao yunxiao
2020-11-30 17:36 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=724ddf78-483c-2cf3-441c-4885af8425a9@arm.com \
--to=lukasz.luba@arm.com \
--cc=amitk@kernel.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=gao.yunxiao6@gmail.com \
--cc=javi.merino@kernel.org \
--cc=jeson.gao@unisoc.com \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).