From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C634ECAAA1 for ; Tue, 30 Aug 2022 06:05:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229960AbiH3GFY (ORCPT ); Tue, 30 Aug 2022 02:05:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56556 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229650AbiH3GFT (ORCPT ); Tue, 30 Aug 2022 02:05:19 -0400 Received: from mail-sh.amlogic.com (mail-sh.amlogic.com [58.32.228.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F9DC3C8C9; Mon, 29 Aug 2022 23:05:13 -0700 (PDT) Received: from [10.18.29.47] (10.18.29.47) by mail-sh.amlogic.com (10.18.11.5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.9; Tue, 30 Aug 2022 14:05:11 +0800 Message-ID: <72631035-58a6-23b5-1f7e-f1643b120432@amlogic.com> Date: Tue, 30 Aug 2022 14:05:11 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH V3 2/6] arm64: dts: meson: add S4 Soc PLL clock controller in DT Content-Language: en-US To: Jerome Brunet , Krzysztof Kozlowski , , , , , , Rob Herring , Neil Armstrong , Kevin Hilman , Michael Turquette , Stephen Boyd , Krzysztof Kozlowski , Martin Blumenstingl References: <20220805085716.5635-1-yu.tu@amlogic.com> <20220805085716.5635-3-yu.tu@amlogic.com> <19654574-bdc0-9fa5-6465-fc88b20e20c5@linaro.org> <1jmtccz0f4.fsf@starbuckisacylon.baylibre.com> <1j1qszv0wa.fsf@starbuckisacylon.baylibre.com> From: Yu Tu In-Reply-To: <1j1qszv0wa.fsf@starbuckisacylon.baylibre.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.18.29.47] X-ClientProxiedBy: mail-sh.amlogic.com (10.18.11.5) To mail-sh.amlogic.com (10.18.11.5) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2022/8/29 17:43, Jerome Brunet wrote: > [ EXTERNAL EMAIL ] > > > On Mon 15 Aug 2022 at 14:17, Yu Tu wrote: > >> Hi Jerome， >> >> On 2022/8/10 21:32, Jerome Brunet wrote: >>> [ EXTERNAL EMAIL ] >>> On Fri 05 Aug 2022 at 17:39, Yu Tu wrote: >>> >>>> Hi Krzysztof, >>>> Thank you for your reply. >>>> >>>> On 2022/8/5 17:16, Krzysztof Kozlowski wrote: >>>>> [ EXTERNAL EMAIL ] >>>>> On 05/08/2022 10:57, Yu Tu wrote: >>>>>> Added information about the S4 SOC PLL Clock controller in DT. >>>>>> >>>>>> Signed-off-by: Yu Tu >>>>>> --- >>>>>> arch/arm64/boot/dts/amlogic/meson-s4.dtsi | 8 ++++++++ >>>>>> 1 file changed, 8 insertions(+) >>>>>> >>>>>> diff --git a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi >>>>>> index ff213618a598..a816b1f7694b 100644 >>>>>> --- a/arch/arm64/boot/dts/amlogic/meson-s4.dtsi >>>>>> +++ b/arch/arm64/boot/dts/amlogic/meson-s4.dtsi >>>>>> @@ -92,6 +92,14 @@ apb4: apb4@fe000000 { >>>>>> #size-cells = <2>; >>>>>> ranges = <0x0 0x0 0x0 0xfe000000 0x0 0x480000>; >>>>>> + clkc_pll: pll-clock-controller@8000 { >>>>> Node names should be generic - clock-controller. >>>>> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation >>>>> >>>> I will change to clkc_pll: clock-controller@8000, in next version. >>> Same comment applies to the binding doc. >> OKay. >>> Also it would be nice to split this in two series. >>> Bindings and drivers in one, arm64 dt in the other. These changes goes >>> in through different trees. >> At present, Bindings, DTS and drivers are three series. Do you mean to put >> Bindings and drivers together? If so, checkpatch.pl will report a warning. > > Yes because patches are not in yet so there is a good reason to ignore > the warning. Warning will never show up on the actual tree if the > patches are correctly ordered. I think Binding, DTS and drivers use three series and you said two series is not a big problem. Three series are recommended for checkpatch.pl, I think it should be easy for that to separate and merge。 I've sent it to V4. Please look at V4 and give some comments. > >> >>> >>>>> Best regards, >>>>> Krzysztof >>>>> . >>> . > > .