From: Arnd Bergmann <arnd@arndb.de>
To: paulmck@linux.vnet.ibm.com
Cc: Boqun Feng <boqun.feng@gmail.com>,
Josh Triplett <josh@joshtriplett.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] torture: use ktime_t consistently
Date: Mon, 20 Jun 2016 20:29:48 +0200 [thread overview]
Message-ID: <7277827.7A0WjZ9kZU@wuerfel> (raw)
In-Reply-To: <20160620182105.GV3923@linux.vnet.ibm.com>
On Monday, June 20, 2016 11:21:05 AM CEST Paul E. McKenney wrote:
> On Mon, Jun 20, 2016 at 05:56:40PM +0200, Arnd Bergmann wrote:
>
> @@ -446,9 +447,9 @@ EXPORT_SYMBOL_GPL(torture_shuffle_cleanup);
> * Variables for auto-shutdown. This allows "lights out" torture runs
> * to be fully scripted.
> */
> -static int shutdown_secs; /* desired test duration in seconds. */
> +static ktime_t shutdown_ms; /* desired test duration in seconds. */
the variable name is a bit odd.
> @@ -511,10 +513,10 @@ int torture_shutdown_init(int ssecs, void (*cleanup)(void))
> {
> int ret = 0;
>
> - shutdown_secs = ssecs;
> torture_shutdown_hook = cleanup;
> - if (shutdown_secs > 0) {
> - shutdown_time = jiffies + shutdown_secs * HZ;
> + if (ssecs > 0) {
> + shutdown_ms = ms_to_ktime(ssecs * 1000ULL);
> + shutdown_time = ktime_add(ktime_get(), shutdown_ms);
> ret = torture_create_kthread(torture_shutdown, NULL,
> shutdown_task);
and I picked ktime_set(ssecs, 0) instead of ms_to_ktime(ssecs * 1000ULL), but
both differences are just cosmetic and should end up in exactly the
same object code that I suggested. Unless we both made the same mistake,
your version should be good too.
Thanks,
Arnd
next prev parent reply other threads:[~2016-06-20 18:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 15:56 [PATCH] torture: use ktime_t consistently Arnd Bergmann
2016-06-20 18:21 ` Paul E. McKenney
2016-06-20 18:29 ` Arnd Bergmann [this message]
2016-06-20 18:37 ` Paul E. McKenney
2016-06-20 19:29 ` Arnd Bergmann
2016-06-21 18:39 ` Paul E. McKenney
2016-06-22 2:00 ` Boqun Feng
2016-06-22 3:27 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7277827.7A0WjZ9kZU@wuerfel \
--to=arnd@arndb.de \
--cc=boqun.feng@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).