From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: "Lin, Meng-Bo" <linmengbo0689@protonmail.com>,
linux-kernel@vger.kernel.org
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Stanislav Jakubek <stano.jakubek@gmail.com>,
Shawn Guo <shawnguo@kernel.org>,
Stephan Gerhold <stephan@gerhold.net>,
Nikita Travkin <nikita@trvn.ru>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH 4/5] arm64: dts: qcom: msm8916-gplus-fl8005a: Add touchscreen
Date: Mon, 21 Nov 2022 12:23:52 +0100 [thread overview]
Message-ID: <729600fb-e2e6-5ae8-514b-2847501b1c14@linaro.org> (raw)
In-Reply-To: <20221119202649.93613-1-linmengbo0689@protonmail.com>
On 19.11.2022 21:27, Lin, Meng-Bo wrote:
> FL8005A uses a Focaltech FT5402 touchscreen that is connected to
> blsp_i2c5. Add it to the device tree.
>
> Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
> ---
> .../boot/dts/qcom/msm8916-gplus-fl8005a.dts | 44 +++++++++++++++++++
> 1 file changed, 44 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/msm8916-gplus-fl8005a.dts b/arch/arm64/boot/dts/qcom/msm8916-gplus-fl8005a.dts
> index bed1fe984287..cc81880f7c42 100644
> --- a/arch/arm64/boot/dts/qcom/msm8916-gplus-fl8005a.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8916-gplus-fl8005a.dts
> @@ -65,6 +65,32 @@ usb_id: usb-id {
> };
> };
>
> +&blsp_i2c5 {
> + status = "okay";
> +
> + touchscreen@38 {
> + /* Actually ft5402 */
> + compatible = "edt,edt-ft5406";
> + reg = <0x38>;
> +
> + interrupt-parent = <&msmgpio>;
> + interrupts = <13 IRQ_TYPE_EDGE_FALLING>;
> +
> + reset-gpios = <&msmgpio 12 GPIO_ACTIVE_LOW>;
> +
> + vcc-supply = <&pm8916_l17>;
> + iovcc-supply = <&pm8916_l6>;
> +
> + touchscreen-size-x = <800>;
> + touchscreen-size-y = <500>;
> + touchscreen-inverted-x;
> + touchscreen-swapped-x-y;
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&touchscreen_default>;
> + };
> +};
> +
> &blsp1_uart2 {
> status = "okay";
> };
> @@ -229,6 +255,24 @@ gpio_leds_default: gpio-led-default-state {
> bias-disable;
> };
>
> + touchscreen_default: touchscreen-default-state {
> + touchscreen-pins {
> + pins = "gpio13";
> + function = "gpio";
> +
> + drive-strength = <2>;
> + bias-pull-up;
> + };
> +
> + reset-pins {
> + pins = "gpio12";
> + function = "gpio";
> +
> + drive-strength = <2>;
> + bias-disable;
> + };
These subnodes are not sorted in any way, neither alphabetically nor
GPIO-no wise. Please swap them.
With that:
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Konrad
> + };
> +
> usb_id_default: usb-id-default-state {
> pins = "gpio110";
> function = "gpio";
next prev parent reply other threads:[~2022-11-21 11:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-19 20:24 [PATCH 0/5] arm64: dts: qcom: msm8916-gplus-fl8005a: Add initial device tree Lin, Meng-Bo
2022-11-19 20:27 ` [PATCH 1/5] dt-bindings: vendor-prefixes: Add GPLUS Lin, Meng-Bo
2022-11-21 9:15 ` Krzysztof Kozlowski
2022-11-19 20:27 ` [PATCH 2/5] dt-bindings: qcom: Document bindings for new msm8916-gplus-fl8005a device Lin, Meng-Bo
2022-11-21 9:16 ` Krzysztof Kozlowski
2022-11-19 20:27 ` [PATCH 3/5] arm64: dts: qcom: msm8916-gplus-fl8005a: Add initial device tree Lin, Meng-Bo
2022-11-21 11:22 ` Konrad Dybcio
2022-11-19 20:27 ` [PATCH 4/5] arm64: dts: qcom: msm8916-gplus-fl8005a: Add touchscreen Lin, Meng-Bo
2022-11-21 11:23 ` Konrad Dybcio [this message]
2022-11-19 20:28 ` [PATCH 5/5] arm64: dts: qcom: msm8916-gplus-fl8005a: Add flash LED Lin, Meng-Bo
2022-11-21 11:24 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=729600fb-e2e6-5ae8-514b-2847501b1c14@linaro.org \
--to=konrad.dybcio@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linmengbo0689@protonmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nikita@trvn.ru \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=stano.jakubek@gmail.com \
--cc=stephan@gerhold.net \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).