From: Paul Cercueil <paul@crapouillou.net>
To: Zhou Yanjie <zhouyanjie@wanyeetech.com>
Cc: gregkh@linuxfoundation.org, hminas@synopsys.com,
robh+dt@kernel.org, krzk+dt@kernel.org,
tsbogend@alpha.franken.de, linux-usb@vger.kernel.org,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, dragancecavac@yahoo.com,
hns@goldelico.com, dongsheng.qiu@ingenic.com,
aric.pzqi@ingenic.com, rick.tyliu@ingenic.com,
sernia.zhou@foxmail.com, zhenwenjin@gmail.com,
reimu@sudomaker.com
Subject: Re: [PATCH v3 3/3] MIPS: Ingenic: Refresh USB nodes to match driver changes.
Date: Sat, 16 Apr 2022 17:34:55 +0100 [thread overview]
Message-ID: <72YFAR.2F64W3SYY7912@crapouillou.net> (raw)
In-Reply-To: <16eb34cf-508b-b387-b255-4b0a778bf53f@wanyeetech.com>
Hi Zhou,
Le sam., avril 16 2022 at 20:16:33 +0800, Zhou Yanjie
<zhouyanjie@wanyeetech.com> a écrit :
> Hi Paul,
>
> On 2022/4/15 下午11:07, Paul Cercueil wrote:
>> Hi Zhou,
>>
>>
>> Le ven., avril 15 2022 at 03:25:37 +0800, 周琰杰 (Zhou Yanjie)
>> \x7f<zhouyanjie@wanyeetech.com> a écrit :
>>> Refresh USB nodes in the jz4780.dtsi, x1000.dtsi, and x1830.dtsi
>>> files.
>>>
>>> Signed-off-by: 周琰杰 (Zhou Yanjie) <zhouyanjie@wanyeetech.com>
>>> ---
>>>
>>> Notes:
>>> v3:
>>> New patch.
>>>
>>> arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 +-
>>> arch/mips/boot/dts/ingenic/x1000.dtsi | 2 +-
>>> arch/mips/boot/dts/ingenic/x1830.dtsi | 2 +-
>>> 3 files changed, 3 insertions(+), 3 deletions(-)
>>>
>>> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi
>>> \x7f\x7fb/arch/mips/boot/dts/ingenic/jz4780.dtsi
>>> index b998301..c182a65 100644
>>> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
>>> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
>>> @@ -577,7 +577,7 @@
>>> };
>>>
>>> otg: usb@13500000 {
>>> - compatible = "ingenic,jz4780-otg", "snps,dwc2";
>>> + compatible = "ingenic,jz4780-otg";
>>
>> Could you refresh my memory - why are the "snps,dwc2" fallback
>> strings \x7fremoved?
>>
>> To me it seems like they should be here, since the OTG IP in Ingenic
>> \x7fSoCs is derived from the DWC2 IP.
>
>
> The reason is that Nikolaus found that the current jz4780.dtsi will
> cause
> dtbscheck to complain. After discussion, Nikolaus concluded three
> feasible
> solutions, see here:
> https://lkml.org/lkml/2022/4/13/1097
>
> And it seems that Krzysztof prefers the c) option.
Understood.
-Paul
>
> Thanks and best regards!
>
>
>>
>> Cheers,
>> -Paul
>>
>>> reg = <0x13500000 0x40000>;
>>>
>>> interrupt-parent = <&intc>;
>>> diff --git a/arch/mips/boot/dts/ingenic/x1000.dtsi
>>> \x7f\x7fb/arch/mips/boot/dts/ingenic/x1000.dtsi
>>> index 8bd27ede..343818a2 100644
>>> --- a/arch/mips/boot/dts/ingenic/x1000.dtsi
>>> +++ b/arch/mips/boot/dts/ingenic/x1000.dtsi
>>> @@ -366,7 +366,7 @@
>>> };
>>>
>>> otg: usb@13500000 {
>>> - compatible = "ingenic,x1000-otg", "snps,dwc2";
>>> + compatible = "ingenic,x1000-otg";
>>> reg = <0x13500000 0x40000>;
>>>
>>> interrupt-parent = <&intc>;
>>> diff --git a/arch/mips/boot/dts/ingenic/x1830.dtsi
>>> \x7f\x7fb/arch/mips/boot/dts/ingenic/x1830.dtsi
>>> index 2595df8..6aff19f 100644
>>> --- a/arch/mips/boot/dts/ingenic/x1830.dtsi
>>> +++ b/arch/mips/boot/dts/ingenic/x1830.dtsi
>>> @@ -355,7 +355,7 @@
>>> };
>>>
>>> otg: usb@13500000 {
>>> - compatible = "ingenic,x1830-otg", "snps,dwc2";
>>> + compatible = "ingenic,x1830-otg";
>>> reg = <0x13500000 0x40000>;
>>>
>>> interrupt-parent = <&intc>;
>>> --
>>> 2.7.4
>>>
>>
prev parent reply other threads:[~2022-04-16 16:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-14 19:25 [PATCH v3 0/3] Add OTG support for Ingenic SoCs 周琰杰 (Zhou Yanjie)
2022-04-14 19:25 ` [PATCH v3 1/3] dt-bindings: dwc2: Add bindings for new " 周琰杰 (Zhou Yanjie)
2022-04-16 16:34 ` Paul Cercueil
2022-04-17 9:27 ` Zhou Yanjie
2022-04-14 19:25 ` [PATCH v3 2/3] USB: dwc2: Add OTG support for " 周琰杰 (Zhou Yanjie)
2022-04-14 19:25 ` [PATCH v3 3/3] MIPS: Ingenic: Refresh USB nodes to match driver changes 周琰杰 (Zhou Yanjie)
2022-04-15 15:07 ` Paul Cercueil
2022-04-16 12:16 ` Zhou Yanjie
2022-04-16 16:34 ` Paul Cercueil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72YFAR.2F64W3SYY7912@crapouillou.net \
--to=paul@crapouillou.net \
--cc=aric.pzqi@ingenic.com \
--cc=devicetree@vger.kernel.org \
--cc=dongsheng.qiu@ingenic.com \
--cc=dragancecavac@yahoo.com \
--cc=gregkh@linuxfoundation.org \
--cc=hminas@synopsys.com \
--cc=hns@goldelico.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=reimu@sudomaker.com \
--cc=rick.tyliu@ingenic.com \
--cc=robh+dt@kernel.org \
--cc=sernia.zhou@foxmail.com \
--cc=tsbogend@alpha.franken.de \
--cc=zhenwenjin@gmail.com \
--cc=zhouyanjie@wanyeetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).