From: "Ardelean, Alexandru" <Alex.Ardelean@analog.com>
To: "lars@metafoo.de" <lars@metafoo.de>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"Popa, Stefan Serban" <StefanSerban.Popa@analog.com>,
"knaack.h@gmx.de" <knaack.h@gmx.de>,
"jic23@kernel.org" <jic23@kernel.org>,
"Hennerich, Michael" <Michael.Hennerich@analog.com>,
"renatogeh@gmail.com" <renatogeh@gmail.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"giuliano.belinassi@usp.br" <giuliano.belinassi@usp.br>,
"pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
"kernel-usp@googlegroups.com" <kernel-usp@googlegroups.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH v4 0/9] staging: iio: ad7780: move out of staging
Date: Fri, 1 Mar 2019 08:35:17 +0000 [thread overview]
Message-ID: <72a54cd5f58aeb9507b95b7e33ca3d9a38c853e9.camel@analog.com> (raw)
In-Reply-To: <cover.1551358569.git.renatogeh@gmail.com>
On Thu, 2019-02-28 at 11:23 -0300, Renato Lui Geh wrote:
>
The patch-series is a bit big.
I guess that the intent is to move this out-of-staging, but various patches
are holding this in it's place.
For patch series above a certain size, you could get many re-spins
[V2,3,4... so on].
You could send some of the changes as individual patches, or group them in
series of 1,2 or 3 patches. That way, you "parallelize" patch sending, and
when you get reviews on each patch, you can re-spin them individually.
You'll find over time that certain patches get accepted on V1, others on V2
and some on V7 [ hopefully, there isn't any frustration at that point ].
Well, this is a technique I use to distribute some of my upstream-patch-
work, so that I can switch easier between internal-work & upstreaming-work.
Coming back to this patch-series.
My general input, is that the patches are fine over-all; some are just
cosmetics/noise/a-different-way-of-doing-things-for-this-driver, and those
usually can be left to preference [of the maintainer usually].
I do suggest to not hurry when re-spinning patches, and not change too much
the number of patches in a new series. That can complicate things
sometimes. But, if doing small patch-series or individual patches, you
won't have this problem too much.
Thanks
Alex
>
> This series of patches contains the following:
> - Adds user input for the 'gain' and 'filter' GPIO pins for the ad778x
> family chips;
> - Filter reading for the ad778x;
> - Sets pattern macro values and mask for PATTERN status bits;
> - Adds ID values for the ad7170, ad7171, ad7780 and ad7781 for ID
> status bits checking;
> - Moves regulator initialization to after GPIO init to maintain
> consistency between probe and remove;
> - Copyright edits, adding SPDX identifier and new copyright holder;
> - Moves the ad7780 driver out of staging to the mainline;
> - Adds device tree binding for the ad7780 driver.
>
> Renato Lui Geh (9):
> staging: iio: ad7780: add gain & filter gpio support
> staging: iio: ad7780: add filter reading to ad778x
> staging: iio: ad7780: set pattern values and masks directly
> staging:iio:ad7780: add chip ID values and mask
> staging: iio: ad7780: move regulator to after GPIO init
> staging: iio: ad7780: add SPDX identifier
> staging: iio: ad7780: add new copyright holder
> staging: iio: ad7780: moving ad7780 out of staging
> staging: iio: ad7780: add device tree binding
>
> Changelog:
> *v3
> - SPDX and regulator init as patches
> - Renamed filter to odr and ad778x_filter to ad778x_odr_avail
> - Removed unnecessary regulator disabling
> - Removed unnecessary AD_SD_CHANNEL macro
> - Changed unsigned int to unsigned long long to avoid overflow
> *v4
> - Split gain & filter patch into two, with the new commit adding only
> filter reading
> - Changed pattern values to direct values, and added pattern mask
> - Added ID values and mask
> - Added new copyright holder
> - Added device tree binding to the ad7780 driver
>
> .../bindings/iio/adc/adi,ad7780.txt | 48 +++
> drivers/iio/adc/Kconfig | 12 +
> drivers/iio/adc/Makefile | 1 +
> drivers/iio/adc/ad7780.c | 365 ++++++++++++++++++
> drivers/staging/iio/adc/Kconfig | 13 -
> drivers/staging/iio/adc/Makefile | 1 -
> drivers/staging/iio/adc/ad7780.c | 277 -------------
> 7 files changed, 426 insertions(+), 291 deletions(-)
> create mode 100644
> Documentation/devicetree/bindings/iio/adc/adi,ad7780.txt
> create mode 100644 drivers/iio/adc/ad7780.c
> delete mode 100644 drivers/staging/iio/adc/ad7780.c
>
> --
> 2.21.0
>
next prev parent reply other threads:[~2019-03-01 8:35 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 14:23 [PATCH v4 0/9] staging: iio: ad7780: move out of staging Renato Lui Geh
2019-02-28 14:23 ` [PATCH v4 1/9] staging: iio: ad7780: add gain & filter gpio support Renato Lui Geh
2019-03-01 6:56 ` Ardelean, Alexandru
2019-03-01 7:42 ` Dan Carpenter
2019-03-02 19:03 ` Jonathan Cameron
2019-02-28 14:24 ` [PATCH v4 2/9] staging: iio: ad7780: add filter reading to ad778x Renato Lui Geh
2019-03-01 6:59 ` Ardelean, Alexandru
2019-02-28 14:24 ` [PATCH v4 3/9] staging: iio: ad7780: set pattern values and masks directly Renato Lui Geh
2019-03-01 7:17 ` Ardelean, Alexandru
2019-03-02 19:07 ` Jonathan Cameron
2019-03-02 19:08 ` Jonathan Cameron
2019-03-04 7:19 ` Ardelean, Alexandru
2019-02-28 14:24 ` [PATCH v4 4/9] staging:iio:ad7780: add chip ID values and mask Renato Lui Geh
2019-03-01 7:20 ` Ardelean, Alexandru
2019-03-03 14:01 ` Renato Lui Geh
2019-03-03 14:53 ` Jonathan Cameron
2019-03-04 7:33 ` Ardelean, Alexandru
2019-03-09 0:19 ` Renato Lui Geh
2019-03-09 17:47 ` Jonathan Cameron
2019-02-28 14:25 ` [PATCH v4 5/9] staging: iio: ad7780: move regulator to after GPIO init Renato Lui Geh
2019-03-01 7:38 ` Ardelean, Alexandru
2019-03-02 19:11 ` Jonathan Cameron
2019-03-04 7:20 ` Ardelean, Alexandru
2019-02-28 14:25 ` [PATCH v4 6/9] staging: iio: ad7780: add SPDX identifier Renato Lui Geh
2019-02-28 14:25 ` [PATCH v4 7/9] staging: iio: ad7780: add new copyright holder Renato Lui Geh
2019-02-28 14:26 ` [PATCH v4 8/9] staging: iio: ad7780: moving ad7780 out of staging Renato Lui Geh
2019-03-02 19:17 ` Jonathan Cameron
2019-02-28 14:26 ` [PATCH v4 9/9] staging: iio: ad7780: add device tree binding Renato Lui Geh
2019-03-02 19:13 ` Jonathan Cameron
2019-03-11 22:47 ` Rob Herring
2019-03-01 8:35 ` Ardelean, Alexandru [this message]
2019-03-03 13:52 ` [PATCH v4 0/9] staging: iio: ad7780: move out of staging Renato Lui Geh
2019-03-03 14:32 ` Alexandru Ardelean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72a54cd5f58aeb9507b95b7e33ca3d9a38c853e9.camel@analog.com \
--to=alex.ardelean@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=StefanSerban.Popa@analog.com \
--cc=devel@driverdev.osuosl.org \
--cc=devicetree@vger.kernel.org \
--cc=giuliano.belinassi@usp.br \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=kernel-usp@googlegroups.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pmeerw@pmeerw.net \
--cc=renatogeh@gmail.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).