From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BA18C433DF for ; Sat, 4 Jul 2020 14:56:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2D8BA21883 for ; Sat, 4 Jul 2020 14:56:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727043AbgGDO4g (ORCPT ); Sat, 4 Jul 2020 10:56:36 -0400 Received: from orion.archlinux.org ([88.198.91.70]:55194 "EHLO orion.archlinux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726488AbgGDO4f (ORCPT ); Sat, 4 Jul 2020 10:56:35 -0400 Received: from orion.archlinux.org (localhost [127.0.0.1]) by orion.archlinux.org (Postfix) with ESMTP id 30C231D3582743; Sat, 4 Jul 2020 14:56:33 +0000 (UTC) Received: from centaurus (unknown [37.189.45.160]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: ffy00) by orion.archlinux.org (Postfix) with ESMTPSA; Sat, 4 Jul 2020 14:56:32 +0000 (UTC) Message-ID: <72aa9cf8c9bc46548c29742f55be7d3b0c002971.camel@archlinux.org> Subject: Re: [PATCH v3] HID: logitech-hidpp: add support for Logitech G533 headset From: Filipe =?ISO-8859-1?Q?La=EDns?= To: Kamil =?UTF-8?Q?Doma=C5=84ski?= , Jiri Kosina , Benjamin Tissoires , linux-kernel@vger.kernel.org Cc: Nestor Lopez Casado In-Reply-To: <20200704004745.383271-1-kamil@domanski.co> References: <20200704004745.383271-1-kamil@domanski.co> Organization: Archlinux Content-Type: multipart/signed; micalg="pgp-sha256"; protocol="application/pgp-signature"; boundary="=-GdT9r/VywNZa2Mspbe4R" Date: Sat, 04 Jul 2020 16:01:43 +0100 MIME-Version: 1.0 User-Agent: Evolution 3.36.4 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --=-GdT9r/VywNZa2Mspbe4R Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, 2020-07-04 at 02:47 +0200, Kamil Doma=C5=84ski wrote: > Changelog: > v2: > - changed charging status parsing to account for invalid states > v3: > - rebased against Linux v5.7 > - changed variable naming in hidpp20_adc_map_status_voltage > to camel case > - corrected comment styling in hidpp_battery_get_property > - dropped usage of test_bit macro in hidpp20_adc_map_status_voltage > to avoid using `long` type > - added bit flag definitions in hidpp20_adc_map_status_voltage >=20 > Signed-off-by: Kamil Doma=C5=84ski Seems like my concerns were address and the patch looks correct. Benjamin, Jiri, are there any implications to keep in mind of always polling the device every time we need to read the voltage? I don't expect anything major, I just thought there might something there I should keep in the back of my mind.=20 Cheers, Filipe La=C3=ADns --=-GdT9r/VywNZa2Mspbe4R Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEE0jW0leqs33gyftiw+JPGdIFqqV0FAl8Amc0ACgkQ+JPGdIFq qV2UYQ//RszgLx10wEQNOJcwL2CzwReRT3sHGA8Cjx26fCzqvgofQ7lLBgdrdsIM WgYzFiDY6Q9r9Q+P0ZrUlpvOQES2OnA/7kYY9ViydF+sy4fH8LIUciISzVTsvO7i YYGRgln5ufeZ3d6McoHvnfjezOYXstGPpcFdGGgCFqk1dmKZ85crDr2Ql9LrbAeB of8Lv8IzNwZG8J6q2hHmD5KZV4b/XASsWSyR7zKd17A3EPOfE0vC0IvSKWEveegM pnSau/uC9YvSKAZqCyK/WEmCu3L2GqI9GX0WxAzK5jpoxKfYLDk0l4VJfGPHJgyr ck1YLhDM8cvQKY/DVkbLrN9dQbcYFDZj6rfOOKxaw+028qrRCJ1I95mvG06wfa2B Vbf5gAyv1fe5mrZIGuXR2ksSdKFJpebIzwSNwTtbhr9xTkduA7ZyNH8ovJEvyjIo dl8b7LKuutOh/ssB6/zx7yWOWLxmHpBTGaBvJm0g96+cfufLD81Li6PKLbFTAEDc yIh9OElKD1JWLdYYucgiMHbplUDzVTBuyZZjs9yOwDZwrFZqqvuKUCrEdQCUS8+1 m+LSDcr473w5i7vsgh4NEAZz8w/9tIfyxOyTaakBBdGJrpP5fBhI5conQWEHCYld kyYlH/iO5df/7tQWLJqifQE+Hns7WbESReFidcIZEF5ozll4AtI= =8KEs -----END PGP SIGNATURE----- --=-GdT9r/VywNZa2Mspbe4R--