From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5952DC19F2C for ; Tue, 2 Aug 2022 23:43:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234700AbiHBXnB (ORCPT ); Tue, 2 Aug 2022 19:43:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229568AbiHBXnA (ORCPT ); Tue, 2 Aug 2022 19:43:00 -0400 Received: from mga06.intel.com (mga06b.intel.com [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 755AD51A37; Tue, 2 Aug 2022 16:42:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659483779; x=1691019779; h=message-id:subject:from:to:cc:date:in-reply-to: references:content-transfer-encoding:mime-version; bh=k1gNX86YincOcL9VRCK/r4AXXqCHM/b4AG11KWtCuDY=; b=WmqGv8SlJxLkEFy0UeAb6izDAfkkTAz3TtTOJbf2fWWrDUAmebDM+Zo/ ceV2xWxcBH7HrtokDyL9CajbJARFFpJ1jU90We0ktTxPdDzyxq4aD7/Dj wnSiRBctTUkvJEARZ8+zK5uBikQNEpBzKCKEveT8yYrpIOzKEpjTecn9w SjUkC1psv8enKIYnJA09w3j5crsPy3hMRzaPinDeIP97hAQHnBw03Zjl9 nsdm+skB/RaEcBl1P52vIXbqWJeCPclHobnCdt4djkZ/36LlZTwh0QTvR jv3bPVLPm/SCnZNQ16C2rd2w0DH53AcKsco5LjT1vKgYRprLxWCkVFObB g==; X-IronPort-AV: E=McAfee;i="6400,9594,10427"; a="351256633" X-IronPort-AV: E=Sophos;i="5.93,212,1654585200"; d="scan'208";a="351256633" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2022 16:42:59 -0700 X-IronPort-AV: E=Sophos;i="5.93,212,1654585200"; d="scan'208";a="630917735" Received: from gvenka2-desk.amr.corp.intel.com (HELO khuang2-desk.gar.corp.intel.com) ([10.212.85.17]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2022 16:42:57 -0700 Message-ID: <72b51c373e09fe8f0a6a65c40d75753348c64ce1.camel@intel.com> Subject: Re: [PATCH 2/4] KVM: x86/mmu: Fully re-evaluate MMIO caching when SPTE masks change From: Kai Huang To: Sean Christopherson Cc: Paolo Bonzini , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Roth , Tom Lendacky Date: Wed, 03 Aug 2022 11:42:55 +1200 In-Reply-To: References: <20220728221759.3492539-3-seanjc@google.com> <9104e22da628fef86a6e8a02d9d2e81814a9d598.camel@intel.com> <244f619a4e7a1c7079830d12379872a111da418d.camel@intel.com> <4fd3cea874b69f1c8bbcaf19538c7fdcb9c22aab.camel@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.3 (3.44.3-1.fc36) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2022-08-02 at 23:05 +0000, Sean Christopherson wrote: > On Wed, Aug 03, 2022, Kai Huang wrote: > > On Tue, 2022-08-02 at 21:15 +0000, Sean Christopherson wrote: > > > On Tue, Aug 02, 2022, Kai Huang wrote: > > > > But we are not checking any of those in kvm_mmu_set_mmio_spte_mask(= ), right? :) > > >=20 > > > No, but we really should. > >=20 > > I can come up a patch if you are not planning to do so? >=20 > Hmm, I'll throw one together, it's simple enough (famous last words) and = it'll > need to be tested on AMD as well. Sure. --=20 Thanks, -Kai