* Re: [PATCH] dt-bindings: gpio: zynq: Add missing compatible strings
2021-10-14 10:14 [PATCH] dt-bindings: gpio: zynq: Add missing compatible strings Michal Simek
@ 2021-10-14 14:31 ` Rob Herring
2021-10-15 9:28 ` Michal Simek
2021-10-16 22:19 ` Linus Walleij
` (2 subsequent siblings)
3 siblings, 1 reply; 6+ messages in thread
From: Rob Herring @ 2021-10-14 14:31 UTC (permalink / raw)
To: Michal Simek
Cc: Rob Herring, devicetree, monstr, Bartosz Golaszewski,
Srinivas Neeli, Linus Walleij, Shubhrajyoti Datta, linux-gpio,
linux-kernel, Nobuhiro Iwamatsu, linux-arm-kernel, git
On Thu, 14 Oct 2021 12:14:18 +0200, Michal Simek wrote:
> "xlnx,zynqmp-gpio-1.0", "xlnx,versal-gpio-1.0" and "xlnx,pmc-gpio-1.0"
> compatible strings were not moved to yaml format. But they were in origin
> text file.
>
> Fixes: 45ca16072b70 ("dt-bindings: gpio: zynq: convert bindings to YAML")
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> Documentation/devicetree/bindings/gpio/gpio-zynq.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Running 'make dtbs_check' with the schema in this patch gives the
following warnings. Consider if they are expected or the schema is
incorrect. These may not be new warnings.
Note that it is not yet a requirement to have 0 warnings for dtbs_check.
This will change in the future.
Full log is available here: https://patchwork.ozlabs.org/patch/1540859
gpio@ff0a0000: '#address-cells', 'gpio-line-names', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml
gpio@ff0a0000: '#address-cells', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+'
arch/arm64/boot/dts/xilinx/zynqmp-zc1232-revA.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zc1254-revA.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zc1275-revA.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm015-dc1.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm016-dc2.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm018-dc4.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm019-dc5.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revB.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revA.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revC.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dt.yaml
arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dt.yaml
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: gpio: zynq: Add missing compatible strings
2021-10-14 14:31 ` Rob Herring
@ 2021-10-15 9:28 ` Michal Simek
0 siblings, 0 replies; 6+ messages in thread
From: Michal Simek @ 2021-10-15 9:28 UTC (permalink / raw)
To: Rob Herring, Michal Simek
Cc: Rob Herring, devicetree, monstr, Bartosz Golaszewski,
Srinivas Neeli, Linus Walleij, Shubhrajyoti Datta, linux-gpio,
linux-kernel, Nobuhiro Iwamatsu, linux-arm-kernel, git
Hi Rob,
On 10/14/21 16:31, Rob Herring wrote:
> On Thu, 14 Oct 2021 12:14:18 +0200, Michal Simek wrote:
>> "xlnx,zynqmp-gpio-1.0", "xlnx,versal-gpio-1.0" and "xlnx,pmc-gpio-1.0"
>> compatible strings were not moved to yaml format. But they were in origin
>> text file.
>>
>> Fixes: 45ca16072b70 ("dt-bindings: gpio: zynq: convert bindings to YAML")
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>> Documentation/devicetree/bindings/gpio/gpio-zynq.yaml | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>
> Running 'make dtbs_check' with the schema in this patch gives the
> following warnings. Consider if they are expected or the schema is
> incorrect. These may not be new warnings.
>
> Note that it is not yet a requirement to have 0 warnings for dtbs_check.
> This will change in the future.
>
> Full log is available here: https://patchwork.ozlabs.org/patch/1540859
>
>
> gpio@ff0a0000: '#address-cells', 'gpio-line-names', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm64/boot/dts/xilinx/avnet-ultra96-rev1.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zcu100-revC.dt.yaml
>
> gpio@ff0a0000: '#address-cells', 'power-domains' do not match any of the regexes: 'pinctrl-[0-9]+'
> arch/arm64/boot/dts/xilinx/zynqmp-zc1232-revA.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zc1254-revA.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zc1275-revA.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm015-dc1.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm016-dc2.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm017-dc3.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm018-dc4.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zc1751-xm019-dc5.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zcu102-rev1.0.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revA.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zcu102-revB.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revA.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zcu104-revC.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zcu106-revA.dt.yaml
> arch/arm64/boot/dts/xilinx/zynqmp-zcu111-revA.dt.yaml
>
I sent patches for listing power-domain and gpio-line-names based on
this patch.
Thanks,
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] dt-bindings: gpio: zynq: Add missing compatible strings
2021-10-14 10:14 [PATCH] dt-bindings: gpio: zynq: Add missing compatible strings Michal Simek
2021-10-14 14:31 ` Rob Herring
@ 2021-10-16 22:19 ` Linus Walleij
2021-10-26 21:14 ` Rob Herring
2022-05-16 14:49 ` Michal Simek
3 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2021-10-16 22:19 UTC (permalink / raw)
To: Michal Simek
Cc: linux-kernel, Michal Simek, git, Bartosz Golaszewski,
Nobuhiro Iwamatsu, Rob Herring, Shubhrajyoti Datta,
Srinivas Neeli,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux ARM, open list:GPIO SUBSYSTEM
On Thu, Oct 14, 2021 at 12:14 PM Michal Simek <michal.simek@xilinx.com> wrote:
> "xlnx,zynqmp-gpio-1.0", "xlnx,versal-gpio-1.0" and "xlnx,pmc-gpio-1.0"
> compatible strings were not moved to yaml format. But they were in origin
> text file.
>
> Fixes: 45ca16072b70 ("dt-bindings: gpio: zynq: convert bindings to YAML")
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: gpio: zynq: Add missing compatible strings
2021-10-14 10:14 [PATCH] dt-bindings: gpio: zynq: Add missing compatible strings Michal Simek
2021-10-14 14:31 ` Rob Herring
2021-10-16 22:19 ` Linus Walleij
@ 2021-10-26 21:14 ` Rob Herring
2022-05-16 14:49 ` Michal Simek
3 siblings, 0 replies; 6+ messages in thread
From: Rob Herring @ 2021-10-26 21:14 UTC (permalink / raw)
To: Michal Simek
Cc: devicetree, Linus Walleij, linux-arm-kernel, Bartosz Golaszewski,
Nobuhiro Iwamatsu, linux-gpio, monstr, Rob Herring, linux-kernel,
Shubhrajyoti Datta, Srinivas Neeli, git
On Thu, 14 Oct 2021 12:14:18 +0200, Michal Simek wrote:
> "xlnx,zynqmp-gpio-1.0", "xlnx,versal-gpio-1.0" and "xlnx,pmc-gpio-1.0"
> compatible strings were not moved to yaml format. But they were in origin
> text file.
>
> Fixes: 45ca16072b70 ("dt-bindings: gpio: zynq: convert bindings to YAML")
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> Documentation/devicetree/bindings/gpio/gpio-zynq.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Acked-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] dt-bindings: gpio: zynq: Add missing compatible strings
2021-10-14 10:14 [PATCH] dt-bindings: gpio: zynq: Add missing compatible strings Michal Simek
` (2 preceding siblings ...)
2021-10-26 21:14 ` Rob Herring
@ 2022-05-16 14:49 ` Michal Simek
3 siblings, 0 replies; 6+ messages in thread
From: Michal Simek @ 2022-05-16 14:49 UTC (permalink / raw)
To: LKML, Michal Simek, git
Cc: Bartosz Golaszewski, Linus Walleij, Nobuhiro Iwamatsu,
Rob Herring, Shubhrajyoti Datta, Srinivas Neeli, DTML, linux-arm,
open list:GPIO SUBSYSTEM
čt 14. 10. 2021 v 12:14 odesílatel Michal Simek
<michal.simek@xilinx.com> napsal:
>
> "xlnx,zynqmp-gpio-1.0", "xlnx,versal-gpio-1.0" and "xlnx,pmc-gpio-1.0"
> compatible strings were not moved to yaml format. But they were in origin
> text file.
>
> Fixes: 45ca16072b70 ("dt-bindings: gpio: zynq: convert bindings to YAML")
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> Documentation/devicetree/bindings/gpio/gpio-zynq.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml b/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml
> index 378da2649e66..980f92ad9eba 100644
> --- a/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml
> +++ b/Documentation/devicetree/bindings/gpio/gpio-zynq.yaml
> @@ -11,7 +11,11 @@ maintainers:
>
> properties:
> compatible:
> - const: xlnx,zynq-gpio-1.0
> + enum:
> + - xlnx,zynq-gpio-1.0
> + - xlnx,zynqmp-gpio-1.0
> + - xlnx,versal-gpio-1.0
> + - xlnx,pmc-gpio-1.0
>
> reg:
> maxItems: 1
> --
> 2.33.1
>
Applied.
M
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
^ permalink raw reply [flat|nested] 6+ messages in thread