From: Jeff Mahoney <jeffm@suse.com>
To: Michael Brunnbauer <brunni@netestate.de>, Jan Kara <jack@suse.cz>
Cc: Randy Dunlap <rdunlap@infradead.org>,
linux-kernel@vger.kernel.org, reiserfs-devel@vger.kernel.org
Subject: Re: reiserfs broke between 4.9.205 and 4.9.208
Date: Wed, 15 Jan 2020 12:39:30 -0500 [thread overview]
Message-ID: <72d4425c-a3a3-4369-fe19-b5673d73a02a@suse.com> (raw)
In-Reply-To: <67c8665a-25a4-72d1-7632-d2b84eb362fe@suse.com>
[-- Attachment #1.1: Type: text/plain, Size: 1452 bytes --]
Nevermind. I just wasn't reproducing properly. Jan's analysis is
right. The -EOPNOTSUPP change is required so that we get the right
error when explicit xattr operations are performed on a file system
without them. Prior to this change, we'd get -EOPNOTSUPP by sb->s_xattr
being NULL.
reiserfs_for_each_xattr needs to handle this the same way we already
handle -ENODATA.
-Jeff
On 1/15/20 12:03 PM, Jeff Mahoney wrote:
> Hi Michael -
>
> It looks like something must've gone sideways with the backport since
> 5.5-rc6 works as expected. I'll dig into it a bit.
>
> -Jeff
>
> On 1/14/20 3:21 PM, Michael Brunnbauer wrote:
>>
>> hi all,
>>
>> is this been looked into? Do you need more information?
>>
>> Regards,
>>
>> Michael Brunnbauer
>>
>> On Thu, Jan 09, 2020 at 01:30:41PM +0100, Michael Brunnbauer wrote:
>>>
>>> Hello Jan,
>>>
>>> On Thu, Jan 09, 2020 at 01:12:16PM +0100, Jan Kara wrote:
>>>> Also Michael, I'd like to clarify: Does 'cp -a' return any error or is it
>>>> just that the kernel is spewing these annoying warnings? Because from the
>>>> code reading I'd think that it is only the kernel spewing errors but
>>>> userspace should be fine...
>>>
>>> Yes, 'cp -a' returns errors and files are owned by root instead of the correct
>>> user after copying as root.
>>>
>>> Regards,
>>>
>>> Michael Brunnbauer
>
>
--
Jeff Mahoney
Director, SUSE Labs Data & Performance
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2020-01-15 17:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-08 19:36 reiserfs broke between 4.9.205 and 4.9.208 Michael Brunnbauer
2020-01-08 23:42 ` Randy Dunlap
2020-01-09 12:12 ` Jan Kara
2020-01-09 12:30 ` Michael Brunnbauer
2020-01-14 20:21 ` Michael Brunnbauer
2020-01-15 17:03 ` Jeff Mahoney
2020-01-15 17:39 ` Jeff Mahoney [this message]
2020-01-15 18:02 ` Jeff Mahoney
2020-01-20 15:03 Byron Stanoszek
2020-01-20 16:20 ` Jeff Mahoney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=72d4425c-a3a3-4369-fe19-b5673d73a02a@suse.com \
--to=jeffm@suse.com \
--cc=brunni@netestate.de \
--cc=jack@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
--cc=reiserfs-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).