From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752530AbdJSJ07 (ORCPT ); Thu, 19 Oct 2017 05:26:59 -0400 Received: from mx2.suse.de ([195.135.220.15]:60749 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751607AbdJSJ05 (ORCPT ); Thu, 19 Oct 2017 05:26:57 -0400 Subject: Re: [PATCH 6/8] mm: Remove cold parameter for release_pages To: Mel Gorman , Andrew Morton Cc: Linux-MM , Linux-FSDevel , LKML , Jan Kara , Andi Kleen , Dave Hansen , Dave Chinner References: <20171018075952.10627-1-mgorman@techsingularity.net> <20171018075952.10627-7-mgorman@techsingularity.net> From: Vlastimil Babka Message-ID: <72f644cf-f891-e3a6-98ed-ed3a25c44ce2@suse.cz> Date: Thu, 19 Oct 2017 11:26:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171018075952.10627-7-mgorman@techsingularity.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/18/2017 09:59 AM, Mel Gorman wrote: > All callers of release_pages claim the pages being released are cache hot. > As no one cares about the hotness of pages being released to the allocator, > just ditch the parameter. > > No performance impact is expected as the overhead is marginal. The parameter > is removed simply because it is a bit stupid to have a useless parameter > copied everywhere. > > Signed-off-by: Mel Gorman Acked-by: Vlastimil Babka