From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755339Ab2EHOBI (ORCPT ); Tue, 8 May 2012 10:01:08 -0400 Received: from rcsinet15.oracle.com ([148.87.113.117]:48062 "EHLO rcsinet15.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754294Ab2EHOBH convert rfc822-to-8bit (ORCPT ); Tue, 8 May 2012 10:01:07 -0400 MIME-Version: 1.0 Message-ID: <731b6638-8c8c-4381-a00f-4ecd5a0e91ae@default> Date: Tue, 8 May 2012 07:00:11 -0700 (PDT) From: Dan Magenheimer To: Minchan Kim , Nitin Gupta Cc: Pekka Enberg , Greg Kroah-Hartman , Seth Jennings , Andrew Morton , linux-kernel@vger.kernel.org, linux-mm@kvack.org, cl@linux-foundation.org Subject: RE: [PATCH 4/4] zsmalloc: zsmalloc: align cache line size References: <1336027242-372-1-git-send-email-minchan@kernel.org> <1336027242-372-4-git-send-email-minchan@kernel.org> <4FA28EFD.5070002@vflare.org> <4FA33E89.6080206@kernel.org> <4FA7C2BC.2090400@vflare.org> <4FA87837.3050208@kernel.org> In-Reply-To: <4FA87837.3050208@kernel.org> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.6 (510070) [OL 12.0.6607.1000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > From: Minchan Kim [mailto:minchan@kernel.org] > > zcache can potentially create a lot of pools, so the latter will save > > some memory. > > > Dumb question. > Why should we create pool per user? > What's the problem if there is only one pool in system? zcache doesn't use zsmalloc for cleancache pages today, but that's Seth's plan for the future. Then if there is a separate pool for each cleancache pool, when a filesystem is umount'ed, it isn't necessary to walk through and delete all pages one-by-one, which could take quite awhile. ramster needs one pool for each client (i.e. machine in the cluster) for frontswap pages for the same reason, and later, for cleancache pages, one per mounted filesystem per client