From: Oleksandr Natalenko <oleksandr@natalenko.name>
To: kai.heng.feng@canonical.com
Cc: arnd@arndb.de, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
stern@rowland.harvard.edu, ulf.hansson@linaro.org
Subject: Re: [PATCH 0/4 v5] Keep rtsx_usb suspended when there's no card
Date: Sat, 27 Oct 2018 15:13:16 +0200 [thread overview]
Message-ID: <73221b3a7e85c9b68776e3eb257eed6a@natalenko.name> (raw)
In-Reply-To: <20181024084958.4627-1-kai.heng.feng@canonical.com>
Hi.
> This is based on Ulf's work [1] [2].
>
> This patch series can keep rtsx_usb suspended, to save ~0.5W on Intel
> platforms and ~1.5W on AMD platforms.
>
> [1] https://patchwork.kernel.org/patch/10440583/
> [2] https://patchwork.kernel.org/patch/10445725/
>
> Kai-Heng Feng (4):
> misc: rtsx_usb: Use USB remote wakeup signaling for card insertion
> detection
> memstick: Prevent memstick host from getting runtime suspended during
> card detection
> memstick: rtsx_usb_ms: Use ms_dev() helper
> memstick: rtsx_usb_ms: Support runtime power management
>
> v5: Corretly use system suspend/resume and runtime suspend/resume
> callback.
> Prevent runtime callbacks get call during system suspend.
>
> v4: Use pm_runtime_put() in memstick_check().
>
> v3: Skip parent device check in rtsx_usb_resume_child().
> Remove dev_dbg() if it only prints function name.
> Use ms_dev() helper at more places.
> Remove const qualifier for UNIVERSAL_DEV_PM_OPS.
>
> v2: Resend to linux-usb and LKML.
>
> drivers/memstick/core/memstick.c | 4 +
> drivers/memstick/host/rtsx_usb_ms.c | 173 +++++++++++++++++-----------
> drivers/misc/cardreader/rtsx_usb.c | 8 ++
> 3 files changed, 117 insertions(+), 68 deletions(-)
>
> --
> 2.17.1
Feel free to add again:
Tested-by: Oleksandr Natalenko <oleksandr@natalenko.name>
since it works fine with:
Bus 001 Device 004: ID 0bda:0129 Realtek Semiconductor Corp. RTS5129
Card Reader Controller
--
Oleksandr Natalenko (post-factum)
prev parent reply other threads:[~2018-10-27 13:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-24 8:49 [PATCH 0/4 v5] Keep rtsx_usb suspended when there's no card Kai-Heng Feng
2018-10-24 8:49 ` [PATCH 1/4 v5] misc: rtsx_usb: Use USB remote wakeup signaling for card insertion detection Kai-Heng Feng
2018-10-24 8:49 ` [PATCH 2/4 v5] memstick: Prevent memstick host from getting runtime suspended during card detection Kai-Heng Feng
2018-10-29 12:25 ` Ulf Hansson
2018-10-29 16:31 ` Kai Heng Feng
2018-10-30 13:03 ` Ulf Hansson
2018-10-30 15:23 ` Kai Heng Feng
2018-10-30 16:04 ` Ulf Hansson
2018-10-31 6:33 ` Kai Heng Feng
2018-10-24 8:49 ` [PATCH 3/4 v5] memstick: rtsx_usb_ms: Use ms_dev() helper Kai-Heng Feng
2018-10-24 8:49 ` [PATCH 4/4 v5] memstick: rtsx_usb_ms: Support runtime power management Kai-Heng Feng
2018-10-27 13:13 ` Oleksandr Natalenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73221b3a7e85c9b68776e3eb257eed6a@natalenko.name \
--to=oleksandr@natalenko.name \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).