From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 110DBC433DB for ; Thu, 28 Jan 2021 17:51:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C22C564E15 for ; Thu, 28 Jan 2021 17:51:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231450AbhA1Ru6 (ORCPT ); Thu, 28 Jan 2021 12:50:58 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:58874 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232130AbhA1RsJ (ORCPT ); Thu, 28 Jan 2021 12:48:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611856003; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LC0E1GpRXLDOlCRnDuGLRoZ/gZ1WsR+3WhMw6k9lWck=; b=BdYvzoUTOSn0qhDohoY0x8/Tt6CVZBKBIE1D7IyVo32WEiTorKWUAV8PpgdO9fs7DbsKeP 50KswuQV34/JU4I+lKFFYdIDN20NQ0NBlxO8dzect2P7RYUonnAyhUvS56oeyMcymoa/F5 ZqxY/kRaV7NXmOG1zQOUuEh/EygFdM0= Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-4-Uq0GbW3bOiWC9CR41NwNAg-1; Thu, 28 Jan 2021 12:46:41 -0500 X-MC-Unique: Uq0GbW3bOiWC9CR41NwNAg-1 Received: by mail-ej1-f70.google.com with SMTP id x22so2522670ejb.10 for ; Thu, 28 Jan 2021 09:46:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=LC0E1GpRXLDOlCRnDuGLRoZ/gZ1WsR+3WhMw6k9lWck=; b=oVDFQ4zqaxD1qxKbOsJD9OCzj8Ej4B7vhT2qjhCm2wvzOTg4LDkswIkj5qOFnTAyuM snLSGsw8W9RIbB+vfPhYSqG1Cy7POXePJcXo1RGf6uWLXuer3viQWeGzu9I1Bz2aPdJo Zx/cwQ+lCnkYEiuWpF87WqvLzhtFvgcEM2p3cG5BqkUsErpbUlJFnAIODFNSiJkwl2LA ezdpk0bb8T3ncPq3wZQNXIvI6S5/FF0t4F8O3ZJZlUHtXrKwCKyjylAp20NZVhz8An5N 0fXGpcV3jF+VnEBzUsoPPRyFDTZatNX+jzt3cTirZxkQ+mQqkHgQrVV71gpqbwnwhenj bvdQ== X-Gm-Message-State: AOAM533XjAMJmgm+mMwAblPjyYlJ/XT4l60GpYwroib01PTW1jIMOm/W VoQTP/T0NKTXPpE8596Te5KB+tw+bGh75INdNb3d2nKiw94EgkAnfpgyhsb7cZCshupJ8+z2kuB Qjo5w2RB+cZVQjRnYL5vePFtN X-Received: by 2002:a17:906:828a:: with SMTP id h10mr561811ejx.274.1611856000011; Thu, 28 Jan 2021 09:46:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJx24S50DQWrrL/lhjofPmbZeVFy27BpQwBeKPaYtvSBcFcfEwdtL6gv9LpQbFpeocwr5Fnq5g== X-Received: by 2002:a17:906:828a:: with SMTP id h10mr561795ejx.274.1611855999798; Thu, 28 Jan 2021 09:46:39 -0800 (PST) Received: from ?IPv6:2001:b07:6468:f312:c8dd:75d4:99ab:290a? ([2001:b07:6468:f312:c8dd:75d4:99ab:290a]) by smtp.gmail.com with ESMTPSA id z13sm3322394edc.73.2021.01.28.09.46.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Jan 2021 09:46:38 -0800 (PST) Subject: Re: [PATCH v14 09/13] KVM: x86: Report CET MSRs as to-be-saved if CET is supported To: Yang Weijiang , kvm@vger.kernel.org, linux-kernel@vger.kernel.org, sean.j.christopherson@intel.com, jmattson@google.com Cc: yu.c.zhang@linux.intel.com References: <20201106011637.14289-1-weijiang.yang@intel.com> <20201106011637.14289-10-weijiang.yang@intel.com> From: Paolo Bonzini Message-ID: <732d1da2-70d7-1f8a-b41d-136e068516d7@redhat.com> Date: Thu, 28 Jan 2021 18:46:37 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: <20201106011637.14289-10-weijiang.yang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/11/20 02:16, Yang Weijiang wrote: > Report all CET MSRs, including the synthetic GUEST_SSP MSR, as > to-be-saved, e.g. for migration, if CET is supported by KVM. > > Co-developed-by: Sean Christopherson > Signed-off-by: Sean Christopherson > Signed-off-by: Yang Weijiang > --- > arch/x86/kvm/x86.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/arch/x86/kvm/x86.c b/arch/x86/kvm/x86.c > index 751b62e871e5..d573cadf5baf 100644 > --- a/arch/x86/kvm/x86.c > +++ b/arch/x86/kvm/x86.c > @@ -1248,6 +1248,8 @@ static const u32 msrs_to_save_all[] = { > MSR_ARCH_PERFMON_EVENTSEL0 + 16, MSR_ARCH_PERFMON_EVENTSEL0 + 17, > > MSR_IA32_XSS, > + MSR_IA32_U_CET, MSR_IA32_S_CET, MSR_IA32_INT_SSP_TAB, MSR_KVM_GUEST_SSP, > + MSR_IA32_PL0_SSP, MSR_IA32_PL1_SSP, MSR_IA32_PL2_SSP, MSR_IA32_PL3_SSP, > }; > > static u32 msrs_to_save[ARRAY_SIZE(msrs_to_save_all)]; > @@ -5761,6 +5763,13 @@ static void kvm_init_msr_list(void) > if (!supported_xss) > continue; > break; > + case MSR_IA32_U_CET: > + case MSR_IA32_S_CET: > + case MSR_IA32_INT_SSP_TAB: > + case MSR_IA32_PL0_SSP ... MSR_IA32_PL3_SSP: > + if (!kvm_cet_supported()) > + continue; > + break; > default: > break; > } > Missing "case MSR_KVM_GUEST_SSP". Paolo