From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Mikhail Zhilkin <csharper2005@gmail.com>,
Miquel Raynal <miquel.raynal@bootlin.com>,
Richard Weinberger <richard@nod.at>,
Vignesh Raghavendra <vigneshr@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: NOGUCHI Hiroshi <drvlabo@gmail.com>, Karim <Karimdplay@gmail.com>,
M <x1@disroot.org>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: mtd: partitions: Add binding for Sercomm parser
Date: Sun, 10 Apr 2022 10:14:46 +0200 [thread overview]
Message-ID: <73607ee6-a6bc-1f18-1dc1-d3e916f0e8ae@linaro.org> (raw)
In-Reply-To: <1b391399-984b-7a63-3265-62ef09caec39@gmail.com>
On 09/04/2022 20:04, Mikhail Zhilkin wrote:
> On 4/9/2022 3:43 PM, Krzysztof Kozlowski wrote:
>
>>> I'm not sure that "scpart-id" is necessary here. "sercomm,sc-partitions"
>>> is necessary. I'm going to add vendor prefix in a separate patch. Is this
>>> ok?
>> Yes.
>
> Thanks!
>
>>>>> +required:
>>>>> + - compatible
>>>> Missing reg.
>>> reg isn't required. Parser can read partition offsets and sizes from
>>> SC PART MAP table. Or do you mean something else? All is ok
>>> without reg definition in "Example" (except the warns that reg property
>>> is missing).
>> reg might not be required for current implementation but it is required
>> by devicetree for every node with unit address. Do you expect here nodes
>> without unit addresses?
> Only "partitions" node has no unit address.
This confused me. Do you have a child node named "partitions"?
> All subnodes have unit
> addresses and therefore have to have reg property.
So all of them need reg.
> I've just realized
> that "fixed-partitions.yaml" is almost my case. It looks like I can
> copy'n'paste "required" and "*properties".
> Do you mind if I don't reinvent the wheel and reuse this good
> practice?
Re-using proper stuff is good, but just don't blindly copy. You need
still compatible and reg in required properties.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-04-10 8:15 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-06 19:55 [PATCH v2 0/2] dt-bindings: mtd: partitions: Add binding for Sercomm parser Mikhail Zhilkin
2022-04-06 19:59 ` [PATCH v2 1/2] " Mikhail Zhilkin
2022-04-07 7:48 ` Krzysztof Kozlowski
2022-04-09 12:26 ` Mikhail Zhilkin
2022-04-09 12:43 ` Krzysztof Kozlowski
2022-04-09 18:04 ` Mikhail Zhilkin
2022-04-09 18:17 ` Mikhail Zhilkin
2022-04-10 8:18 ` Krzysztof Kozlowski
2022-04-28 15:24 ` Mikhail Zhilkin
2022-04-29 6:46 ` Krzysztof Kozlowski
2022-04-29 15:26 ` Mikhail Zhilkin
2022-04-29 20:22 ` Krzysztof Kozlowski
2022-04-30 8:04 ` Mikhail Zhilkin
2022-04-30 14:35 ` Krzysztof Kozlowski
2022-04-30 18:54 ` Mikhail Zhilkin
2022-05-01 8:17 ` Krzysztof Kozlowski
2022-05-01 14:51 ` Mikhail Zhilkin
2022-05-01 16:17 ` Krzysztof Kozlowski
2022-05-02 5:42 ` Mikhail Zhilkin
2022-04-10 8:14 ` Krzysztof Kozlowski [this message]
2022-04-07 13:50 ` Rob Herring
2022-04-09 12:35 ` Mikhail Zhilkin
2022-04-09 12:49 ` Krzysztof Kozlowski
2022-04-10 6:54 ` Mikhail Zhilkin
2022-04-06 20:00 ` [PATCH v2 2/2] mtd: parsers: add support for Sercomm partitions Mikhail Zhilkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73607ee6-a6bc-1f18-1dc1-d3e916f0e8ae@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=Karimdplay@gmail.com \
--cc=csharper2005@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=drvlabo@gmail.com \
--cc=krzk+dt@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=x1@disroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).