Re: [PATCH v7] usb: common: usb-conn-gpio: Set last role to unknown before initial detection

From: Prashanth K <quic_prashk@quicinc.com>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	AngeloGioacchino Del Regno 
	<angelogioacchino.delregno@collabora.com>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v7] usb: common: usb-conn-gpio: Set last role to unknown before initial detection
Date: Wed, 14 Jun 2023 09:55:10 +0530	[thread overview]
Message-ID: <73854744-03ef-2c5c-a5d6-284f004a5497@quicinc.com> (raw)
In-Reply-To: <ZIhOm5LKwn+YVGzT@kuha.fi.intel.com>


On 13-06-23 04:40 pm, Heikki Krogerus wrote:
> Hi,
> 
> On Wed, May 31, 2023 at 08:11:14PM +0530, Prashanth K wrote:
>> Currently if we bootup a device without cable connected, then
>> usb-conn-gpio won't call set_role() since last_role is same as
>> current role. This happens because during probe last_role gets
>> initialised to zero.
>>
>> To avoid this, added a new constant in enum usb_role, last_role
>> is set to USB_ROLE_UNKNOWN before performing initial detection.
> 
> So why can't you fix this by just always setting the role
> unconditionally to USB_ROLE_NONE in your probe function before the
> initial detection?
> 
Hi Heikki, thats exactly what we are doing here.

+	/* Set last role to unknown before performing the initial detection */
+	info->last_role = USB_ROLE_UNKNOWN;
+
  	/* Perform initial detection */
  	usb_conn_queue_dwork(info, 0);

Thanks,
Prashanth K