From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 877ABC35240 for ; Fri, 31 Jan 2020 11:54:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 647E322522 for ; Fri, 31 Jan 2020 11:54:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728501AbgAaLyM (ORCPT ); Fri, 31 Jan 2020 06:54:12 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:55706 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728423AbgAaLyM (ORCPT ); Fri, 31 Jan 2020 06:54:12 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id 27B9E28A964 Message-ID: <739f60a89646cc92f26e34523cbe8aaab5697351.camel@collabora.com> Subject: Re: [PATCH v4 5/6] media: rkvdec: Add the rkvdec driver From: Ezequiel Garcia To: Boris Brezillon Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Laurent Pinchart , Rob Herring , Tomasz Figa , Nicolas Dufresne , kernel@collabora.com, Paul Kocialkowski , Jonas Karlman , Heiko Stuebner , Sakari Ailus , Hans Verkuil Date: Fri, 31 Jan 2020 08:53:47 -0300 In-Reply-To: <20200130171249.3ae0444a@collabora.com> References: <20200129195501.8317-1-ezequiel@collabora.com> <20200129195501.8317-6-ezequiel@collabora.com> <20200130171249.3ae0444a@collabora.com> Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2020-01-30 at 17:12 +0100, Boris Brezillon wrote: > On Wed, 29 Jan 2020 16:55:00 -0300 > Ezequiel Garcia wrote: > > > From: Boris Brezillon > > > > The rockchip vdec block is a stateless decoder that's able to decode > > H264, HEVC and VP9 content. This commit adds the core infrastructure > > and the H264 backend. Support for VP9 and HEVS will be added later on. > > > > Signed-off-by: Boris Brezillon > > Signed-off-by: Ezequiel Garcia > > --- > > v4: > > * Make poc tables const, as suggested by Hans > > * Move buffer extra space calculation TRY_FMT, as done on Hantro. > > * Get rid of vb2_request_get_buf and open-code > > following Cedrus. We can move it to a helper as a follow-up patch. > > Well, we know what that means in practice :-). > Well, not necesarily. I think we can expect a helper soon, but it doesn't have to be part of this series :-) And perhaps we can find another way to link a media request to a vb2 queue, so we don't have to iterate over objects like we are doing now? > > new file mode 100644 > > index 000000000000..1293b3621364 > > --- /dev/null > > +++ b/drivers/staging/media/rkvdec/rkvdec-regs.h > > @@ -0,0 +1,239 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Rockchip VPU codec driver > > + * > > + * Copyright (C) 2015 Rockchip Electronics Co., Ltd. > > + * Jung Zhao > > + * Alpha Lin > > + * > > + * This software is licensed under the terms of the GNU General Public > > + * License version 2, as published by the Free Software Foundation, and > > + * may be copied, distributed, and modified under those terms. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + */ > > Oops, looks like I forgot to remove the license text here. Also not > entirely sure the copyrights are correct (might be a copy from the > hantro driver instead of the rkvdec one). > Right. > > > diff --git a/drivers/staging/media/rkvdec/rkvdec.h b/drivers/staging/media/rkvdec/rkvdec.h > > new file mode 100644 > > index 000000000000..529ef86510d3 > > --- /dev/null > > +++ b/drivers/staging/media/rkvdec/rkvdec.h > > @@ -0,0 +1,124 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +/* > > + * Hantro VPU codec driver > > + * > > + * Copyright 2018 Google LLC. > > + * Tomasz Figa > > + * > > + * Based on s5p-mfc driver by Samsung Electronics Co., Ltd. > > + * Copyright (C) 2011 Samsung Electronics Co., Ltd. > > + */ > > This header has been copied from the hantro driver, so it's most likely > wrong. > Oh, I totally missed this. Thanks for reviewing! Ezequiel