From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 876F2C433E1 for ; Sun, 9 Aug 2020 17:41:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7267E206E9 for ; Sun, 9 Aug 2020 17:41:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726415AbgHIRlK (ORCPT ); Sun, 9 Aug 2020 13:41:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34546 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726175AbgHIRlJ (ORCPT ); Sun, 9 Aug 2020 13:41:09 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2DAFEC061756 for ; Sun, 9 Aug 2020 10:41:09 -0700 (PDT) Received: from gallifrey.ext.pengutronix.de ([2001:67c:670:201:5054:ff:fe8d:eefb] helo=[IPv6:::1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1k4pJh-00024Q-Fk; Sun, 09 Aug 2020 19:41:05 +0200 Subject: Re: [PATCH v7 3/3] ARM: dts: stm32: add initial support for stm32mp157-odyssey board To: Marcin Sloniewski , linux-arm-kernel@lists.infradead.org Cc: robh+dt@kernel.org, mcoquelin.stm32@gmail.com, alexandre.torgue@st.com, mani@kernel.org, sam@ravnborg.org, linus.walleij@linaro.org, arnd@arndb.de, broonie@kernel.org, lkundrak@v3.sk, daniel@0x0f.com, kuninori.morimoto.gx@renesas.com, allen.chen@ite.com.tw, robh@kernel.org, devicetree@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-kernel@vger.kernel.org References: <20200809164450.289731-1-marcin.sloniewski@gmail.com> <20200809164450.289731-3-marcin.sloniewski@gmail.com> From: Ahmad Fatoum Message-ID: <73c2439a-0250-4010-ad5d-601ac9f4b7df@pengutronix.de> Date: Sun, 9 Aug 2020 19:40:53 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 MIME-Version: 1.0 In-Reply-To: <20200809164450.289731-3-marcin.sloniewski@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-SA-Exim-Connect-IP: 2001:67c:670:201:5054:ff:fe8d:eefb X-SA-Exim-Mail-From: a.fatoum@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Marcin, On 8/9/20 6:44 PM, Marcin Sloniewski wrote: > Add support for Seeed Studio's stm32mp157c odyssey board. > Board consists of SoM with stm32mp157c with 4GB eMMC and 512 MB DDR3 RAM > and carrier board with USB and ETH interfaces, SD card connector, > wifi and BT chip AP6236. > > In this patch only basic kernel boot is supported and interfacing > SD card and on-board eMMC. > > Signed-off-by: Marcin Sloniewski Reviewed-by: Ahmad Fatoum > --- > + > +&rng1 { > + status = "okay"; > +}; I think we should put this into the SoC dtsi instead. Cheers Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |