From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752720AbcHUJqB (ORCPT ); Sun, 21 Aug 2016 05:46:01 -0400 Received: from mout.web.de ([212.227.17.12]:63681 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752029AbcHUJp7 (ORCPT ); Sun, 21 Aug 2016 05:45:59 -0400 Subject: [PATCH] staging/lustre/llite: Use memdup_user() rather than duplicating its implementation References: <566ABCD9.1060404@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Nicolas Palix To: lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org, Andreas Dilger , Fan Yong , Greg Kroah-Hartman , James Simmons , Oleg Drokin , wang di From: SF Markus Elfring Message-ID: <73da135c-be81-e915-9b7a-6773e730b4e7@users.sourceforge.net> Date: Sun, 21 Aug 2016 11:45:07 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2 MIME-Version: 1.0 In-Reply-To: <566ABCD9.1060404@users.sourceforge.net> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:i9eMTRzOlaIgbYsvTe7Eet2crzMrq4yJvlv8m+v7fK7G/erhXUp nUnyjj4lElyYo6w2oN253ysSkVwG98ZPI0udk9U5QO5bMS7PJ1m70Vt2XOacXdZP0WHj+hx NLqdpeJiuZKb/2FabYDUpBlc6LQN73ce0RnY6/0SJg7OYLKHkJCyOPc1KW7FCBKA1mnqPIy wskyDxcPI/ZHS4YRb5muw== X-UI-Out-Filterresults: notjunk:1;V01:K0:b0cBtLjanI8=:uiMKrurUac6FH+zdKHdyb3 4xEMTM803YSNtmoaZfBXVC9/bFv/IHm8clRCJw/RSvT8bn0xTC5qYCitM+2k3X/WzPcr7Quhk XpEX1BR8aE3OehHOoy2SyGn2gntk4md/ieS0MfClQLsFWvN2CYPwW/mBvR7thnh4uOMxnONYL LjEcw4Bf4StFYVn7v+q9d9T0295Wkac3ZDmW/YcbUHiwmAxRLnYSSHwmvVUvX/S/j/3NPq1pR 4fTDiGi8SouxpKQGA1OgRoVN8sjwARlLEbPmWKSFQP48ULvNmKgF/I58FFg0EvrJowOlJmwY6 enhLXbdPRl9aiYOd6CIlAahMZVelz5FohVLjwRO+PT8VVKmV4kiPaWATTrvyvOgdl1aA6BmK5 yRL1l+G43fk5BsnLdVUi3EiYhFDIHMESN/ZE+o89cGC9ySbKsQKKm6CelBrXtuFdbh4CYcm88 ltdoPEYmEFc8WcbPp9tRi72VOM5Kd2qthpNmnDxhM+PAjrT0033rVUmYoXbkKEe9KUgm0MoqP GIGIjb8d7DgbvZuRcSwC/wJ4t4P/q0teUu2VX2/nskNKKZGar329ePddoz9UbTLaVawedU6To X+J1HFYbPDNGHGALr1Zb7xZr6CeMMVVQz52RrzKfzTy/ZDjy9jgj8WalVGPQJXBToAdv/Y78m NaCUw6VdKG0XkmB8+bpbZ++/w2EtXMrGIAExnHt3mtlMelYfMyZ44xrp7M/YTofNAyR+A9FKG kn7XnNJ89x4x7p6ToOyrnjBlsv4i5eH9kUcFyInHel6B/XdLKf6+M+/7i9vBCJRihLaE5Ltj7 KSrrDkG Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sun, 21 Aug 2016 11:30:57 +0200 Reuse existing functionality from memdup_user() instead of keeping duplicate source code. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- drivers/staging/lustre/lustre/llite/dir.c | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/drivers/staging/lustre/lustre/llite/dir.c b/drivers/staging/lustre/lustre/llite/dir.c index 031c9e4..8b70e42 100644 --- a/drivers/staging/lustre/lustre/llite/dir.c +++ b/drivers/staging/lustre/lustre/llite/dir.c @@ -1676,14 +1676,9 @@ out_poll: case LL_IOC_QUOTACTL: { struct if_quotactl *qctl; - qctl = kzalloc(sizeof(*qctl), GFP_NOFS); - if (!qctl) - return -ENOMEM; - - if (copy_from_user(qctl, (void __user *)arg, sizeof(*qctl))) { - rc = -EFAULT; - goto out_quotactl; - } + qctl = memdup_user((void __user *)arg, sizeof(*qctl)); + if (IS_ERR(qctl)) + return PTR_ERR(qctl); rc = quotactl_ioctl(sbi, qctl); @@ -1691,7 +1686,6 @@ out_poll: sizeof(*qctl))) rc = -EFAULT; -out_quotactl: kfree(qctl); return rc; } -- 2.9.3