From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751713AbeBWQRO (ORCPT ); Fri, 23 Feb 2018 11:17:14 -0500 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:38102 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751391AbeBWQRM (ORCPT ); Fri, 23 Feb 2018 11:17:12 -0500 Subject: Re: [PATCH v2 1/2] irqchip: stm32: Optimizes and cleans up stm32-exti irq_domain From: Ludovic BARRE To: Radoslaw Pietrzyk , Thomas Gleixner , Jason Cooper , Marc Zyngier , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Benjamin Gaignard , Philipp Zabel , , , References: <1519221027-4028-1-git-send-email-radoslaw.pietrzyk@gmail.com> <6491f248c6748f21a2acf310e186d2be4f9b4e4c.1519374248.git.radoslaw.pietrzyk@gmail.com> Message-ID: <73fbc744-872a-8a69-8bf4-a46d7f5b6636@st.com> Date: Fri, 23 Feb 2018 17:16:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.75.127.50] X-ClientProxiedBy: SFHDAG7NODE2.st.com (10.75.127.20) To SFHDAG6NODE1.st.com (10.75.127.16) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2018-02-23_06:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 02/23/2018 04:46 PM, Ludovic BARRE wrote: > hi Radoslaw > > The gpio-keys tests it's now functional on H7, great. > However the gpio-key test only the bank1 (like stm32f429). > Like the H7 introduce the multi-bank management, > we must perform complementary test. > > comment below about ack in handler > > On 02/23/2018 09:31 AM, Radoslaw Pietrzyk wrote: >> - discards setting handle_simple_irq handler for hierarchy interrupts >> - removes acking in chained irq handler as this is done by >> irq_chip itself inside handle_edge_irq >> - removes unneeded irq_domain_ops.xlate callback >> >> Signed-off-by: Radoslaw Pietrzyk >> --- >>   drivers/irqchip/irq-stm32-exti.c | 13 ------------- >>   1 file changed, 13 deletions(-) >> >> diff --git a/drivers/irqchip/irq-stm32-exti.c >> b/drivers/irqchip/irq-stm32-exti.c >> index 36f0fbe..8013a87 100644 >> --- a/drivers/irqchip/irq-stm32-exti.c >> +++ b/drivers/irqchip/irq-stm32-exti.c >> @@ -79,13 +79,6 @@ static unsigned long stm32_exti_pending(struct >> irq_chip_generic *gc) >>       return irq_reg_readl(gc, stm32_bank->pr_ofst); >>   } >> -static void stm32_exti_irq_ack(struct irq_chip_generic *gc, u32 mask) >> -{ >> -    const struct stm32_exti_bank *stm32_bank = gc->private; >> - >> -    irq_reg_writel(gc, mask, stm32_bank->pr_ofst); >> -} >> - >>   static void stm32_irq_handler(struct irq_desc *desc) >>   { >>       struct irq_domain *domain = irq_desc_get_handler_data(desc); >> @@ -106,7 +99,6 @@ static void stm32_irq_handler(struct irq_desc *desc) >>               for_each_set_bit(n, &pending, IRQS_PER_BANK) { >>                   virq = irq_find_mapping(domain, irq_base + n); >>                   generic_handle_irq(virq); >> -                stm32_exti_irq_ack(gc, BIT(n)); > > the while loop " while ((pending = " has been introduce while original > upstream of this driver in V2 to V3 > https://patchwork.ozlabs.org/patch/604190/ > https://patchwork.ozlabs.org/patch/665242/ > > the "ack" is needed to acknowledge the irq which are handled and which > is not the original irq for which we enter. > >>               } >>           } >>       } >> @@ -176,16 +168,12 @@ static int stm32_irq_set_wake(struct irq_data >> *data, unsigned int on) >>   static int stm32_exti_alloc(struct irq_domain *d, unsigned int virq, >>                   unsigned int nr_irqs, void *data) >>   { >> -    struct irq_chip_generic *gc; >>       struct irq_fwspec *fwspec = data; >>       irq_hw_number_t hwirq; >>       hwirq = fwspec->param[0]; >> -    gc = irq_get_domain_generic_chip(d, hwirq); >>       irq_map_generic_chip(d, virq, hwirq); >> -    irq_domain_set_info(d, virq, hwirq, &gc->chip_types->chip, gc, >> -                handle_simple_irq, NULL, NULL); > > I see if it is not disturb the multi-bank. you are right, normally irq_domain_set_info is already set in irq_map_generic_chip. > >>       return 0; >>   } >> @@ -200,7 +188,6 @@ static void stm32_exti_free(struct irq_domain *d, >> unsigned int virq, >>   struct irq_domain_ops irq_exti_domain_ops = { >>       .map    = irq_map_generic_chip, >> -    .xlate    = irq_domain_xlate_onetwocell, >>       .alloc  = stm32_exti_alloc, >>       .free    = stm32_exti_free, >>   }; >> > > BR > Ludo