From: Joe Perches <joe@perches.com>
To: Jonathan Corbet <corbet@lwn.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Dave Hansen <dave.hansen@intel.com>,
Mike Galbraith <efault@gmx.de>,
Guenter Roeck <linux@roeck-us.net>,
Rik van Riel <riel@surriel.com>,
Kees Cook <keescook@chromium.org>,
Nick Desaulniers <ndesaulniers@google.com>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH] Raise the minimum required gcc version to 4.6
Date: Mon, 20 Aug 2018 13:48:17 -0700 [thread overview]
Message-ID: <744af111abe22c4dfda58b4a0759609bcd2eb8f2.camel@perches.com> (raw)
In-Reply-To: <20180820144206.4e42c9fc@lwn.net>
On Mon, 2018-08-20 at 14:42 -0600, Jonathan Corbet wrote:
> On Mon, 20 Aug 2018 13:15:26 -0700
> Joe Perches <joe@perches.com> wrote:
>
> > +#if GCC_VERSION < 40600
> > +# error Sorry, your compiler is too old - please upgrade it.
> > +#endif
>
> It seems we could be a little friendlier here? "Kernel compilation
> requires GCC >= v4.6, please upgrade" ?
This is unchanged text, it's just moved around, but sure, trivial...
Wordsmithing should likely be a separate patch though.
---
include/linux/compiler-gcc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/compiler-gcc.h b/include/linux/compiler-gcc.h
index 250b9b7cfd60..5d95cabd13b3 100644
--- a/include/linux/compiler-gcc.h
+++ b/include/linux/compiler-gcc.h
@@ -11,7 +11,7 @@
+ __GNUC_PATCHLEVEL__)
#if GCC_VERSION < 40600
-# error Sorry, your compiler is too old - please upgrade it.
+# error Kernel compilation requires GCC >= v4.6, please upgrade your compiler
#endif
/* Optimization barrier */
next prev parent reply other threads:[~2018-08-20 20:48 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-20 20:15 [PATCH] Raise the minimum required gcc version to 4.6 Joe Perches
2018-08-20 20:25 ` Nick Desaulniers
2018-08-20 20:42 ` Jonathan Corbet
2018-08-20 20:48 ` Joe Perches [this message]
2018-08-21 6:55 ` Masahiro Yamada
2018-08-21 19:40 ` Linus Torvalds
2018-08-21 23:41 ` Nick Desaulniers
2018-08-23 21:52 ` Geert Uytterhoeven
2018-08-23 22:00 ` Nick Desaulniers
2018-08-23 22:00 ` Joe Perches
2018-12-29 14:25 ` Geert Uytterhoeven
2018-12-29 21:57 ` Arnd Bergmann
2019-01-08 14:09 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=744af111abe22c4dfda58b4a0759609bcd2eb8f2.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=corbet@lwn.net \
--cc=dave.hansen@intel.com \
--cc=efault@gmx.de \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=ndesaulniers@google.com \
--cc=riel@surriel.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).