From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B72E7C432BE for ; Sun, 8 Aug 2021 10:08:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9226B61028 for ; Sun, 8 Aug 2021 10:08:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231204AbhHHKC7 (ORCPT ); Sun, 8 Aug 2021 06:02:59 -0400 Received: from smtprelay0193.hostedemail.com ([216.40.44.193]:60260 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S230354AbhHHKC6 (ORCPT ); Sun, 8 Aug 2021 06:02:58 -0400 Received: from omf16.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60]) by smtprelay07.hostedemail.com (Postfix) with ESMTP id C386D181D3025; Sun, 8 Aug 2021 10:02:38 +0000 (UTC) Received: from [HIDDEN] (Authenticated sender: joe@perches.com) by omf16.hostedemail.com (Postfix) with ESMTPA id 86E95255108; Sun, 8 Aug 2021 10:02:37 +0000 (UTC) Message-ID: <745ab8a85430ad4268a86b0957aa690c1a7a6d0f.camel@perches.com> Subject: Re: [PATCH net-next 2/2] bonding: combine netlink and console error messages From: Joe Perches To: Jonathan Toppins , netdev@vger.kernel.org Cc: Jay Vosburgh , Veaceslav Falico , Andy Gospodarek , "David S. Miller" , Jakub Kicinski , linux-kernel@vger.kernel.org Date: Sun, 08 Aug 2021 03:02:35 -0700 In-Reply-To: References: <37c7bbbb01ede99974fc9ce3c3f5dad4845df9ee.camel@perches.com> Content-Type: text/plain; charset="ISO-8859-1" User-Agent: Evolution 3.40.0-1 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspamout04 X-Rspamd-Queue-Id: 86E95255108 X-Stat-Signature: xp76j3p7soenw57a8bias8zr65oqfbqa X-Session-Marker: 6A6F6540706572636865732E636F6D X-Session-ID: U2FsdGVkX18sWdJ0gR/negchCb2xjZXqr9B6PKsIgFM= X-HE-Tag: 1628416957-534976 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, 2021-08-07 at 17:54 -0400, Jonathan Toppins wrote: > On 8/6/21 11:52 PM, Joe Perches wrote: > > On Fri, 2021-08-06 at 23:30 -0400, Jonathan Toppins wrote: > > > There seems to be no reason to have different error messages between > > > netlink and printk. It also cleans up the function slightly. > > [] > > > diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c > > [] > > > +#define BOND_NL_ERR(bond_dev, extack, errmsg) do { \ > > > + NL_SET_ERR_MSG(extack, errmsg); \ > > > + netdev_err(bond_dev, "Error: " errmsg "\n"); \ > > > +} while (0) > > > + > > > +#define SLAVE_NL_ERR(bond_dev, slave_dev, extack, errmsg) do { \ > > > + NL_SET_ERR_MSG(extack, errmsg); \ > > > + slave_err(bond_dev, slave_dev, "Error: " errmsg "\n"); \ > > > +} while (0) > > > > If you are doing this, it's probably smaller object code to use > > "%s", errmsg > > as the errmsg string can be reused > > > > #define BOND_NL_ERR(bond_dev, extack, errmsg) \ > > do { \ > > NL_SET_ERR_MSG(extack, errmsg); \ > > netdev_err(bond_dev, "Error: %s\n", errmsg); \ > > } while (0) > > > > #define SLAVE_NL_ERR(bond_dev, slave_dev, extack, errmsg) \ > > do { \ > > NL_SET_ERR_MSG(extack, errmsg); \ > > slave_err(bond_dev, slave_dev, "Error: %s\n", errmsg); \ > > } while (0) > > > > > > I like the thought and would agree if not for how NL_SET_ERR_MSG is > coded. Unfortunately it does not appear as though doing the above change > actually generates smaller object code. Maybe I have incorrectly > interpreted something? No, it's because you are compiling allyesconfig or equivalent. Try defconfig with bonding.