From: Heiko Stuebner <heiko@sntech.de>
To: Eddie Cai <eddie.cai.linux@gmail.com>
Cc: robh+dt@kernel.org, mark.rutland@arm.com, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: rockchip: reuse firefly dtsi
Date: Wed, 19 Apr 2017 00:20:32 +0200 [thread overview]
Message-ID: <746291609.ssvjv54Vin@phil> (raw)
In-Reply-To: <20170418121527.3155-1-eddie.cai.linux@gmail.com>
Hi Eddie,
Am Dienstag, 18. April 2017, 20:15:27 CEST schrieb Eddie Cai:
> firefly reload is very similar with firefly board, so reuse firefly dtsi
>
> Signed-off-by: Eddie Cai <eddie.cai.linux@gmail.com>
> ---
> arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 310 ------------------
> arch/arm/boot/dts/rk3288-firefly-reload.dts | 368 ++--------------------
I would disagree and remember having a similar discussion when the reload-
support was initially submitted. Please keep in mind that the firefly-
reload is a som+baseboard combination, so somebody could (or maybe
already has) create a completely different baseboard for the som that
does not have any similarities with the original firefly.
The previous firefly being a real single board.
We also don't combine rock2 and firefly and other boards following the
general rk3288 design guidelines :-) and the original firefly and reload are
very different boards if you look at them.
Heiko
next prev parent reply other threads:[~2017-04-18 22:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-18 12:15 [PATCH] ARM: dts: rockchip: reuse firefly dtsi Eddie Cai
2017-04-18 22:20 ` Heiko Stuebner [this message]
2017-04-19 0:42 ` Eddie Cai
2017-04-19 9:55 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=746291609.ssvjv54Vin@phil \
--to=heiko@sntech.de \
--cc=devicetree@vger.kernel.org \
--cc=eddie.cai.linux@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).