From: David Hildenbrand <david@redhat.com>
To: Michal Hocko <mhocko@suse.com>, Ohhoon Kwon <ohoono.kwon@samsung.com>
Cc: akpm@linux-foundation.org, bhe@redhat.com, rppt@linux.ibm.com,
ohkwon1043@gmail.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mm: sparse: remove __section_nr() function
Date: Fri, 2 Jul 2021 19:57:13 +0200 [thread overview]
Message-ID: <747f311e-0239-0f4a-2561-11e2a34d8ce1@redhat.com> (raw)
In-Reply-To: <YN8EHfBu358OMugA@dhcp22.suse.cz>
On 02.07.21 14:18, Michal Hocko wrote:
> On Fri 02-07-21 18:41:32, Ohhoon Kwon wrote:
>> __section_nr() was used to convert struct mem_section * to section_nr.
>>
>> With CONFIG_SPARSEMEM_EXTREME enabled, however, __section_nr() can be
>> costly since it iterates all section roots to check if the given
>> mem_section is in its range.
>>
>> On the other hand, __nr_to_section() which converts section_nr to
>> mem_section can be done in O(1).
>>
>> The only users of __section_nr() was section_mark_present() and
>> find_memory_block().
>>
>> Since I changed both functions to use section_nr directly in the
>> preceeding patches, let's remove __section_nr() which has no users.
>>
>> Signed-off-by: Ohhoon Kwon <ohoono.kwon@samsung.com>
>
> I would go with a much shorter changelog. The function is not used
> anymore so it can be simply dropped.
> Acked-by: Michal Hocko <mhocko@suse.com>
Agreed, also avoid the use of "I" in patches.
Use something like
"As the last users of __section_nr() are gone, let's remove now unused
__section_nr()."
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Thanks,
David / dhildenb
next prev parent reply other threads:[~2021-07-02 17:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210702094457epcas1p295611b5799befffd016b8fccf3adceff@epcas1p2.samsung.com>
2021-07-02 9:41 ` [PATCH 0/3] mm: sparse: remove __section_nr() function Ohhoon Kwon
[not found] ` <CGME20210702094457epcas1p3ddac76bd3cc3e5b93fadb897cdb6dfd0@epcas1p3.samsung.com>
2021-07-02 9:41 ` [PATCH 1/3] mm: sparse: pass section_nr to section_mark_present Ohhoon Kwon
2021-07-02 12:13 ` Michal Hocko
2021-07-02 17:54 ` David Hildenbrand
[not found] ` <CGME20210702094457epcas1p40fba85e22861cf1cc85a085719030c24@epcas1p4.samsung.com>
2021-07-02 9:41 ` [PATCH 2/3] mm: sparse: pass section_nr to find_memory_block Ohhoon Kwon
2021-07-02 12:17 ` Michal Hocko
2021-07-02 17:55 ` David Hildenbrand
[not found] ` <CGME20210702094457epcas1p4e181c7b0a18338403a7ffb57f44807fe@epcas1p4.samsung.com>
2021-07-02 9:41 ` [PATCH 3/3] mm: sparse: remove __section_nr() function Ohhoon Kwon
2021-07-02 12:18 ` Michal Hocko
2021-07-02 17:57 ` David Hildenbrand [this message]
2021-07-02 12:58 ` [PATCH 0/3] " Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=747f311e-0239-0f4a-2561-11e2a34d8ce1@redhat.com \
--to=david@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=ohkwon1043@gmail.com \
--cc=ohoono.kwon@samsung.com \
--cc=rppt@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).