archive mirror
 help / color / mirror / Atom feed
From: Stephen Warren <>
To: Linus Walleij <>,
	"" <>,
Cc: Grant Likely <>,
	Barry Song <>,
	Shawn Guo <>,
	Thomas Abraham <>,
	Dong Aisheng <>,
	Rajendra Nayak <>,
	Haojian Zhuang <>,
	Linus Walleij <>,
	Mark Brown <>
Subject: RE: [PATCH] pinctrl: delete raw device pointers in pinmux maps
Date: Wed, 1 Feb 2012 09:37:36 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Linus Walleij wrote at Wednesday, February 01, 2012 10:24 AM:
> After discussion with Mark Brown in an unrelated thread about
> ADC lookups, it came to my knowledge that the ability to pass
> a struct device * in the regulator consumers is just a
> historical artifact, and not really recommended. Since there
> are no in-kernel users of these pointers, we just kill them
> right now, before someone starts to use them.
> Cc: Mark Brown <>
> Signed-off-by: Linus Walleij <>

I didn't review the code, but just wanted to note that
Documentation/pinctrl.txt needs some updates too, e.g. "Pinmux
board/machine configuration" says:

> As you can see we may have several pin controllers on the system and thus
> we need to specify which one of them that contain the functions we wish
> to map. The map can also use struct device * directly, so there is no
> inherent need to use strings to specify .dev_name or .ctrl_dev_name, these
> are for the situation where you do not have a handle to the struct device *,
> for example if they are not yet instantiated or cumbersome to obtain.

I'm fine with that being a separate patch if you want, or squashing
together two separate patches.


  parent reply	other threads:[~2012-02-01 17:37 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-01 17:24 [PATCH] pinctrl: delete raw device pointers in pinmux maps Linus Walleij
2012-02-01 17:27 ` Mark Brown
2012-02-01 17:37 ` Stephen Warren [this message]
2012-02-01 18:41   ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).