From: Robin Murphy <robin.murphy@arm.com>
To: Julien Grall <julien.grall@arm.com>,
linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org
Cc: logang@deltatee.com, douliyangs@gmail.com,
miquel.raynal@bootlin.com, marc.zyngier@arm.com,
jason@lakedaemon.net, tglx@linutronix.de, joro@8bytes.org,
bigeasy@linutronix.de, linux-rt-users@vger.kernel.org
Subject: Re: [PATCH v2 7/7] iommu/dma-iommu: Remove iommu_dma_map_msi_msg()
Date: Mon, 29 Apr 2019 16:19:02 +0100 [thread overview]
Message-ID: <74a6c2e6-126c-57f0-af5c-ab1130130eba@arm.com> (raw)
In-Reply-To: <20190429144428.29254-8-julien.grall@arm.com>
On 29/04/2019 15:44, Julien Grall wrote:
> A recent change split iommu_dma_map_msi_msg() in two new functions. The
> function was still implemented to avoid modifying all the callers at
> once.
>
> Now that all the callers have been reworked, iommu_dma_map_msi_msg() can
> be removed.
Yay! The end of my horrible bodge :)
Reviewed-by: Robin Murphy <robin.murphy@arm.com>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
>
> ---
> Changes in v2:
> - Rework the commit message
> ---
> drivers/iommu/dma-iommu.c | 20 --------------------
> include/linux/dma-iommu.h | 5 -----
> 2 files changed, 25 deletions(-)
>
> diff --git a/drivers/iommu/dma-iommu.c b/drivers/iommu/dma-iommu.c
> index 2309f59cefa4..12f4464828a4 100644
> --- a/drivers/iommu/dma-iommu.c
> +++ b/drivers/iommu/dma-iommu.c
> @@ -936,23 +936,3 @@ void iommu_dma_compose_msi_msg(struct msi_desc *desc,
> msg->address_lo &= cookie_msi_granule(domain->iova_cookie) - 1;
> msg->address_lo += lower_32_bits(msi_page->iova);
> }
> -
> -void iommu_dma_map_msi_msg(int irq, struct msi_msg *msg)
> -{
> - struct msi_desc *desc = irq_get_msi_desc(irq);
> - phys_addr_t msi_addr = (u64)msg->address_hi << 32 | msg->address_lo;
> -
> - if (WARN_ON(iommu_dma_prepare_msi(desc, msi_addr))) {
> - /*
> - * We're called from a void callback, so the best we can do is
> - * 'fail' by filling the message with obviously bogus values.
> - * Since we got this far due to an IOMMU being present, it's
> - * not like the existing address would have worked anyway...
> - */
> - msg->address_hi = ~0U;
> - msg->address_lo = ~0U;
> - msg->data = ~0U;
> - } else {
> - iommu_dma_compose_msi_msg(desc, msg);
> - }
> -}
> diff --git a/include/linux/dma-iommu.h b/include/linux/dma-iommu.h
> index 3fc48fbd6f63..ddd217c197df 100644
> --- a/include/linux/dma-iommu.h
> +++ b/include/linux/dma-iommu.h
> @@ -82,7 +82,6 @@ int iommu_dma_prepare_msi(struct msi_desc *desc, phys_addr_t msi_addr);
> void iommu_dma_compose_msi_msg(struct msi_desc *desc,
> struct msi_msg *msg);
>
> -void iommu_dma_map_msi_msg(int irq, struct msi_msg *msg);
> void iommu_dma_get_resv_regions(struct device *dev, struct list_head *list);
>
> #else
> @@ -122,10 +121,6 @@ static inline void iommu_dma_compose_msi_msg(struct msi_desc *desc,
> {
> }
>
> -static inline void iommu_dma_map_msi_msg(int irq, struct msi_msg *msg)
> -{
> -}
> -
> static inline void iommu_dma_get_resv_regions(struct device *dev, struct list_head *list)
> {
> }
>
next prev parent reply other threads:[~2019-04-29 15:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 14:44 [PATCH v2 0/7] iommu/dma-iommu: Split iommu_dma_map_msi_msg in two parts Julien Grall
2019-04-29 14:44 ` [PATCH v2 1/7] genirq/msi: Add a new field in msi_desc to store an IOMMU cookie Julien Grall
2019-04-29 15:12 ` Robin Murphy
2019-04-30 12:53 ` Auger Eric
2019-04-29 14:44 ` [PATCH v2 2/7] iommu/dma-iommu: Split iommu_dma_map_msi_msg() in two parts Julien Grall
2019-04-29 15:16 ` Robin Murphy
2019-04-29 15:28 ` Marc Zyngier
2019-04-30 12:54 ` Auger Eric
2019-04-29 14:44 ` [PATCH v2 3/7] irqchip/gicv2m: Don't map the MSI page in gicv2m_compose_msi_msg() Julien Grall
2019-04-30 12:34 ` Auger Eric
2019-04-29 14:44 ` [PATCH v2 4/7] irqchip/gic-v3-its: Don't map the MSI page in its_irq_compose_msi_msg() Julien Grall
2019-04-30 12:34 ` Auger Eric
2019-05-01 11:14 ` Julien Grall
2019-05-01 11:37 ` Marc Zyngier
2019-04-29 14:44 ` [PATCH v2 5/7] irqchip/ls-scfg-msi: Don't map the MSI page in ls_scfg_msi_compose_msg() Julien Grall
2019-04-29 14:44 ` [PATCH v2 6/7] irqchip/gic-v3-mbi: Don't map the MSI page in mbi_compose_m{b, s}i_msg() Julien Grall
2019-04-29 14:44 ` [PATCH v2 7/7] iommu/dma-iommu: Remove iommu_dma_map_msi_msg() Julien Grall
2019-04-29 15:19 ` Robin Murphy [this message]
2019-04-30 13:38 ` Auger Eric
2019-04-29 15:57 ` [PATCH v2 0/7] iommu/dma-iommu: Split iommu_dma_map_msi_msg in two parts Marc Zyngier
2019-04-29 19:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74a6c2e6-126c-57f0-af5c-ab1130130eba@arm.com \
--to=robin.murphy@arm.com \
--cc=bigeasy@linutronix.de \
--cc=douliyangs@gmail.com \
--cc=iommu@lists.linux-foundation.org \
--cc=jason@lakedaemon.net \
--cc=joro@8bytes.org \
--cc=julien.grall@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=logang@deltatee.com \
--cc=marc.zyngier@arm.com \
--cc=miquel.raynal@bootlin.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).