From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932972AbcLMLkW (ORCPT ); Tue, 13 Dec 2016 06:40:22 -0500 Received: from mail-wm0-f42.google.com ([74.125.82.42]:37407 "EHLO mail-wm0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753315AbcLMLkU (ORCPT ); Tue, 13 Dec 2016 06:40:20 -0500 Subject: Re: [PATCH] cifs: Fix smbencrypt() to stop pointing a scatterlist at the stack To: Andy Lutomirski , linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, sfrench@samba.org References: <8c273c9c41f51b34bb3115086f1d776895580637.1481575835.git.luto@kernel.org> <308cdb484648f98f6f0ad9feefd8acb2fe003aaf.1481575835.git.luto@kernel.org> Cc: Eric Biggers , linux-crypto@vger.kernel.org, Herbert Xu , Stephan Mueller , linux-cifs@vger.kernel.org From: Sergei Shtylyov Message-ID: <74b22139-4583-5bab-3916-4a32db81803e@cogentembedded.com> Date: Tue, 13 Dec 2016 14:40:17 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <308cdb484648f98f6f0ad9feefd8acb2fe003aaf.1481575835.git.luto@kernel.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello! On 12/12/2016 11:54 PM, Andy Lutomirski wrote: > smbencrypt() points a scatterlist to the stack, which is breaks if s/is//. > CONFIG_VMAP_STACK=y. > > Fix it by switching to crypto_cipher_encrypt_one(). The new code > should be considerably faster as an added benefit. > > This code is nearly identical to some code that Eric Biggers > suggested. > > Cc: stable@vger.kernel.org # 4.9 only > Reported-by: Eric Biggers > Signed-off-by: Andy Lutomirski [...] MBR, Sergei