From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85FE8C31E47 for ; Sat, 15 Jun 2019 12:46:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 687192184B for ; Sat, 15 Jun 2019 12:46:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726773AbfFOMqO (ORCPT ); Sat, 15 Jun 2019 08:46:14 -0400 Received: from szxga07-in.huawei.com ([45.249.212.35]:47024 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725943AbfFOMqO (ORCPT ); Sat, 15 Jun 2019 08:46:14 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 1BE1DBBF7D24A9E17971; Sat, 15 Jun 2019 20:46:05 +0800 (CST) Received: from [127.0.0.1] (10.133.213.239) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.439.0; Sat, 15 Jun 2019 20:46:01 +0800 Subject: Re: [PATCH v2 -next] firmware: ti_sci: remove set but not used variable 'dev' To: , , , , References: <20190614154421.17556-1-yuehaibing@huawei.com> <20190615123823.15708-1-yuehaibing@huawei.com> CC: , From: Yuehaibing Message-ID: <74b6ab2e-09c0-a91d-6339-cb6b72eb4261@huawei.com> Date: Sat, 15 Jun 2019 20:46:00 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20190615123823.15708-1-yuehaibing@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.133.213.239] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sorry, Pls ignore this, will fix the patch title On 2019/6/15 20:38, YueHaibing wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/firmware/ti_sci.c: In function ti_sci_cmd_ring_config: > drivers/firmware/ti_sci.c:2035:17: warning: variable dev set but not used [-Wunused-but-set-variable] > drivers/firmware/ti_sci.c: In function ti_sci_cmd_ring_get_config: > drivers/firmware/ti_sci.c:2104:17: warning: variable dev set but not used [-Wunused-but-set-variable] > drivers/firmware/ti_sci.c: In function ti_sci_cmd_rm_udmap_tx_ch_cfg: > drivers/firmware/ti_sci.c:2287:17: warning: variable dev set but not used [-Wunused-but-set-variable] > drivers/firmware/ti_sci.c: In function ti_sci_cmd_rm_udmap_rx_ch_cfg: > drivers/firmware/ti_sci.c:2357:17: warning: variable dev set but not used [-Wunused-but-set-variable] > > Use the 'dev' variable instead of 'info->dev' to fix this. > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing > --- > v2: use the 'dev' variable as Suman Anna's suggestion > --- > drivers/firmware/ti_sci.c | 24 ++++++++++++------------ > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c > index 86b2727..c8da6e2 100644 > --- a/drivers/firmware/ti_sci.c > +++ b/drivers/firmware/ti_sci.c > @@ -2046,7 +2046,7 @@ static int ti_sci_cmd_ring_config(const struct ti_sci_handle *handle, > sizeof(*req), sizeof(*resp)); > if (IS_ERR(xfer)) { > ret = PTR_ERR(xfer); > - dev_err(info->dev, "RM_RA:Message config failed(%d)\n", ret); > + dev_err(dev, "RM_RA:Message config failed(%d)\n", ret); > return ret; > } > req = (struct ti_sci_msg_rm_ring_cfg_req *)xfer->xfer_buf; > @@ -2062,7 +2062,7 @@ static int ti_sci_cmd_ring_config(const struct ti_sci_handle *handle, > > ret = ti_sci_do_xfer(info, xfer); > if (ret) { > - dev_err(info->dev, "RM_RA:Mbox config send fail %d\n", ret); > + dev_err(dev, "RM_RA:Mbox config send fail %d\n", ret); > goto fail; > } > > @@ -2071,7 +2071,7 @@ static int ti_sci_cmd_ring_config(const struct ti_sci_handle *handle, > > fail: > ti_sci_put_one_xfer(&info->minfo, xfer); > - dev_dbg(info->dev, "RM_RA:config ring %u ret:%d\n", index, ret); > + dev_dbg(dev, "RM_RA:config ring %u ret:%d\n", index, ret); > return ret; > } > > @@ -2115,7 +2115,7 @@ static int ti_sci_cmd_ring_get_config(const struct ti_sci_handle *handle, > sizeof(*req), sizeof(*resp)); > if (IS_ERR(xfer)) { > ret = PTR_ERR(xfer); > - dev_err(info->dev, > + dev_err(dev, > "RM_RA:Message get config failed(%d)\n", ret); > return ret; > } > @@ -2125,7 +2125,7 @@ static int ti_sci_cmd_ring_get_config(const struct ti_sci_handle *handle, > > ret = ti_sci_do_xfer(info, xfer); > if (ret) { > - dev_err(info->dev, "RM_RA:Mbox get config send fail %d\n", ret); > + dev_err(dev, "RM_RA:Mbox get config send fail %d\n", ret); > goto fail; > } > > @@ -2150,7 +2150,7 @@ static int ti_sci_cmd_ring_get_config(const struct ti_sci_handle *handle, > > fail: > ti_sci_put_one_xfer(&info->minfo, xfer); > - dev_dbg(info->dev, "RM_RA:get config ring %u ret:%d\n", index, ret); > + dev_dbg(dev, "RM_RA:get config ring %u ret:%d\n", index, ret); > return ret; > } > > @@ -2298,7 +2298,7 @@ static int ti_sci_cmd_rm_udmap_tx_ch_cfg(const struct ti_sci_handle *handle, > sizeof(*req), sizeof(*resp)); > if (IS_ERR(xfer)) { > ret = PTR_ERR(xfer); > - dev_err(info->dev, "Message TX_CH_CFG alloc failed(%d)\n", ret); > + dev_err(dev, "Message TX_CH_CFG alloc failed(%d)\n", ret); > return ret; > } > req = (struct ti_sci_msg_rm_udmap_tx_ch_cfg_req *)xfer->xfer_buf; > @@ -2323,7 +2323,7 @@ static int ti_sci_cmd_rm_udmap_tx_ch_cfg(const struct ti_sci_handle *handle, > > ret = ti_sci_do_xfer(info, xfer); > if (ret) { > - dev_err(info->dev, "Mbox send TX_CH_CFG fail %d\n", ret); > + dev_err(dev, "Mbox send TX_CH_CFG fail %d\n", ret); > goto fail; > } > > @@ -2332,7 +2332,7 @@ static int ti_sci_cmd_rm_udmap_tx_ch_cfg(const struct ti_sci_handle *handle, > > fail: > ti_sci_put_one_xfer(&info->minfo, xfer); > - dev_dbg(info->dev, "TX_CH_CFG: chn %u ret:%u\n", params->index, ret); > + dev_dbg(dev, "TX_CH_CFG: chn %u ret:%u\n", params->index, ret); > return ret; > } > > @@ -2368,7 +2368,7 @@ static int ti_sci_cmd_rm_udmap_rx_ch_cfg(const struct ti_sci_handle *handle, > sizeof(*req), sizeof(*resp)); > if (IS_ERR(xfer)) { > ret = PTR_ERR(xfer); > - dev_err(info->dev, "Message RX_CH_CFG alloc failed(%d)\n", ret); > + dev_err(dev, "Message RX_CH_CFG alloc failed(%d)\n", ret); > return ret; > } > req = (struct ti_sci_msg_rm_udmap_rx_ch_cfg_req *)xfer->xfer_buf; > @@ -2392,7 +2392,7 @@ static int ti_sci_cmd_rm_udmap_rx_ch_cfg(const struct ti_sci_handle *handle, > > ret = ti_sci_do_xfer(info, xfer); > if (ret) { > - dev_err(info->dev, "Mbox send RX_CH_CFG fail %d\n", ret); > + dev_err(dev, "Mbox send RX_CH_CFG fail %d\n", ret); > goto fail; > } > > @@ -2401,7 +2401,7 @@ static int ti_sci_cmd_rm_udmap_rx_ch_cfg(const struct ti_sci_handle *handle, > > fail: > ti_sci_put_one_xfer(&info->minfo, xfer); > - dev_dbg(info->dev, "RX_CH_CFG: chn %u ret:%d\n", params->index, ret); > + dev_dbg(dev, "RX_CH_CFG: chn %u ret:%d\n", params->index, ret); > return ret; > } > >