From: Hans de Goede <hdegoede@redhat.com>
To: cgel.zte@gmail.com, dvhart@infradead.org
Cc: andy@infradead.org, tglx@linutronix.de,
platform-driver-x86@vger.kernel.org,
linux-kernel@vger.kernel.org,
Minghao Chi <chi.minghao@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH] x86, olpc: Avoid leak OF node on error
Date: Mon, 23 May 2022 13:53:18 +0200 [thread overview]
Message-ID: <74b7b668-a1f6-596f-8000-041f9ca7b181@redhat.com> (raw)
In-Reply-To: <20220523111253.3114-1-chi.minghao@zte.com.cn>
Hi,
On 5/23/22 13:12, cgel.zte@gmail.com wrote:
> From: Minghao Chi <chi.minghao@zte.com.cn>
>
> The OF node should be put before returning error in xo1_rtc_init(),
> otherwise node's refcount will be leaked.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
> ---
> arch/x86/platform/olpc/olpc-xo1-rtc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/platform/olpc/olpc-xo1-rtc.c b/arch/x86/platform/olpc/olpc-xo1-rtc.c
> index 57f210cda761..dc5ac56cd9dd 100644
> --- a/arch/x86/platform/olpc/olpc-xo1-rtc.c
> +++ b/arch/x86/platform/olpc/olpc-xo1-rtc.c
> @@ -59,9 +59,9 @@ static int __init xo1_rtc_init(void)
> struct device_node *node;
>
> node = of_find_compatible_node(NULL, NULL, "olpc,xo1-rtc");
> + of_node_put(node);
> if (!node)
> return 0;
> - of_node_put(node);
>
> pr_info("olpc-xo1-rtc: Initializing OLPC XO-1 RTC\n");
> rdmsrl(MSR_RTC_DOMA_OFFSET, rtc_info.rtc_day_alarm);
of_node_put on a NULL node is a no-op, so this patch
does not make any functional difference and it makes the
code harder to read.
nack.
Regards,
Hans
next prev parent reply other threads:[~2022-05-23 11:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-23 11:12 [PATCH] x86, olpc: Avoid leak OF node on error cgel.zte
2022-05-23 11:53 ` Hans de Goede [this message]
2022-05-23 11:53 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74b7b668-a1f6-596f-8000-041f9ca7b181@redhat.com \
--to=hdegoede@redhat.com \
--cc=andy@infradead.org \
--cc=cgel.zte@gmail.com \
--cc=chi.minghao@zte.com.cn \
--cc=dvhart@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).