From: Jonathan Cameron <jic23@kernel.org>
To: Jacek Anaszewski <j.anaszewski@samsung.com>,
Alison Schofield <amsfield22@gmail.com>
Cc: pmeerw@pmeerw.net, knaack.h@gmx.de, lars@metafoo.de,
linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] iio: light: gp2ap020a00f: use iio helper function to lock direct mode
Date: Sat, 11 Jun 2016 16:54:12 +0100 [thread overview]
Message-ID: <74b809a6-b771-d59f-e4e8-88ed7c21c0d3@kernel.org> (raw)
In-Reply-To: <5757C69B.6060502@samsung.com>
On 08/06/16 08:17, Jacek Anaszewski wrote:
> Hi Alison,
>
> On 06/08/2016 02:19 AM, Alison Schofield wrote:
>> Replace the code that guarantees the device stays in direct mode
>> with iio_device_claim_direct_mode() which does same. Includes a
>> tiny bit of refactoring (single case -> if) and simplified return
>> flow.
>>
>> Signed-off-by: Alison Schofield <amsfield22@gmail.com>
>> Cc: Daniel Baluta <daniel.baluta@gmail.com>
>> ---
>> drivers/iio/light/gp2ap020a00f.c | 18 +++++-------------
>> 1 file changed, 5 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/iio/light/gp2ap020a00f.c b/drivers/iio/light/gp2ap020a00f.c
>> index 6d41086..af73af3 100644
>> --- a/drivers/iio/light/gp2ap020a00f.c
>> +++ b/drivers/iio/light/gp2ap020a00f.c
>> @@ -1287,22 +1287,14 @@ static int gp2ap020a00f_read_raw(struct iio_dev *indio_dev,
>> struct gp2ap020a00f_data *data = iio_priv(indio_dev);
>> int err = -EINVAL;
>>
>> - mutex_lock(&data->lock);
>> -
>> - switch (mask) {
>> - case IIO_CHAN_INFO_RAW:
>> - if (iio_buffer_enabled(indio_dev)) {
>> - err = -EBUSY;
>> - goto error_unlock;
>> - }
>> + if (mask == IIO_CHAN_INFO_RAW) {
>> + err = iio_device_claim_direct_mode(indio_dev);
>> + if (err)
>> + return err;
>>
>> err = gp2ap020a00f_read_channel(data, chan, val);
>> - break;
>> + iio_device_release_direct_mode(indio_dev);
>> }
>> -
>> -error_unlock:
>> - mutex_unlock(&data->lock);
>> -
>> return err < 0 ? err : IIO_VAL_INT;
>> }
>>
>>
>
> Nice patch.
>
> Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>
Applied to the togreg branch of iio.git - initially pushed out as
testing for the autobuilders to play with it.
I would have slightly preferred the patch to not change the
case to an if (as really a slightly separate cleanup from
the main target of the patch).
Good changes though!
Thanks,
Jonathan
Thanks,
Jonathan
>
prev parent reply other threads:[~2016-06-11 15:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-08 0:19 [PATCH] iio: light: gp2ap020a00f: use iio helper function to lock direct mode Alison Schofield
2016-06-08 7:17 ` Jacek Anaszewski
2016-06-11 15:54 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74b809a6-b771-d59f-e4e8-88ed7c21c0d3@kernel.org \
--to=jic23@kernel.org \
--cc=amsfield22@gmail.com \
--cc=j.anaszewski@samsung.com \
--cc=knaack.h@gmx.de \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).